Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,187 Commits 541 Branches 635 Tags
a329e968fc3c67732e23ec6ff93a9bfe4530f61c
Commit Graph
2220 Commits
Author SHA1 Message Date
Alex DvornikovandFacebook Github Bot a47431ed74 Adopt split segments registration approach on Android 
Differential Revision: D6284863

fbshipit-source-id: 0df6b90eb0cbeab4c8a2b11f1e4dcbd5d5dfab72
 2017-11-09 12:23:51 -08:00
Alex DvornikovandFacebook Github Bot cff0d8e0e5 Register split segment paths with RAMBundleRegistry 
Differential Revision: D6284466

fbshipit-source-id: c80cf929af38f92f06cca5b366c58785ae992d83
 2017-11-09 12:23:46 -08:00
Dmitry ZakharovandFacebook Github Bot 260e6d2355 Remove shared bridge experiment 
Reviewed By: kathryngray

Differential Revision: D6284437

fbshipit-source-id: 14e0516f22dde04c0bbc4eb8fac603590d32d66a
 2017-11-09 09:55:05 -08:00
Ramanpreet NaraandFacebook Github Bot 7170543e80 Make direction-aware borders work with APIs >= 17 
Reviewed By: achen1

Differential Revision: D6189497

fbshipit-source-id: 848ca35540c5a4eb1581e0b7c39f8fa880540317
 2017-11-08 10:31:21 -08:00
Alex DvornikovandFacebook Github Bot 6ecae73fe5 Remove RAMBundleRegistry subclasses 
Differential Revision: D6262247

fbshipit-source-id: 708f919e34f1706d9aca19a34ad8ea506e9f8d8b
 2017-11-08 04:12:20 -08:00
Brent EricksonandFacebook Github Bot e6f542d620 When subscribing for network connectivity broadcasts, also query the value so we always have the most up-to-date value. 
Summary:
We've seen cases (based on logs) where NetInfo is reporting no connectivity, but network requests still work. This will keep status up to date after app foreground <-> backgrounds, since we don't listen to broadcasts when backgrounded.

This is rather difficult to test given we haven't nailed an internal repro (evidence is solely based on device/app logs).  Testing has been done to ensure that there are no behavioural changes on devices that were previously working (no regressions).
Closes https://github.com/facebook/react-native/pull/15558

Differential Revision: D6264708

Pulled By: hramos

fbshipit-source-id: 1648cadb59949103d0a595614b38024ec9236719
 2017-11-07 14:56:23 -08:00
Dmitry ZakharovandFacebook Github Bot 1b71e03932 Make RN Events registered disregarding ViewManager use pattern. 
Reviewed By: fromcelticpark

Differential Revision: D6260009

fbshipit-source-id: f3d00162f8473976264ebef040d01163950f2170
 2017-11-07 11:32:34 -08:00
Omri GindiandFacebook Github Bot a6465d1c17 Backed out changeset 322626be193e 
Reviewed By: wutalman

Differential Revision: D6258856

fbshipit-source-id: 392dc91f87148c70817f13858a7fcd368f028b2d
 2017-11-07 04:53:40 -08:00
Alex DvornikovandFacebook Github Bot f1258181ee Rename "js-bundles" to "js-segments" 
Differential Revision: D6244399

fbshipit-source-id: d1606d126e3b598b19fa8a0955438c8dec76f5d0
 2017-11-06 18:25:52 -08:00
Marc HorowitzandFacebook Github Bot 515eb0e801 Fix a race condition in the animation module 
Summary:
update() is called from the choreographer, so it can be
invoked asynchronously relative to RN.  If it's called while the node
tree is incomplete, this can be called with no parent.  Don't treat an
unparented node as an invariant failure, just skip over it.

Reviewed By: AaaChiuuu

Differential Revision: D6249038

fbshipit-source-id: d22807dff1659bf29a81893ab97d0fe7c19de512
 2017-11-06 13:49:46 -08:00
Dmitry ZakharovandFacebook Github Bot fdf04953c0 Make RN Events registered disregarding ViewManager use pattern. 
Reviewed By: bvaughn

Differential Revision: D6223864

fbshipit-source-id: 322626be193e5fa840d3e5477e86adaa90f2726d
 2017-11-06 06:40:19 -08:00
Bartol KaruzaandFacebook Github Bot 3f1b021506 Inverted descent/ascent Android prioritisation to match iOS lineHeight behaviour 
Summary:
We noticed that on Android the lineHeight behaviour is different from iOS for built in fonts and custom fonts. The problem becomes visible when the lineHeight approaches the fontSize, showing a cut-off on the bottom of the TextView. This issue has been raised before in #10712. There is a mention of a PR with a fix in that issue, which has not been merged yet. This implementation is a less intrusive fix leaving the current lineHeight approach in place and fixing the discrepancy only.

This proposed change prioritises ascent over descent for reduction, making the lineHeight functionality behave identical to iOS.

There is no existing test covering the lineHeight property and its behaviour in the CustomLineHeightSpan. This PR contains new unit tests that covers the various scenario's for the lineHeight calculations.

The original behaviour, before the change can against these unit tests. The case that fails is `shouldReduceAscentThird`, which can be made to succeed on the old code by changing the asserts to:
```
    assertThat(fm.top).isEqualTo(-5);
    assertThat(fm.ascent).isEqualTo(-5);
    assertThat(fm.descent).isEqualTo(-4);
    assertThat(fm.bottom).isEqualTo(-4);
```
The unit test succeeds for the current implementation, which has the values for ascent and descent inverted.

Below screenshots show before, after and iOS:

BEFORE
![screen shot 2017-10-18 at 15 35 41](https://user-images.githubusercontent.com/1605731/31721688-58d7086a-b41a-11e7-8186-9a201e2acb01.png)

AFTER
![screen shot 2017-10-18 at 15 37 02](https://user-images.githubusercontent.com/1605731/31721665-473cf86c-b41a-11e7-94d5-7a70eaf99889.png)

iOS
![screen shot 2017-10-18 at 15 35 22](https://user-images.githubusercontent.com/1605731/31721712-707e30a6-b41a-11e7-9baa-f886a66837e6.png)

[ANDROID] [BUGFIX] [Text] - Fix the lineHeight behaviour on Android to match iOS
Closes https://github.com/facebook/react-native/pull/16448

Differential Revision: D6221854

Pulled By: andreicoman11

fbshipit-source-id: 7292f0f05f212d79678ac9d73e8a46bf93f1a7c6
 2017-11-06 05:00:41 -08:00
Dan CaspiandFacebook Github Bot 19de7fcb22 Moving some RAM logic to Instance. 
Reviewed By: michalgr

Differential Revision: D6208977

fbshipit-source-id: 28339d07c58f1acc816be02f2707ef75529fa069
 2017-11-03 05:32:02 -07:00
Alex DvornikovandFacebook Github Bot b5651d945c Add "setJsBundlesDirectory" method to CatalystInstanceImpl 
Differential Revision: D6042493

fbshipit-source-id: 950c6d6bdc2e0b62b14c9bcfc86233159a002c67
 2017-11-01 06:54:44 -07:00
Pritesh NandgaonkarandFacebook Github Bot 0230672275 Reverting the dirty child optimization 
Reviewed By: emilsjolander

Differential Revision: D6203290

fbshipit-source-id: 8e42abb70e55f0fac90faaa21ecdbe0fbb76ce6b
 2017-10-31 23:15:43 -07:00
Pritesh NandgaonkarandFacebook Github Bot 587225ab45 Used hasDirtyChildren tag for the optimization 
Reviewed By: emilsjolander

Differential Revision: D6134754

fbshipit-source-id: bbcfee14058140b946401de756a3f130de0f51cd
 2017-10-31 08:21:54 -07:00
Dmitry ZakharovandFacebook Github Bot 387a3557ae Remove FlatUI references from fb4a. 
Reviewed By: AaaChiuuu

Differential Revision: D6189136

fbshipit-source-id: c92a4d46098ff36ddbf267d150c6fa559a60a1e8
 2017-10-31 06:46:06 -07:00
Dmitry ZakharovandFacebook Github Bot a5550a56ea Introduce getConstants generation for Native Modules codegen. 
Reviewed By: fkgozali

Differential Revision: D6125394

fbshipit-source-id: 13b48c75056868f45394f277d75fb05d167f1c9f
 2017-10-30 08:16:48 -07:00
Alexey LangandFacebook Github Bot 9742bcb4ba Remove quicklog 
Reviewed By: AaaChiuuu

Differential Revision: D6172832

fbshipit-source-id: d239ce8bef0918d3e90662258b6eabe3502f4897
 2017-10-30 08:12:34 -07:00
David VaccaandFacebook Github Bot c278020633 Fixing RTL HorizontalScrolling in Android 
Reviewed By: astreet

Differential Revision: D6170631

fbshipit-source-id: 254e6ed9a4d6e42b6d1215de1ff63aedb2c07a0a
 2017-10-27 12:34:10 -07:00
Jonathan KeljoandFacebook Github Bot dd016f334c Automated fixups for Instagram 
Reviewed By: dreiss

Differential Revision: D6168048

fbshipit-source-id: 0e51319d93fd697db01ea3933f48cd06a6ffac12
 2017-10-27 00:52:40 -07:00
Andrew Chen (Eng)andFacebook Github Bot 9b6f160c04 Revert D5638458: Fixing RTL HorizontalScrolling in Android 
Differential Revision: D5638458

fbshipit-source-id: f4474a12821cd2c20f57ce3bac5996c327ceaa33
 2017-10-26 15:33:10 -07:00
David VaccaandFacebook Github Bot 36c951d24f Fixing RTL HorizontalScrolling in Android 
Reviewed By: astreet

Differential Revision: D5638458

fbshipit-source-id: 08a5070a362eb43e12140cc204172d0950a1b720
 2017-10-26 11:25:22 -07:00
Charles DickandFacebook Github Bot 1c104310fb RN catalyst instance destroy markers 
Reviewed By: alexeylang

Differential Revision: D6109891

fbshipit-source-id: 2cd1491381220a80f71f9ab205a2c6a309ed35ae
 2017-10-26 10:28:41 -07:00
Dmitry ZakharovandFacebook Github Bot f0fb720eaa Introduce mobile config flag to load classes for View Managers 
Reviewed By: kathryngray

Differential Revision: D6148468

fbshipit-source-id: d0f919f63922dae4b0720f22fa70ab4a7f67b48a
 2017-10-26 08:51:11 -07:00
Ramanpreet NaraandFacebook Github Bot efa4d3c222 Rename I18nManager Left/Right swap methods 
Reviewed By: fkgozali

Differential Revision: D6140072

fbshipit-source-id: 282dc614c036de8f217a729f21a1bbe92b8afd7d
 2017-10-24 20:45:59 -07:00
Andrew Chen (Eng)andFacebook Github Bot 90a42396b9 React native shadow tree sonar plugin 
Reviewed By: emilsjolander

Differential Revision: D6050845

fbshipit-source-id: 8c041b26ed4eb701830f1aced73d996c71cb3326
 2017-10-24 18:34:40 -07:00
Rafael MagalhãesandFacebook Github Bot ce967c6fbe Requesting permission results into ArrayIndexOutOfBoundsException 
Summary:
Reported in Issue #15928

Fixing bug when permission showing dialog and user go to home and re-open minimized app.

1. Ask for permission
2. Minimize app (Press HomeButton)
3. Open app again via shortcut

 [ANDROID] [BUGFIX] [PermissionsModule.java] - Fixed bug when asked for permission Cause: java.lang.ArrayIndexOutOfBoundsException · length=0; index=0
Closes https://github.com/facebook/react-native/pull/16507

Differential Revision: D6133708

Pulled By: shergin

fbshipit-source-id: 9c05d1d5d16fedf718ad5113df69a4df3af62013
 2017-10-23 23:30:08 -07:00
Jonathan KeljoandFacebook Github Bot 18364e95b7 Export deps to be source-ABI friendly 
Reviewed By: dreiss

Differential Revision: D6124559

fbshipit-source-id: f831196724f8e171b86c58af5d2ed7944ecf6b6b
 2017-10-23 12:22:53 -07:00
Alexey LangandFacebook Github Bot 95073f8589 Use ReactMarker for all perf logging in the bridge 
Reviewed By: AaaChiuuu

Differential Revision: D6030270

fbshipit-source-id: c9fa04d4f2816e4e0a4a14caf41795d0f547a7a0
 2017-10-22 04:04:42 -07:00
Tao HuangandFacebook Github Bot 7e0b7ef8d0 Fix wrong error code when location service is turned off on Android device 
Reviewed By: achen1

Differential Revision: D6106890

fbshipit-source-id: ab6ccdc2625745e4bbcdb0d7fe284de504d09641
 2017-10-19 19:52:57 -07:00
Ramanpreet NaraandFacebook Github Bot 99d294bf3d Consider negative border radii and widths invalid 
Reviewed By: achen1

Differential Revision: D5998369

fbshipit-source-id: d54302777f4eeb13f4521800130c17ac07f1b354
 2017-10-19 18:08:25 -07:00
Ramanpreet NaraandFacebook Github Bot 00c9c1ad74 Implement direction-aware border clipping 
Reviewed By: achen1

Differential Revision: D6015812

fbshipit-source-id: 406ddb12884a1c490cee784c6ef42322bd497b24
 2017-10-18 19:33:33 -07:00
Ramanpreet NaraandFacebook Github Bot 875f273dba Implement border(Start|End)Color for rounded borders 
Reviewed By: achen1

Differential Revision: D6014637

fbshipit-source-id: 33c10ec1f84075e0bb1c1f529aa7231497028380
 2017-10-18 19:33:33 -07:00
Ramanpreet NaraandFacebook Github Bot 38c2c26d90 Implement rounded border(Start|End)Width 
Reviewed By: achen1

Differential Revision: D6013412

fbshipit-source-id: e7aa7a3cd9e3ed72b25664efee59e42792098fbd
 2017-10-18 19:33:33 -07:00
Ramanpreet NaraandFacebook Github Bot 1a7abcf526 Android: Implement border(Top|Bottom)(Start|End)Radius for RN 
Reviewed By: achen1

Differential Revision: D5924734

fbshipit-source-id: 24759326064c11d2cd8948c7a710376ca9f41c63
 2017-10-18 19:33:32 -07:00
Ramanpreet NaraandFacebook Github Bot 0f467a25ed Android: Implement border(Start|End)Color for RN non-rounded borders 
Reviewed By: achen1

Differential Revision: D5921865

fbshipit-source-id: ed964291cba0c701de677c24c54f885cda78e7cc
 2017-10-18 19:33:32 -07:00
Ramanpreet NaraandFacebook Github Bot 7ed7593b2b Android: Implement border(Start|End)Width for non-rounded borders 
Reviewed By: achen1

Differential Revision: D5917755

fbshipit-source-id: 3ec0ab1a1e191f5f6fd956691995e95937a513cc
 2017-10-18 19:33:32 -07:00
Ramanpreet NaraandFacebook Github Bot 04a8c62313 Android: Implement margin(Start|End) styles for RN 
Reviewed By: achen1

Differential Revision: D5907651

fbshipit-source-id: 4df7583483e6f10b5433b9fa9d9345e00ccedd20
 2017-10-18 19:33:32 -07:00
Ramanpreet NaraandFacebook Github Bot 1ed08d3c01 Android: Implement padding(Start|End) styles for RN 
Reviewed By: AaaChiuuu

Differential Revision: D5907207

fbshipit-source-id: c9bb322f94d701463be35fb1ca92aab80f47d8ab
 2017-10-18 19:33:31 -07:00
Ramanpreet NaraandFacebook Github Bot dc92e69867 Android: Forward RN start/end styles to Yoga 
Reviewed By: AaaChiuuu

Differential Revision: D5906097

fbshipit-source-id: 79bd43ea54572eb612e781628551bccf5a4f948d
 2017-10-18 19:33:31 -07:00
Ramanpreet NaraandFacebook Github Bot 98547d4bcf Implement gating support for direction-aware API changes 
Reviewed By: achen1

Differential Revision: D6045083

fbshipit-source-id: 857a43029ad88d2324ec77145a1e30d92b5e8fae
 2017-10-18 19:33:31 -07:00
Ramanpreet NaraandFacebook Github Bot f7888310d4 Implement border(Left|Right|Top|Bottom)Color for rounded borders 
Reviewed By: achen1

Differential Revision: D6009609

fbshipit-source-id: 6a247a14aa48ac2edc637bf064216407a3a9a81f
 2017-10-18 19:33:30 -07:00
Ramanpreet NaraandFacebook Github Bot 4994d6a389 Implement partial rounded borders 
Reviewed By: achen1

Differential Revision: D5982241

fbshipit-source-id: 2f694daca7e1b16b5ff65f07c7d15dd558a4b7e8
 2017-10-18 19:33:30 -07:00
Ramanpreet NaraandFacebook Github Bot de313f6fdd Fix border clipping 
Reviewed By: achen1

Differential Revision: D5992045

fbshipit-source-id: fccd864dbc24592c3cd4df7300aca5096537e1d8
 2017-10-18 19:33:30 -07:00
Alexey LangandFacebook Github Bot 52a67db629 Fix Systrace section for Lazy View Managers 
Differential Revision: D6088310

fbshipit-source-id: cf14c9cc91068cfabf4e7c1bbae5df7f25e0ced3
 2017-10-18 12:18:12 -07:00
Andrew Chen (Eng)andFacebook Github Bot 91372e8f9a Add callback for UIImplementation layout updates 
Differential Revision: D6063839

fbshipit-source-id: ae08fd2fc6c6365813b8077efe14990a0355a5c7
 2017-10-17 07:47:12 -07:00
Andrew Chen (Eng)andFacebook Github Bot dc16150bae Expose ReactInstanceManager from ReactRootView 
Reviewed By: AaaChiuuu

Differential Revision: D6051991

fbshipit-source-id: f175fc273895d7e9fedec73428d61395ae00649f
 2017-10-17 04:31:03 -07:00
Max ShermanandFacebook Github Bot f3b117abd0 Un-revert logMarker for hermes diff 
Reviewed By: mhorowitz

Differential Revision: D6051880

fbshipit-source-id: 0ce4bbed9ba8579033ee5397ff6c0975b6886fb1
 2017-10-13 14:01:43 -07:00
Max ShermanandFacebook Github Bot e60a2d0a53 Revert D5939688: [hermes][rn] Share logPerfMarker with hermes 
Differential Revision: D5939688

fbshipit-source-id: 37daeeaa01144472c26383106c88dd49bb99a37b
 2017-10-12 19:21:42 -07:00