react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Danilo Bürger	4d40b53c12	Find node on m1 via homebrew node managers (#31678 ) Summary: Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew. ## Changelog [General] [Changed] - Find node on m1 via homebrew node managers Pull Request resolved: https://github.com/facebook/react-native/pull/31678 Test Plan: On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. cc: dulmandakh as discussed in https://github.com/facebook/react-native/pull/31622 Reviewed By: ShikaSD Differential Revision: D28967386 Pulled By: PeteTheHeat fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259	2021-06-08 11:20:10 -07:00
Dulmandakh	502b819049	find-node.sh supports Homebrew on M1 (#31622 ) Summary: Homebrew on M1 installs executable binaries in /opt/homebrew/bin (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH. The way react.gradle trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106 Fixes https://github.com/facebook/react-native/issues/31621 https://github.com/facebook/react-native/issues/31592 ## Changelog [General] [Changed] - find-node.sh supports Homebrew on M1 Pull Request resolved: https://github.com/facebook/react-native/pull/31622 Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed. Reviewed By: ShikaSD Differential Revision: D28808206 Pulled By: hramos fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec	2021-06-02 15:32:08 -07:00
Héctor Ramos	322e8f70cf	Re-use Node path resolution script Summary: This fix is ported from 0.64-stable. It moves the Node resolution script from react-native-xcode.sh to find-node.sh for re-use in the codegen. Changelog: [Codegen][Internal] Reviewed By: fkgozali Differential Revision: D27437216 fbshipit-source-id: ecb8a7a30411a709c095a0a34115b6dc48b99f1e	2021-04-02 13:56:52 -07:00

Author

SHA1

Message

Date

Danilo Bürger

4d40b53c12

Find node on m1 via homebrew node managers (#31678 )

Summary:
Adds homebrew on m1 to path before evaluating `command -v brew` to support nvm on m1 via homebrew.

## Changelog

[General] [Changed] - Find node on m1 via homebrew node managers

Pull Request resolved: https://github.com/facebook/react-native/pull/31678

Test Plan:
On M1, use nvm via homebrew. Create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed.

cc: dulmandakh as discussed in https://github.com/facebook/react-native/pull/31622

Reviewed By: ShikaSD

Differential Revision: D28967386

Pulled By: PeteTheHeat

fbshipit-source-id: 3d4a41dd3cc25fbf77778b16468a236b141d1259

2021-06-08 11:20:10 -07:00

Dulmandakh

502b819049

find-node.sh supports Homebrew on M1 (#31622 )

Summary:
Homebrew on M1 installs executable binaries in **/opt/homebrew/bin** (See https://brew.sh/2021/02/05/homebrew-3.0.0/), and FBReactNativeSpec.build is failing because it couldn't find node. This PR changes find-node.sh script to add /opt/homebrew/bin into $PATH.

The way **react.gradle** trying to execute node is not using user environment variables, but system defaults, so it couldn't find it. I removed node execution, and hard coded cli path in parity with iOS https://github.com/facebook/react-native/blob/d1ab03235cb4b93304150878d2b9057ab45bba77/scripts/react-native-xcode.sh#L106

Fixes https://github.com/facebook/react-native/issues/31621 https://github.com/facebook/react-native/issues/31592

## Changelog

[General] [Changed] - find-node.sh supports Homebrew on M1

Pull Request resolved: https://github.com/facebook/react-native/pull/31622

Test Plan: On M1, create a RN project and it'll fail to build iOS app. Apply the patch, and build will succeed.

Reviewed By: ShikaSD

Differential Revision: D28808206

Pulled By: hramos

fbshipit-source-id: 8b313b6685462a15e67d99c61a0202d17fece1ec

2021-06-02 15:32:08 -07:00

Héctor Ramos

322e8f70cf

Re-use Node path resolution script

Summary:
This fix is ported from 0.64-stable. It moves the Node resolution script from react-native-xcode.sh to find-node.sh for re-use in the codegen.

Changelog: [Codegen][Internal]

Reviewed By: fkgozali

Differential Revision: D27437216

fbshipit-source-id: ecb8a7a30411a709c095a0a34115b6dc48b99f1e

2021-04-02 13:56:52 -07:00

3 Commits