4 Commits

Author	SHA1	Message	Date
Héctor Ramos	9c3f4c021e	Bots cleanup, avoid leaving inline reviews when N>5 (#24923) ... Summary: This PR cleans up some of our GitHub bots. The overall goal is to make the contribution process just a tad nicer. ### analysis-bot * The bot will continue leaving GitHub Reviews when it finds lint issues, but will abstain from leaving inline comments if they would exceed 5 in number. * The review comment left by the bot has instructions on how to reproduce the lint issues locally. This will educate PR authors on how to run lint and fix the issues without unnecessarily spamming the PR with 50+ comments, while still providing useful reviews to authors when only a handful of lint issues slip by. * Code moved to `bots/` directory for ease of discovery and co-location with pull-bot. * Added `yarn lint-ci` command. This seems like the right choice: it's running `yarn lint` and other linters, and it is only intended to run on CI. * It's still possible to run `yarn lint-ci` locally, though the script will stop short of posting a review to GitHub unless the necessary envvars are provided. * Added `yarn shellcheck` command. This can be run locally, though it requires `shellcheck` to be installed. * Outside of this PR, I added instructions on using shellcheck to https://github.com/facebook/react-native/wiki/Development-Dependencies * Updated Circle CI config to use these new commands, and streamlined the `analyze_pr` step. * Documented analysis-bot in `bots/README.md`. ### pull-bot * Bumped `danger-js` dependency. No breaking changes found in this minor bump from what I can tell. * Documented pull-bot in `bots/README.md`. ### misc * PR template: don't use jargon. ## Changelog [Internal] [Changed] - GitHub Bots cleanup Pull Request resolved: https://github.com/facebook/react-native/pull/24923 Differential Revision: D15399744 Pulled By: hramos fbshipit-source-id: 32632e775f8554424072270e3f98542de84bfb8c	2019-05-21 19:38:54 -07:00
Héctor Ramos	6967a4fa56	Flag code analysis issues once per converter used (#21503) ... Summary: Fixes issue where the bot would leave multiple lines in the top review comment if, say, eslint found 30 issues, there would be 30 mentions of eslint having found issues. See https://github.com/facebook/react-native/pull/21492 for an example of such a case, where `analysis-bot` left a spammy review at https://github.com/facebook/react-native/pull/21492#pullrequestreview-161837975. Pull Request resolved: https://github.com/facebook/react-native/pull/21503 Differential Revision: D10219439 Pulled By: hramos fbshipit-source-id: 75d32ef3bfeaa91ab614763a19494659ad1be0dd	2018-10-05 11:33:38 -07:00
Héctor Ramos	b030fcbbf5	Update path to code analysis script (#21443) ... Summary: The script was moved after the original ShellCheck PR was opened, and this was lost during the rebase. Pull Request resolved: https://github.com/facebook/react-native/pull/21443 Differential Revision: D10133498 Pulled By: hramos fbshipit-source-id: da61b782362ab2d13cb6f0bca3fb1c9a0af08ae5	2018-10-01 15:22:35 -07:00
Héctor Ramos	53b487d215	Use ShellCheck (#19681) ... Summary: As recommended in https://circleci.com/docs/2.0/using-shell-scripts/#use-shellcheck It will only run on PRs for now. Pull Request resolved: https://github.com/facebook/react-native/pull/19681 Differential Revision: D10111711 Pulled By: hramos fbshipit-source-id: e980a526561dced79e5197a11cfb41a3eba9be8b	2018-09-28 17:03:24 -07:00