react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Samuel Susla	ffc90c7f92	Remove requestToken being nil check from [RCTNetworkTask validateRequestToken] Summary: Changelog: Fix [TypeError: Network request failed] on file upload # Problem In https://github.com/facebook/react-native/commit/31980094107ed37f8de70972dbcc319cc9a26339 I made method `loadImageForURL` blocking and nil returning since it was no longer cancellable. However inside `[RCTNetworkTask validateRequestToken]` was a logic counting on request token being non nil. This diff removes this check and adds `nullable` to `[RCTImageURLLoader loadImageForURL]` making it explicit. Reviewed By: PeteTheHeat Differential Revision: D22767174 fbshipit-source-id: 04d5562e381912233b9c14e8156cbf145288f063	2020-07-28 12:00:57 -07:00
Andres Suarez	3b31e69e28	Tidy up license headers [2/n] Summary: Changelog: [General] [Fixed] - License header cleanup Reviewed By: yungsters Differential Revision: D17952694 fbshipit-source-id: 17c87de7ebb271fa2ac8d00af72a4d1addef8bd0	2019-10-16 10:06:34 -07:00
Mehdi Mulani	2fbe956aac	Make NSData usage in RCTNetworkTask threadsafe Summary: @public We're seeing crashes from multiple threads trying to call `[NSData appendData:]` at the same time. Usually the RCTURLRequestHandlers implementation avoids this but if you're using a background queue, it is pretty easy to reach this case. Adding a lock to accessors of `_data` should prevent this. Reviewed By: shergin Differential Revision: D17552136 fbshipit-source-id: 3384d36221d0ada8cda638ad8e79e1bf3862f93f	2019-09-24 12:41:05 -07:00

Author

SHA1

Message

Date

Samuel Susla

ffc90c7f92

Remove requestToken being nil check from [RCTNetworkTask validateRequestToken]

Summary:
Changelog: Fix [TypeError: Network request failed] on file upload

# Problem
In https://github.com/facebook/react-native/commit/31980094107ed37f8de70972dbcc319cc9a26339 I made method `loadImageForURL` blocking and nil returning since it was no longer cancellable.

However inside `[RCTNetworkTask validateRequestToken]` was a logic counting on request token being non nil.
This diff removes this check and adds `nullable` to `[RCTImageURLLoader loadImageForURL]` making it explicit.

Reviewed By: PeteTheHeat

Differential Revision: D22767174

fbshipit-source-id: 04d5562e381912233b9c14e8156cbf145288f063

2020-07-28 12:00:57 -07:00

Andres Suarez

3b31e69e28

Tidy up license headers [2/n]

Summary: Changelog: [General] [Fixed] - License header cleanup

Reviewed By: yungsters

Differential Revision: D17952694

fbshipit-source-id: 17c87de7ebb271fa2ac8d00af72a4d1addef8bd0

2019-10-16 10:06:34 -07:00

Mehdi Mulani

2fbe956aac

Make NSData usage in RCTNetworkTask threadsafe

Summary:
@public
We're seeing crashes from multiple threads trying to call `[NSData appendData:]` at the same time. Usually the RCTURLRequestHandlers implementation avoids this but if you're using a background queue, it is pretty easy to reach this case.
Adding a lock to accessors of `_data` should prevent this.

Reviewed By: shergin

Differential Revision: D17552136

fbshipit-source-id: 3384d36221d0ada8cda638ad8e79e1bf3862f93f

2019-09-24 12:41:05 -07:00

3 Commits