Viraj-10
720cdbc658
feat: adding aria-label alias for accessibilityLabel ( #34502 )
...
Summary:
- Adding [aria-label](https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-label ) alias for [accessibilityLabel](https://reactnative.dev/docs/accessibility#accessibilitylabel )
https://github.com/facebook/react-native/issues/34424
## Changelog
[General] [Added] - Add `aria-label` prop to `Button`, `View`, `Pressable` component
Pull Request resolved: https://github.com/facebook/react-native/pull/34502
Test Plan:
```
<Button
onPress={() => onButtonPress('cancelled')}
testID="cancel_button"
color={theme.SystemRedColor}
title="Cancel Application"
aria-lable="Press to cancel your application!"
/>
```
Reviewed By: NickGerleman
Differential Revision: D39055178
Pulled By: cipolleschi
fbshipit-source-id: 7513a4518dedd0834e99fa8e72b07e0dc0132b41
2022-09-09 11:16:28 -07:00
Pieter Vanderwerff
ee3d3c248d
Add missing class annotations xplat/js
...
Reviewed By: SamChou19815
Differential Revision: D38373443
fbshipit-source-id: 1222c4845ebd6b72bd6f54af1a27cf8542dd883a
2022-08-03 12:43:58 -07:00
Eric Edouard
8993ffc82e
Added border curve style prop ("Squircle" effect - iOS only) ( #33783 )
...
Summary:
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
NOTE: PR is based on https://github.com/facebook/react-native/pull/32017 which went stale for quite a long time but can now safely be closed
Since iOS 13+, it is possible to change the corner curve property on iOS in order to smoothen border radius and make it more "rounded" (also called "squircle")
Here's an [article](https://medium.com/arthurofbabylon/a-smooth-corner-radius-in-ios-54b80aa2d372 ) explaining in details what it is.
This property is also built in figma, but currently there is no way to implement this directly with react-native despite it being available natively on iOS.
Many open source react-native libraries were created in order to simulate this behaviour:
[react-native-super-ellipse-mask](https://github.com/everdrone/react-native-super-ellipse-mask )
[react-native-squircle-view](https://github.com/everdrone/react-native-squircle-view )
[react-native-figma-squircle](https://github.com/tienphaw/react-native-figma-squircle )
But they rely on creating an SVG shape with the smoothed corners and masking the view behind. This makes it not very performant (flickering on mounting was a common side-effect)
This PR aims at implementing the property natively.
PR for the docs update: https://github.com/facebook/react-native-website/pull/2785
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[iOS] [Added] - Added `borderCurve` style prop for smooth border radius (squircle effect)
Pull Request resolved: https://github.com/facebook/react-native/pull/33783
Test Plan:
We used the RNTester app and added an example with `cornerCurve ` set to `'continuous'` (only on iOS).
As the difference is quite subtle, we also made some more tests to better illustrate the difference (these are not in the RN-tester app):
We overlapped two views with `position: absolute`, the one in the background has a red background and has `cornerRadius` set to `false`, and the one in the foreground is set to `true`. We can clearly see where the borders differs on the corners.
Reviewed By: sammy-SC
Differential Revision: D37883631
Pulled By: cipolleschi
fbshipit-source-id: 09f06de9628fa326323eba63875de30102c4a59e
2022-07-21 04:11:30 -07:00
Luna Wei
6958bbb28c
Fix up lint errors under react-native-github ( #33622 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/33622
Changelog: [Internal] Clean up eslint errors
Reviewed By: yungsters
Differential Revision: D35599445
fbshipit-source-id: bbb9061a3cf9df32daacad9a9b44eba94d3ce48c
2022-04-22 16:25:25 -07:00
Andres Suarez
8bd3edec88
Update copyright headers from Facebook to Meta
...
Reviewed By: aaronabramov
Differential Revision: D33367752
fbshipit-source-id: 4ce94d184485e5ee0a62cf67ad2d3ba16e285c8f
2021-12-30 15:11:21 -08:00
Tim Yung
77ecc7ede1
JS: Format with Prettier v2.4.1 [3/n]
...
Summary:
Changelog:
[General][Internal]
Reviewed By: zertosh
Differential Revision: D31883447
fbshipit-source-id: cbbf85e4bf935096d242336f41bf0cc5d6f92359
2021-11-02 22:14:16 -07:00
Valentin Shergin
e3d8a6b222
Fabric: Stacking Context test covering a sequence of changes
...
Summary:
This diff adds another complexity level for Stacking Context and zIndex tests: Now we test not only "noting-to-something" cases but also cases where we apply changes to an already non-empty tree, validating our assumption of each step.
Changelog: [Internal] Fabric-specific internal change.
Reviewed By: sammy-SC
Differential Revision: D25623176
fbshipit-source-id: 29a447d93522a2a4e7912351f907c46ac7b218bb
2020-12-21 08:33:31 -08:00
1270873ed6
RNTester UI Redesign ( #29685 )
...
Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.
This list is not exhaustive.
- The initial App screen is redesigned.
- A bottom Navbar has been added.
- Filter pills are added.
- The list card UI is updated.
- The example page UI is updated.
- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.
- Bookmarking functionality is added.
- The documentation URL is added to the example page.
- RNTester doesn't lose its state on a hard refresh (even on iOS).
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png " />
Pull Request resolved: https://github.com/facebook/react-native/pull/29685
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
{F302717939}
Note: this failed **before** this diff too:
{F302745716}
Reviewed By: mdvacca, cpojer
Differential Revision: D23240434
fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
Co-authored-by: agarwalmanya <manya18ag@gmail.com >
Co-authored-by: chirag-singhal <csinghal208@gmail.com >
Co-authored-by: Ansh Godha <ag759@cornell.edu >
Co-authored-by: Yash Kumar Verma <yk.verma2000@gmail.com >
Co-authored-by: Sanskar Jethi <sansyrox@gmail.com >
Co-authored-by: Aniketh Saha <anik220798@gmail.com >
Co-authored-by: Xtremilicious <nilarjundas@outlook.com >
Co-authored-by: Jani Evakallio <jani.evakallio@gmail.com >
2020-08-26 08:45:57 -07:00
stealthanthrax
63992c0b96
Migrating RNTester to Packages Directory ( #29567 )
...
Summary:
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
This PR aims to migrate the RNTester App to `packages` directory. But is currently, open to inspect the CI issues and resolve the merge conflicts.
Currently done
- Working on iOS
- Working on Android
- Detox Tests working on iOS
Need to work on
- Errors generated by the CI builds
[General] [Changed] - Migrated the RNTester App to the packages directory.
Pull Request resolved: https://github.com/facebook/react-native/pull/29567
Test Plan: It runs on both ios and android for now and the detox iOS builds are working.
Reviewed By: cpojer
Differential Revision: D23034761
Pulled By: rickhanlonii
fbshipit-source-id: e04bb06e1c7ef15d340206090d1575a871b9e6f5
2020-08-19 17:57:08 -07:00
Viraj-10
Pieter Vanderwerff
Eric Edouard
Luna Wei
Andres Suarez
Tim Yung
Valentin Shergin
