20 Commits

Author	SHA1	Message	Date
evanbacon	5933b6a3ba	Use monospace font for RCTRedBox.mm message (#34780) ... Summary: The format is crunching spaces:  Now it preserves the space and makes the error look a little less scary:  ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [iOS] [Fixed] - RedBox title font by using a monospace font on iOS +13. Pull Request resolved: https://github.com/facebook/react-native/pull/34780 Test Plan: See pictures. You can repro by applying changes and starting a project with a misc `>` character. The first load triggers the error message. Reviewed By: cipolleschi Differential Revision: D39798262 Pulled By: robhogan fbshipit-source-id: d836e50f3e95865a6482accf4aea5b0e6cf24995	2022-09-27 04:51:52 -07:00
Richard Howell	f22d4348dc	add casts for implicit int to float ... Summary: Apply //fbobjc/Tools/cAST:implicit_conversion to existing warnings Reviewed By: matrush Differential Revision: D35787050 fbshipit-source-id: 45f06227e44203cbedf1d10978e1992399a0d06b	2022-04-20 16:29:02 -07:00
Richard Howell	7d4f6840f6	add casts for implicit int to float ... Summary: Apply //fbobjc/Tools/cAST:implicit_conversion to existing warnings Reviewed By: adamjernst Differential Revision: D35692786 fbshipit-source-id: 13fb4f8a6b6e701c324b00c682943a4b3d80de72	2022-04-18 11:51:50 -07:00
Andres Suarez	8bd3edec88	Update copyright headers from Facebook to Meta ... Reviewed By: aaronabramov Differential Revision: D33367752 fbshipit-source-id: 4ce94d184485e5ee0a62cf67ad2d3ba16e285c8f	2021-12-30 15:11:21 -08:00
CodemodService FBSourceClangFormatLinterBot	725bffce51	Daily arc lint --take CLANGFORMAT ... Reviewed By: zertosh Differential Revision: D33316567 fbshipit-source-id: cfeb96eb2adc7539b97d3a8f0de6710cd5f6ce5b	2021-12-25 08:28:35 -08:00
Richard Howell	e60f0f5034	cast implicit int to CGFloat conversions [3/3] ... Summary: Insert casts for implicit int -> CGFloat conversions. This warning category is generally benign and explicitly casting will preserve existing behavior. Reviewed By: NSProgrammer Differential Revision: D33303887 fbshipit-source-id: b21adbcf754e707adfe3f8eaa0fe9c3a65380cc5	2021-12-24 09:19:42 -08:00
Ken Tominaga	398595e074	Remove iOS 11 version check (#32151) ... Summary: This pull request aims to remove iOS 11 version check which is no longer needed. The minimum iOS deployment target for React Native is `iOS 11` but we still have iOS 11 version check like below. ``` #if __IPHONE_OS_VERSION_MAX_ALLOWED >= 110000 /* __IPHONE_11_0 */ if (available(iOS 11.0, *)) { ``` > React Native apps may target iOS 11.0 and Android 5.0 (API 21) or newer. ref: https://github.com/facebook/react-native#-requirements ------ If there is a team motivation to remove the deprecated methods and classes before iOS 10, I can continue the work in this pull request or in the continuing pull requests. We have deprecated warnings for these in the project. - `UIUserNotificationSettings` - `UILocalNotification` - `topLayoutGuide` and `bottomLayoutGuide` - `automaticallyAdjustsScrollViewInsets` ## Changelog [iOS] [Changed] - Remove iOS 11 version check Pull Request resolved: https://github.com/facebook/react-native/pull/32151 Reviewed By: sammy-SC Differential Revision: D30877917 Pulled By: yungsters fbshipit-source-id: d903ea5d557beeb65ef87bfce572e4db3532b3c5	2021-09-22 10:37:09 -07:00
Ramanpreet Nara	1f105e6f16	Migrate RedBox to RCTBundleManager ... Summary: See title. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D28192003 fbshipit-source-id: a1a21782b51f327b9b92c60c7e9bd7251fcdebf0	2021-05-04 18:33:23 -07:00
Samuel Susla	2b27323308	Remove unnecessary access to UIKit on main thread in [RCTRedBox dealloc] ... Summary: Changelog: Fix main thread access to UIKit in RCTRedBox {F611784226} Xcode's main thread checker complains about this during reload. it is not needed to set `dataSource` and `delegate` to nil because the table view is about to be destroyed. Reviewed By: mdvacca Differential Revision: D28089039 fbshipit-source-id: 13b62cafb4790fc15b5a5dde131d4ae64bd97c82	2021-04-30 10:46:35 -07:00
Ramanpreet Nara	74fd6fb1da	Codemod: Migrate from bridge.eventDispatcher to RCTModuleRegistry ... Summary: All NativeModules that use the bridge to require the eventDispatcher are now instead using the RCTModuleRegistry I introduced in D25412847 (https://github.com/facebook/react-native/commit/0ed81b28d3d786ea3b1cf0b932a008ef1f806ec4). ## What does this codemod do? For all ObjC files that contain `synthesize bridge = _bridge`, migrate calls that access the React Native bridge from `self`, and use it to load the event dispatcher. **Thoughts on Codemod Safety:** If we can access the bridge from self, then that means that if we synthesize the module registry, we can access the module registry from self. Therefore, this codemod is safe. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D25449795 fbshipit-source-id: 2f7235d14659e73d673ae08763dc2cccdde55a19	2020-12-11 10:42:28 -08:00
Lulu Wu	ea93151f21	Make RCTEventDispatcher TurboModule-compatible ... Summary: This diff ended up being a bit more complicated than I anticipated, since the source files in `ReactInternal` were depending on `RCTEventDispatcher`. I made the following changes: 1. Make `RCTEventDispatcher` a `protocol`, keep it in `ReactInternal`. 2. Rename the `RCTEventDispatcher` NativeModule to `RCTEventDispatcherModule`, make it conform to the `RCTEventEmitter` `protocol`, and move it to `CoreModules`. 3. Where necessary, replace categories of `RCTEventDispatcher` with functions. Changelog: [iOS][Added] - Make RCTEventDispatcher TurboModule-comaptible Reviewed By: fkgozali Differential Revision: D18439488 fbshipit-source-id: b3da15c29459fddf884519f33b0c3b8c036b5539	2020-10-14 02:40:10 -07:00
simek	2160377574	remove most of tvOS remnants from the code (#29407) ... Summary: Refs: [0.62 release](https://reactnative.dev/blog/#moving-apple-tv-to-react-native-tvos), https://github.com/facebook/react-native/issues/28706, https://github.com/facebook/react-native/issues/28743, https://github.com/facebook/react-native/issues/29018 This PR removes most of the tvOS remnants in the code. Most of the changes are related to the tvOS platform removal from `.podspec` files, tvOS specific conditionals removal (Obj-C + JS) or tvOS CI/testing pipeline related code. In addition to the changes listed above I have removed the deprecated `Platform.isTVOS` method. I'm not sure how `Platform.isTV` method is correlated with Android TV devices support which is technically not deprecated in the core so I left this method untouched for now. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> * **[Internal] [Removed]** - remove most of tvOS remnants from the code: * `TVEventHandler`, `TVTouchable`, `RCTTVView`, `RCTTVRemoteHandler` and `RCTTVNavigationEventEmitter` * **[Internal] [Removed]** - remove `TARGET_TV_OS` flag and all the usages * **[iOS] [Removed]** - remove deprecated `Platform.isTVOS` method * **[iOS] [Removed]** - remove deprecated and TV related props from View: * `isTVSelectable`, `hasTVPreferredFocus` and `tvParallaxProperties` * **[iOS] [Removed]** - remove `BackHandler` utility implementation Pull Request resolved: https://github.com/facebook/react-native/pull/29407 Test Plan: Local tests (and iOS CI run) do not yield any errors, but I'm not sure how the CI pipeline would react to those changes. That is the reason why this PR is being posted as Draft. Some tweaks and code adjustment could be required. Reviewed By: PeteTheHeat Differential Revision: D22619441 Pulled By: shergin fbshipit-source-id: 9aaf3840c5e8bd469c2cfcfa7c5b441ef71b30b6	2020-09-28 21:26:41 -07:00
Ramanpreet Nara	03bd7d799e	Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams ... Summary: ## Summary Please check out D21035209. ## Changes - Codemod all ObjC NativeModule `getTurboModuleWithJsInvoker:nativeInvoker:perfLogger` methods to `getTurboModule:(const ObjCTurboModule::Args)` ## Script ``` var withSpaces = (...args) => args.join('\s*') var regexString = withSpaces( '-', '\(', 'std::shared_ptr', '<', '(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)', '>', '\)', 'getTurboModuleWithJsInvoker', ':', '\(', 'std::shared_ptr', '<', '(?<fbNamespace>(facebook::react::|react::|::|))CallInvoker', '>', '\)', '(?<jsInvokerInstance>[A-Za-z0-9]+)', 'nativeInvoker', ':', '\(', 'std::shared_ptr', '<', '(facebook::react::|react::|::|)CallInvoker', '>', '\)', '(?<nativeInvokerInstance>[A-Za-z0-9]+)', 'perfLogger', ':', '\(', 'id', '<', 'RCTTurboModulePerformanceLogger', '>', '\)', '(?<perfLoggerInstance>[A-Za-z0-9]+)', '{', 'return', 'std::make_shared', '<', '(?<specName>(facebook::react::|react::|::|)Native[%A-Za-z0-9]+SpecJSI)', '>', '\(', 'self', ',', '\k<jsInvokerInstance>', ',', '\k<nativeInvokerInstance>', ',', '\k<perfLoggerInstance>', '\)', ';', '}', ) var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModule:(const $<fbNamespace>ObjCTurboModule::InitParams &)params { return std::make_shared<$<specName>>(params); }` const exec = require('../lib/exec'); const abspath = require('../lib/abspath'); const relpath = require('../lib/relpath'); const readFile = (filename) => require('fs').readFileSync(filename, 'utf8'); const writeFile = (filename, content) => require('fs').writeFileSync(filename, content); function main() { const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean); tmFiles .filter((filename) => !filename.includes('microsoft-fork-of-react-native')) .map(abspath) .forEach((filename) => { const source = readFile(filename); const newSource = source.replace(new RegExp(regexString, 'g'), replaceString); if (source == newSource) { console.log(relpath(filename)); } writeFile(filename, newSource); }); } if (!module.parent) { main(); } ``` ## Re-generating diff ``` > hg revert -r .^ --all > node index.js # run script ``` Changelog: [iOS][Changed] - Make all ObjC NativeModules create TurboModules using ObjCTurboModule::Args Reviewed By: PeteTheHeat Differential Revision: D21036265 fbshipit-source-id: 404bcc548d1775ef23d793527606d02fe384a0a2	2020-04-16 17:29:55 -07:00
Samuel Susla	46c77dc296	Fix crash inside RCTRedBox when trying to present same UIViewController twice ... Summary: Calling `-[RCTRedBox showErrorMessage]` twice causes a crash We used `-[UIViewController isBeingPresented]` to tell whether view controller is already presented. But from the documentation: > A Boolean value indicating whether the view controller is being presented. Source: https://developer.apple.com/documentation/uikit/uiviewcontroller/2097564-beingpresented?language=objc# --- So this means that if you present it, wait until presentation animation is finished and then call `-[RCTRedBox showErrorMessage]` again, following exception will be thrown. ``` *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Application tried to present modally an active controller <UIViewController: 0x7fc33e422f50>.' ``` Changelog: Fix crash caused by presenting view controller twice from RCTRedBox Reviewed By: PeteTheHeat Differential Revision: D20946645 fbshipit-source-id: 763066e37db4e56efb0118b2e7867ad0724bae81	2020-04-10 13:51:56 -07:00
Ramanpreet Nara	69698b25fc	Codemod all getTurboModuleWithJsInvoker methods to accept a native CallInvoker ... Summary: To make iOS TurboModules integrate with the bridge's onBatchComplete event, they need to use a native CallInvoker. This call invoker is created by the `NativeToJsBridge`, and ObjCTurboModule will use this native CallInvoker to dispatch TurboModule method calls. This diff makes sure that ObjCTurboModules are created with that native CallInvoker. ## Script ``` var withSpaces = (...args) => args.join('\s*') var regexString = withSpaces( '-', '\(', 'std::shared_ptr', '<', '(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)', '>', '\)', 'getTurboModuleWithJsInvoker', ':', '\(', 'std::shared_ptr', '<', '(?<callInvokerClass>(facebook::react::|react::|::|)CallInvoker)', '>', '\)', '(?<jsInvokerInstance>[A-Za-z0-9]+)', 'perfLogger', ':', '\(', 'id', '<', 'RCTTurboModulePerformanceLogger', '>', '\)', '(?<perfLoggerInstance>[A-Za-z0-9]+)', '{', 'return', 'std::make_shared', '<', '(?<specName>(facebook::react::|react::|::|)Native[%A-Za-z0-9]+SpecJSI)', '>', '\(', 'self', ',', '\k<jsInvokerInstance>', ',', '\k<perfLoggerInstance>', '\)', ';', '}', ) var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModuleWithJsInvoker:(std::shared_ptr<$<callInvokerClass>>)$<jsInvokerInstance> nativeInvoker:(std::shared_ptr<$<callInvokerClass>>)nativeInvoker perfLogger:(id<RCTTurboModulePerformanceLogger>)$<perfLoggerInstance> { return std::make_shared<$<specName>>(self, $<jsInvokerInstance>, nativeInvoker, $<perfLoggerInstance>); }` const exec = require('../lib/exec'); const abspath = require('../lib/abspath'); const relpath = require('../lib/relpath'); const readFile = (filename) => require('fs').readFileSync(filename, 'utf8'); const writeFile = (filename, content) => require('fs').writeFileSync(filename, content); function main() { const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean); tmFiles .filter((filename) => !filename.includes('microsoft-fork-of-react-native')) .map(abspath) .forEach((filename) => { const source = readFile(filename); const newSource = source.replace(new RegExp(regexString, 'g'), replaceString); if (source == newSource) { console.log(relpath(filename)); } writeFile(filename, newSource); }); } if (!module.parent) { main(); } ``` Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D20809202 fbshipit-source-id: 5d39b3cacdaa5681b70ce1803351d0432dd74550	2020-04-03 02:27:10 -07:00
Ramanpreet Nara	652fa1b8d4	Add a perfLogger argument to getTurboModuleWithJSInvoker: ... Summary: ## Purpose We must modify the `getTurboModuleWithJsInvoker:` method of all our NativeModules to also accept a `id<RCTTurboModulePerformanceLogger>` object. This performance logger object should then be forwarded to the `Native*SpecJSI` constructor. ## Script Run the following script via Node: ``` var withSpaces = (...args) => args.join('\s*') var regexString = withSpaces( '-', '\(', 'std::shared_ptr', '<', '(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)', '>', '\)', 'getTurboModuleWithJsInvoker', ':', '\(', 'std::shared_ptr', '<', '(?<callInvokerClass>(facebook::react::|react::|::|)CallInvoker)', '>', '\)', 'jsInvoker', '{', 'return', 'std::make_shared', '<', '(?<specName>(facebook::react::|react::|::|)Native[A-Za-z0-9]+SpecJSI)', '>', '\(', '(?<arg1>[A-Za-z0-9]+)', ',', '(?<arg2>[A-Za-z0-9]+)', '\)', ';', '}', ) var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModuleWithJsInvoker:(std::shared_ptr<$<callInvokerClass>>)jsInvoker perfLogger:(id<RCTTurboModulePerformanceLogger>)perfLogger { return std::make_shared<$<specName>>($<arg1>, $<arg2>, perfLogger); }` const exec = (cmd) => require('child_process').execSync(cmd, { encoding: 'utf8' }); const abspath = (filename) => `${process.env.HOME}/${filename}`; const relpath = (filename) => filename.replace(process.env.HOME + '/', ''); const readFile = (filename) => require('fs').readFileSync(filename, 'utf8'); const writeFile = (filename, content) => require('fs').writeFileSync(filename, content); function main() { const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean); tmFiles .filter((filename) => !filename.includes('microsoft-fork-of-react-native')) .map(abspath) .forEach((filename) => { const source = readFile(filename); const newSource = source.replace(new RegExp(regexString, 'g'), replaceString); if (source == newSource) { console.log(relpath(filename)); } writeFile(filename, newSource); }); } if (!module.parent) { main(); } ``` Also, run: `pushd ~/fbsource && js1 build oss-native-modules-specs -p ios && js1 build oss-native-modules-specs -p android && popd;` Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D20478718 fbshipit-source-id: 89ee27ed8a0338a66a9b2dbb716168a4c4582c44	2020-03-18 11:01:15 -07:00
Valentin Shergin	d0871d0a9a	Clang format for all React Native files ... Summary: Buckle up, this enables clang-format prettifier for all files in React Native opensource repo. Changelog: [Internal] Clang-format codemod. Reviewed By: mdvacca Differential Revision: D20331210 fbshipit-source-id: 8da0f94700be0c35bfd399e0c48f1706de04f5b1	2020-03-08 23:01:17 -07:00
Tommy Nguyen	d0a32c2011	iOS: Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox (#28147) ... Summary: `RCTRedBox` doesn't appear in apps implementing `UISceneDelegate`. ## Changelog [iOS] [Changed] - `RCTKeyWindow()` is now multi-window aware [iOS] [Fixed] - `RCTRedBox` doesn't appear in apps implementing `UISceneDelegate` Pull Request resolved: https://github.com/facebook/react-native/pull/28147 Test Plan: - Trigger an error in RNTester - Trigger an error in an app implementing `UISceneDelegate`  Reviewed By: PeteTheHeat Differential Revision: D20036399 Pulled By: hramos fbshipit-source-id: 07d83e985b02296f930114e3c7100c2077e82300	2020-02-26 19:55:14 -08:00
Nicolas Charpentier	56dfc86d64	Enable dev keyboard shortcuts on Mac Catalyst (#27479) ... Summary: This enables the dev menu to bo opened from keyboard shortcuts in dev from a Mac Catalyst app. cc TheSavior andymatuschak radex ## Changelog [iOS] [Fixed] - Enable dev keyboard shortcuts on Mac Catalyst Pull Request resolved: https://github.com/facebook/react-native/pull/27479 Test Plan: It depends on https://github.com/facebook/react-native/issues/27469 (to have working WebSocket in debug).  Differential Revision: D19576528 Pulled By: shergin fbshipit-source-id: 32b4f8424fb7d270640af4bc50dba24f488bef4f	2020-01-26 19:57:18 -08:00
Ramanpreet Nara	7e5de4e241	Make RedBox TurboModule-compatible ... Summary: See title. Changelog: [iOS][Added] - Make RedBox TurboModule-compatible Reviewed By: PeteTheHeat Differential Revision: D18142255 fbshipit-source-id: 2d130aca93a88ac7c983ce0e4848955ffb0be518	2019-11-04 16:07:23 -08:00