Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
17,145 Commits 541 Branches 635 Tags
6fef48096d4e33820763fc3f7fa773c18fd8db04
Commit Graph

8 Commits

Author SHA1 Message Date
Rick Hanlon 942de57182 Add fix for react-native-gesture-handler 
Summary: This diff fixes an issue with generated view configs due to react-native-gesture-handler adding events to view which are not in the view  config on javascript. These will need removed later when react-native-gesture-handler is updated for the new system

Reviewed By: fkgozali

Differential Revision: D15813596

fbshipit-source-id: 8914c093d9cb03e320406d154bb88abf557a951e
 2019-06-13 15:32:02 -07:00
Emily Janzer d83ba5ad51 Revert D15488008: Use JS ViewConfig for View 
Differential Revision:
D15488008

Original commit changeset: 48e925ec0ca2

fbshipit-source-id: 4ffa223e636116777c178386b6e966a4f253c30a
 2019-05-28 16:37:46 -07:00
Emily Janzer 77a6617a39 Use JS ViewConfig for View 
Summary: Rick manually created view config in JS for View; adding some missing attributes/events and using this instead of `requireNativeComponent`

Reviewed By: rickhanlonii

Differential Revision: D15488008

fbshipit-source-id: 48e925ec0ca2aeba9e6cc66edef0b70ee1c94d27
 2019-05-28 10:22:43 -07:00
Marc Mulcahy 099be9b356 New Accessibility states API. (#24608) 
Summary:
As currently defined, accessibilityStates is an array of strings, which represents the state of an object. The array of strings notion doesn't well encapsulate how various states are related, nor enforce any level of correctness.

This PR converts accessibilityStates to an object with a specific definition. So, rather than:

<View
...
accessibilityStates={['unchecked']}>

We have:

<View
accessibilityStates={{'checked': false}}>

And specifically define the checked state to either take a boolean or the "mixed" string (to represent mixed checkboxes).

We feel this API is easier to understand an implement, and provides better semantic definition of the states themselves, and how states are related to one another.

## Changelog

[general] [change] - Convert accessibilityStates to an object instead of an array of strings.
Pull Request resolved: https://github.com/facebook/react-native/pull/24608

Differential Revision: D15467980

Pulled By: cpojer

fbshipit-source-id: f0414c0ef6add3f10f7f551d323d82d978754278
 2019-05-23 05:37:33 -07:00
James Ide a7a7970e54 Replace more Haste imports with path-based imports (#25001) 
Summary:
This is another step in moving RN towards standard path-based requires, updating more code to use path-based requires. See the umbrella issue at https://github.com/facebook/react-native/issues/24316 for more detail.

## Changelog

[General] [Changed] - Replace more Haste imports with path-based imports
Pull Request resolved: https://github.com/facebook/react-native/pull/25001

Differential Revision: D15467829

Pulled By: cpojer

fbshipit-source-id: 58c364bb4c1c757689907d5ed0d0f3fac0e22f3f
 2019-05-23 00:51:31 -07:00
Rick Hanlon 531f11f084 Fix flow and formatting 
Summary: Fixes a flow failure in the generated output and adds trailing commas to pass linting

Reviewed By: yungsters

Differential Revision: D15354725

fbshipit-source-id: 1eac27fa753af595a9a2787426b147e5f49a4e1d
 2019-05-20 02:52:37 -07:00
Rick Hanlon 5a905a5e16 Add android specific view config props 
Summary: This diff adds the android specific View view config props that I missed in an earlier diff in this stack

Reviewed By: cpojer

Differential Revision: D15336076

fbshipit-source-id: 6d20462b2682e3ea80b0ffc95ef35aa7618d4cf2
 2019-05-16 10:51:07 -07:00
Rick Hanlon 1aca74586f Update view configs handle view props/events 
Summary:
This diff adds support for spreading view props into the generated viewconfig (currently hardcoded the view viewconfig but soon that will also be generated)

Results in a generated view config such as:

```
const ReactNativeViewConfig = require('ReactNativeViewConfig');
const ReactNativeViewConfigRegistry = require('ReactNativeViewConfigRegistry');

const BooleanPropNativeComponentViewConfig = {
  uiViewClassName: 'BooleanPropNativeComponent',
  Commands: {},

  bubblingEventTypes: {
    ...ReactNativeViewConfig.bubblingEventTypes
  },

  directEventTypes: {
    ...ReactNativeViewConfig.directEventTypes
  },

  validAttributes: {
    ...ReactNativeViewConfig.validAttributes,
    disabled: true
  }
};

ReactNativeViewConfigRegistry.register(
  'BooleanPropNativeComponent',
  () => BooleanPropNativeComponentViewConfig,
);

module.exports = 'BooleanPropNativeComponent';
```

Reviewed By: TheSavior

Differential Revision: D15258778

fbshipit-source-id: 2c70d20dc366f32a8114d42e0e15b5f1e359d11f
 2019-05-16 10:51:06 -07:00