react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Olga Zinoveva	ad4a857d3a	Fix occasional failures of triage-issue job (#36846 ) Summary: I added a new step to the triage-issue job last week, to add descriptive labels to issues based on their title. This job has occasionally be failing, [like this](https://github.com/facebook/react-native/actions/runs/4630279135/jobs/8191646900). This happens when no applicable labels are found, and we send up an empty array to the add labels endpoint. Adding an array length check to protect against this case. ## Changelog: [INTERNAL] [FIXED] - Fixed occasional failures in the issue triage pipeline related to issue labeling Pull Request resolved: https://github.com/facebook/react-native/pull/36846 Test Plan: Repro run in my repository before the fix: https://github.com/SlyCaptainFlint/react-native/actions/runs/4631843716 (note that the error is the same as in the example failure listed in the description) And here is a success on the same issue after the fix: https://github.com/SlyCaptainFlint/react-native/actions/runs/4631920441 Reviewed By: cipolleschi Differential Revision: D44866639 Pulled By: cortinico fbshipit-source-id: ace6ebece46d7a160f8be39a6099121e11201318	2023-04-11 11:33:10 -07:00
Olga Zinoveva	d038e4e3bf	Add github workflow for automatic API, topic, and component labeling of issues (#36712 ) Summary: Adding a new github workflow script, which will run as part of the existing triage job that is triggered when an issue is labeled with the "Needs: Triage" label (this typically happens automatically when the issue is created). This script will add an extensive list of possible labels corresponding to APIs, components, and topics (see the code for the full list). The motivation for this change is to replace the last bit of meaningful functionality performed by react-native-bot, which will allow us to decommission that bot in favor of using github workflows for all issue and PR automation. ## Changelog: [INTERNAL] [CHANGED] - Updated API, topic, component labeling on issues to run from a GH workflow rather than an external bot action Pull Request resolved: https://github.com/facebook/react-native/pull/36712 Test Plan: For examples of issues being labeled by this new script, see the open issues here: https://github.com/SlyCaptainFlint/react-native/issues I did not test every possible label, but I tested at least one from each category (API, component, topic), and a combination of one or two of each. Reviewed By: cortinico, cipolleschi Differential Revision: D44593658 Pulled By: SlyCaptainFlint fbshipit-source-id: 93758d05a70d02bed76ab0b6149271e757e0a12f	2023-04-04 15:49:01 -07:00

Author

SHA1

Message

Date

Olga Zinoveva

ad4a857d3a

Fix occasional failures of triage-issue job (#36846 )

Summary:
I added a new step to the triage-issue job last week, to add descriptive labels to issues based on their title. This job has occasionally be failing, [like this](https://github.com/facebook/react-native/actions/runs/4630279135/jobs/8191646900). This happens when no applicable labels are found, and we send up an empty array to the add labels endpoint. Adding an array length check to protect against this case.

## Changelog:
[INTERNAL] [FIXED] - Fixed occasional failures in the issue triage pipeline related to issue labeling

Pull Request resolved: https://github.com/facebook/react-native/pull/36846

Test Plan:
Repro run in my repository before the fix: https://github.com/SlyCaptainFlint/react-native/actions/runs/4631843716 (note that the error is the same as in the example failure listed in the description)
And here is a success on the same issue after the fix: https://github.com/SlyCaptainFlint/react-native/actions/runs/4631920441

Reviewed By: cipolleschi

Differential Revision: D44866639

Pulled By: cortinico

fbshipit-source-id: ace6ebece46d7a160f8be39a6099121e11201318

2023-04-11 11:33:10 -07:00

Olga Zinoveva

d038e4e3bf

Add github workflow for automatic API, topic, and component labeling of issues (#36712 )

Summary:
Adding a new github workflow script, which will run as part of the existing triage job that is triggered when an issue is  labeled with the "Needs: Triage" label (this typically happens automatically when the issue is created).
This script will add an extensive list of possible labels corresponding to APIs, components, and topics (see the code for the full list).
The motivation for this change is to replace the last bit of meaningful functionality performed by react-native-bot, which will allow us to decommission that bot in favor of using github workflows for all issue and PR automation.

## Changelog:

[INTERNAL] [CHANGED] - Updated API, topic, component labeling on issues to run from a GH workflow rather than an external bot action

Pull Request resolved: https://github.com/facebook/react-native/pull/36712

Test Plan:
For examples of issues being labeled by this new script, see the open issues here: https://github.com/SlyCaptainFlint/react-native/issues
I did not test every possible label, but I tested at least one from each category (API, component, topic), and a combination of one or two of each.

Reviewed By: cortinico, cipolleschi

Differential Revision: D44593658

Pulled By: SlyCaptainFlint

fbshipit-source-id: 93758d05a70d02bed76ab0b6149271e757e0a12f

2023-04-04 15:49:01 -07:00

2 Commits