Commit Graph

6 Commits

Author SHA1 Message Date
Samuel Susla 83e5cdd369 Fix accessibility when entire text node is a link
Summary:
Changelog: [internal]

Fix accessibility when entire text node is a link

Reviewed By: JoshuaGross

Differential Revision: D28325749

fbshipit-source-id: 9ac68b802f13d028b5cdb6cae7bdae5f4924fc07
2021-05-11 01:23:04 -07:00
Valentin Shergin 75a678ddb2 Fabric: RCTParagraphComponentView now respects the accessible property
Summary:
In RN, a <Text> node can be marked "not-accessible" by specifying `accessible=false`. This diff implements this for Fabric.

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: sammy-SC

Differential Revision: D24386225

fbshipit-source-id: 576f4cbe1916e90034f8c9f06f19cea1992e7abd
2021-01-25 21:11:44 -08:00
Samuel Susla 5333ad8a61 Add unit tests for RCTComponentViewRegistry
Summary:
Changelog: [internal]

Adds unit tests for `RCTComponentViewRegistry`.

Reviewed By: shergin

Differential Revision: D24391419

fbshipit-source-id: e8adb641361c3e1394f652a1819f196d2402f493
2020-10-21 10:49:43 -07:00
Jiayan Zhuang 3c52942506 Write tests to cover additional features in RCTParagraphComponentView
Summary:
Changelog:
[Internal] - Add additional tests to cover other features in RCTParagraphComponentView.

I mainly test the correctness of attributedString and fragments in the RCTParagraphComponentView.

Reviewed By: shergin

Differential Revision: D22668022

fbshipit-source-id: 6879eb6b6a6ace9e6e05f1486d4e4034ebfd73bc
2020-07-27 16:05:53 -07:00
Jiayan Zhuang 894b3aa389 Build the basic RCTParagraphComponentViewTests
Summary:
Changelog:
[Internal] - Build the basic RCTParagraphComponentViewTests. Add the content of tests.
I mainly test the cases of text with multiple links inside, text with link which crosses multiple lines and truncated text with link.

Reviewed By: shergin

Differential Revision: D22607097

fbshipit-source-id: c98b8d4c5424a3e51e2869f50bc5038f969e45e8
2020-07-27 15:37:31 -07:00
Jiayan Zhuang c03a6aba49 Setup the ShadowNode tree for RCTParagraphComponentViewTests (#29470)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/29470

Changelog:
[Internal] - Build the framework of the RCTParagraphComponentViewTests and do some setup.

I built a shadowNode tree here for future tests.

Reviewed By: shergin

Differential Revision: D22536626

fbshipit-source-id: c74b63b3319693b90c9d64b7f782a1a922b0d499
2020-07-27 15:37:31 -07:00