2c7a907b08
Update integration snapshots ( #27059 )
...
Summary:
This commit https://github.com/facebook/react-native/commit/a397d330a4cf7e08095faa0e751e38d5106ed5c7 changes colors in the RNTester slightly and makes snapshots to fail.
I have re-generated them and made sure it was just the background color (and few other minor gray shades) that were different.
I haven't spotted any other visual changes.
Pull Request resolved: https://github.com/facebook/react-native/pull/27059
Differential Revision: D18223898
Pulled By: cpojer
fbshipit-source-id: ccc269bba0023233bc27254bd1a6bc0fb09a390a
2019-10-30 11:04:53 -07:00
17ca80a9c5
Fixed test_ios Switch test failed ( #24009 )
...
Summary:
In #23977 , it changed switch example, it leads snapshots test failed.
cc hramos .
[iOS] [Fixed] - Fixed test_ios Switch test failed
Pull Request resolved: https://github.com/facebook/react-native/pull/24009
Differential Revision: D14504806
Pulled By: cpojer
fbshipit-source-id: 0c47226a3da0cba2371c627f42f62835b3aac810
2019-03-18 10:24:25 -07:00
7a7eb11965
Fix textAttributes not applied when typing text ( #23585 )
...
Summary:
Currently, if we has `defaultValue`, textAttributes like `letterSpacing` can works, but if textinput has not default text, when we typing the text, some attributes not applied.
[iOS] [Fixed] - Fix textAttributes not applied when typing text
Pull Request resolved: https://github.com/facebook/react-native/pull/23585
Differential Revision: D14206568
Pulled By: cpojer
fbshipit-source-id: 7db276d811684bf6e01f8d30287cca80095db87c
2019-02-24 23:37:41 -08:00
38e91e6a9d
fix getPhotos params on RNTester XHR example. ( #23548 )
...
Summary:
Fixes redscreen on RNTester's XHR page. CameraRoll getPhotos was missing params.
ss: https://i.imgur.com/JLThyrF.png
[iOS] [Fixed] - RNTester XHR Example crash
Pull Request resolved: https://github.com/facebook/react-native/pull/23548
Differential Revision: D14151304
Pulled By: hramos
fbshipit-source-id: 7ff02c7fe32f09aecd50bc7df9f37b7cd2851b1c
2019-02-20 09:57:26 -08:00
eb414b7f8d
Update iOS Snapshots ( #23538 )
...
Summary:
The iOS snapshots needed to be updated after https://github.com/facebook/react-native/commit/cf5f25472df644b65820115986f9eec8306bd1fd updated `ViewExample.js`.
[iOS] [Fixed] - Updated snapshots on iOS.
Pull Request resolved: https://github.com/facebook/react-native/pull/23538
Differential Revision: D14146723
Pulled By: cpojer
fbshipit-source-id: f949d4c7925ab53ef42f42689bc2ed7b254dea48
2019-02-19 22:07:32 -08:00
27617be9bb
RNTesterSnapshotTests update ios snapshot images due to layout changes ( #23152 )
...
Summary:
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change:
Changelog:
----------
Currently ci in master fail for `test_ios`. Due to tests in `RNTesterSnapshotTests`. (Related to https://github.com/facebook/react-native/issues/23108 )
Root cause is layout in RNTest was changed and snapshot is not updated to reflect changes. https://user-images.githubusercontent.com/4032276/51730680-06609480-20ab-11e9-88cb-d4113e2819f2.png
Reference: https://circleci.com/gh/facebook/react-native/68285?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
[iOS] [Fixed] - Fix test ios in ci
Pull Request resolved: https://github.com/facebook/react-native/pull/23152
Differential Revision: D13817049
Pulled By: cpojer
fbshipit-source-id: 7df8b6744ae91cf9be0ef9eee476c8f1565ae1f6
2019-01-25 05:25:39 -08:00
Mike Grabowski
zhongwuzw
Eric Lewis
Héctor Ramos
Woraphot Chokratanasombat
