8 Commits

Author	SHA1	Message	Date
Ramanpreet Nara	03bd7d799e	Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams ... Summary: ## Summary Please check out D21035209. ## Changes - Codemod all ObjC NativeModule `getTurboModuleWithJsInvoker:nativeInvoker:perfLogger` methods to `getTurboModule:(const ObjCTurboModule::Args)` ## Script ``` var withSpaces = (...args) => args.join('\s*') var regexString = withSpaces( '-', '\(', 'std::shared_ptr', '<', '(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)', '>', '\)', 'getTurboModuleWithJsInvoker', ':', '\(', 'std::shared_ptr', '<', '(?<fbNamespace>(facebook::react::|react::|::|))CallInvoker', '>', '\)', '(?<jsInvokerInstance>[A-Za-z0-9]+)', 'nativeInvoker', ':', '\(', 'std::shared_ptr', '<', '(facebook::react::|react::|::|)CallInvoker', '>', '\)', '(?<nativeInvokerInstance>[A-Za-z0-9]+)', 'perfLogger', ':', '\(', 'id', '<', 'RCTTurboModulePerformanceLogger', '>', '\)', '(?<perfLoggerInstance>[A-Za-z0-9]+)', '{', 'return', 'std::make_shared', '<', '(?<specName>(facebook::react::|react::|::|)Native[%A-Za-z0-9]+SpecJSI)', '>', '\(', 'self', ',', '\k<jsInvokerInstance>', ',', '\k<nativeInvokerInstance>', ',', '\k<perfLoggerInstance>', '\)', ';', '}', ) var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModule:(const $<fbNamespace>ObjCTurboModule::InitParams &)params { return std::make_shared<$<specName>>(params); }` const exec = require('../lib/exec'); const abspath = require('../lib/abspath'); const relpath = require('../lib/relpath'); const readFile = (filename) => require('fs').readFileSync(filename, 'utf8'); const writeFile = (filename, content) => require('fs').writeFileSync(filename, content); function main() { const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean); tmFiles .filter((filename) => !filename.includes('microsoft-fork-of-react-native')) .map(abspath) .forEach((filename) => { const source = readFile(filename); const newSource = source.replace(new RegExp(regexString, 'g'), replaceString); if (source == newSource) { console.log(relpath(filename)); } writeFile(filename, newSource); }); } if (!module.parent) { main(); } ``` ## Re-generating diff ``` > hg revert -r .^ --all > node index.js # run script ``` Changelog: [iOS][Changed] - Make all ObjC NativeModules create TurboModules using ObjCTurboModule::Args Reviewed By: PeteTheHeat Differential Revision: D21036265 fbshipit-source-id: 404bcc548d1775ef23d793527606d02fe384a0a2	2020-04-16 17:29:55 -07:00
Samuel Susla	46c77dc296	Fix crash inside RCTRedBox when trying to present same UIViewController twice ... Summary: Calling `-[RCTRedBox showErrorMessage]` twice causes a crash We used `-[UIViewController isBeingPresented]` to tell whether view controller is already presented. But from the documentation: > A Boolean value indicating whether the view controller is being presented. Source: https://developer.apple.com/documentation/uikit/uiviewcontroller/2097564-beingpresented?language=objc# --- So this means that if you present it, wait until presentation animation is finished and then call `-[RCTRedBox showErrorMessage]` again, following exception will be thrown. ``` *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Application tried to present modally an active controller <UIViewController: 0x7fc33e422f50>.' ``` Changelog: Fix crash caused by presenting view controller twice from RCTRedBox Reviewed By: PeteTheHeat Differential Revision: D20946645 fbshipit-source-id: 763066e37db4e56efb0118b2e7867ad0724bae81	2020-04-10 13:51:56 -07:00
Ramanpreet Nara	69698b25fc	Codemod all getTurboModuleWithJsInvoker methods to accept a native CallInvoker ... Summary: To make iOS TurboModules integrate with the bridge's onBatchComplete event, they need to use a native CallInvoker. This call invoker is created by the `NativeToJsBridge`, and ObjCTurboModule will use this native CallInvoker to dispatch TurboModule method calls. This diff makes sure that ObjCTurboModules are created with that native CallInvoker. ## Script ``` var withSpaces = (...args) => args.join('\s*') var regexString = withSpaces( '-', '\(', 'std::shared_ptr', '<', '(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)', '>', '\)', 'getTurboModuleWithJsInvoker', ':', '\(', 'std::shared_ptr', '<', '(?<callInvokerClass>(facebook::react::|react::|::|)CallInvoker)', '>', '\)', '(?<jsInvokerInstance>[A-Za-z0-9]+)', 'perfLogger', ':', '\(', 'id', '<', 'RCTTurboModulePerformanceLogger', '>', '\)', '(?<perfLoggerInstance>[A-Za-z0-9]+)', '{', 'return', 'std::make_shared', '<', '(?<specName>(facebook::react::|react::|::|)Native[%A-Za-z0-9]+SpecJSI)', '>', '\(', 'self', ',', '\k<jsInvokerInstance>', ',', '\k<perfLoggerInstance>', '\)', ';', '}', ) var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModuleWithJsInvoker:(std::shared_ptr<$<callInvokerClass>>)$<jsInvokerInstance> nativeInvoker:(std::shared_ptr<$<callInvokerClass>>)nativeInvoker perfLogger:(id<RCTTurboModulePerformanceLogger>)$<perfLoggerInstance> { return std::make_shared<$<specName>>(self, $<jsInvokerInstance>, nativeInvoker, $<perfLoggerInstance>); }` const exec = require('../lib/exec'); const abspath = require('../lib/abspath'); const relpath = require('../lib/relpath'); const readFile = (filename) => require('fs').readFileSync(filename, 'utf8'); const writeFile = (filename, content) => require('fs').writeFileSync(filename, content); function main() { const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean); tmFiles .filter((filename) => !filename.includes('microsoft-fork-of-react-native')) .map(abspath) .forEach((filename) => { const source = readFile(filename); const newSource = source.replace(new RegExp(regexString, 'g'), replaceString); if (source == newSource) { console.log(relpath(filename)); } writeFile(filename, newSource); }); } if (!module.parent) { main(); } ``` Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D20809202 fbshipit-source-id: 5d39b3cacdaa5681b70ce1803351d0432dd74550	2020-04-03 02:27:10 -07:00
Ramanpreet Nara	652fa1b8d4	Add a perfLogger argument to getTurboModuleWithJSInvoker: ... Summary: ## Purpose We must modify the `getTurboModuleWithJsInvoker:` method of all our NativeModules to also accept a `id<RCTTurboModulePerformanceLogger>` object. This performance logger object should then be forwarded to the `Native*SpecJSI` constructor. ## Script Run the following script via Node: ``` var withSpaces = (...args) => args.join('\s*') var regexString = withSpaces( '-', '\(', 'std::shared_ptr', '<', '(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)', '>', '\)', 'getTurboModuleWithJsInvoker', ':', '\(', 'std::shared_ptr', '<', '(?<callInvokerClass>(facebook::react::|react::|::|)CallInvoker)', '>', '\)', 'jsInvoker', '{', 'return', 'std::make_shared', '<', '(?<specName>(facebook::react::|react::|::|)Native[A-Za-z0-9]+SpecJSI)', '>', '\(', '(?<arg1>[A-Za-z0-9]+)', ',', '(?<arg2>[A-Za-z0-9]+)', '\)', ';', '}', ) var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModuleWithJsInvoker:(std::shared_ptr<$<callInvokerClass>>)jsInvoker perfLogger:(id<RCTTurboModulePerformanceLogger>)perfLogger { return std::make_shared<$<specName>>($<arg1>, $<arg2>, perfLogger); }` const exec = (cmd) => require('child_process').execSync(cmd, { encoding: 'utf8' }); const abspath = (filename) => `${process.env.HOME}/${filename}`; const relpath = (filename) => filename.replace(process.env.HOME + '/', ''); const readFile = (filename) => require('fs').readFileSync(filename, 'utf8'); const writeFile = (filename, content) => require('fs').writeFileSync(filename, content); function main() { const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean); tmFiles .filter((filename) => !filename.includes('microsoft-fork-of-react-native')) .map(abspath) .forEach((filename) => { const source = readFile(filename); const newSource = source.replace(new RegExp(regexString, 'g'), replaceString); if (source == newSource) { console.log(relpath(filename)); } writeFile(filename, newSource); }); } if (!module.parent) { main(); } ``` Also, run: `pushd ~/fbsource && js1 build oss-native-modules-specs -p ios && js1 build oss-native-modules-specs -p android && popd;` Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D20478718 fbshipit-source-id: 89ee27ed8a0338a66a9b2dbb716168a4c4582c44	2020-03-18 11:01:15 -07:00
Valentin Shergin	d0871d0a9a	Clang format for all React Native files ... Summary: Buckle up, this enables clang-format prettifier for all files in React Native opensource repo. Changelog: [Internal] Clang-format codemod. Reviewed By: mdvacca Differential Revision: D20331210 fbshipit-source-id: 8da0f94700be0c35bfd399e0c48f1706de04f5b1	2020-03-08 23:01:17 -07:00
Tommy Nguyen	d0a32c2011	iOS: Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox (#28147) ... Summary: `RCTRedBox` doesn't appear in apps implementing `UISceneDelegate`. ## Changelog [iOS] [Changed] - `RCTKeyWindow()` is now multi-window aware [iOS] [Fixed] - `RCTRedBox` doesn't appear in apps implementing `UISceneDelegate` Pull Request resolved: https://github.com/facebook/react-native/pull/28147 Test Plan: - Trigger an error in RNTester - Trigger an error in an app implementing `UISceneDelegate`  Reviewed By: PeteTheHeat Differential Revision: D20036399 Pulled By: hramos fbshipit-source-id: 07d83e985b02296f930114e3c7100c2077e82300	2020-02-26 19:55:14 -08:00
Nicolas Charpentier	56dfc86d64	Enable dev keyboard shortcuts on Mac Catalyst (#27479) ... Summary: This enables the dev menu to bo opened from keyboard shortcuts in dev from a Mac Catalyst app. cc TheSavior andymatuschak radex ## Changelog [iOS] [Fixed] - Enable dev keyboard shortcuts on Mac Catalyst Pull Request resolved: https://github.com/facebook/react-native/pull/27479 Test Plan: It depends on https://github.com/facebook/react-native/issues/27469 (to have working WebSocket in debug).  Differential Revision: D19576528 Pulled By: shergin fbshipit-source-id: 32b4f8424fb7d270640af4bc50dba24f488bef4f	2020-01-26 19:57:18 -08:00
Ramanpreet Nara	7e5de4e241	Make RedBox TurboModule-compatible ... Summary: See title. Changelog: [iOS][Added] - Make RedBox TurboModule-compatible Reviewed By: PeteTheHeat Differential Revision: D18142255 fbshipit-source-id: 2d130aca93a88ac7c983ce0e4848955ffb0be518	2019-11-04 16:07:23 -08:00