2 Commits

Author	SHA1	Message	Date
Eli White	e362470305	Convert easy files to flow strict-local ... Summary: This diff was generated by this script used by WWW https://our.intern.facebook.com/intern/diffusion/WWW/browse/master/scripts/flow/upgrade_to_flow_strict_local.sh?lines=0 Changelog: [Internal] Upgrade flow to flow strict-local Reviewed By: zackargyle, rickhanlonii Differential Revision: D18833630 fbshipit-source-id: e64d4e9a49a0db5e6bf70a0c489567862b578d7f	2019-12-05 16:06:46 -08:00
Moti Zilberman	75d03b56fa	Implement a dedicated Hermes stack trace parser ... Summary: Makes stack trace parsing return a consistent representation of column numbers when using Hermes, whether we're executing bytecode (in prod) or source code (in dev). This is achieved by creating a new full-fidelity stack trace parser for Hermes. NOTE: We still use the `stacktrace-parser` package for other engines, so this fix applies only to Hermes and not to JSC - that will be fixed separately in an upcoming diff. This fixes a bug where we were skewing some stack traces by sending 1-based column numbers to the Metro symbolication endpoint, which expects them to be 0-based. The bug is only noticeable in *some* cases, namely where the column immediately following the correct one is in a different function. Changelog: [Internal] Reviewed By: cpojer Differential Revision: D18627930 fbshipit-source-id: abd80846f00f24428670b2c92153564fb4bb2aff	2019-12-02 06:02:25 -08:00