Commit Graph

3 Commits

Author SHA1 Message Date
Michał Osadnik 61e95e5cbf Force WithDefault not to be an optional value
Summary:
`WithDefault` appears not to be required to be prefixed with `?` because it's option value per se.

Fixed tests, removed `?` where needed, updated snapshots and review them. Added mechanism fro throwing error when `?WithDefault` found. Add tests for it.

Reviewed By: rubennorte

Differential Revision: D16048463

fbshipit-source-id: f55ed7454aacf0b8c42944a9b5c1037ad1b360fe
2019-07-02 03:30:55 -07:00
Rick Hanlon 004a90b131 Generate UnimplementedNativeView
Summary: This component is only used in native (there are no JS paths to it). Currently, the schema is being used to generate the native code for this component. Here, we add the codegen types so we still generate the native code when the schemas are removed, but the view config will never be used

Reviewed By: cpojer

Differential Revision: D15960990

fbshipit-source-id: 08fd0155f603e45785520c49a3ea86e30b276f9c
2019-06-24 04:59:13 -07:00
Rick Hanlon 2c1fd6f764 Add codegen flowtypes to UnimplementedNativeView
Summary:
This diff adds the generated view config for UnimplementedNativeView

Note: I believe this component was created in JS just for the codegen because it's unused anywhere

Reviewed By: cpojer

Differential Revision: D15494268

fbshipit-source-id: 8d17465fe59861a299b76565d6edbaf168f45906
2019-06-10 03:34:13 -07:00