 Paige Sun
|
5449148482
|
4/n Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs - Try 2
Summary:
Changelog: [iOS][Changed] Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs
-----
# A0) Bridge mode, Unhandled Exception, FBiOS
Unhandled exception goes to FBReactModule, but the JS Stack is not parsed correctly.
https://www.internalfb.com/code/fbsource/[312d5cbdd7278247a84619786b12a44c4400fcc0]/fbobjc/Apps/Wilde/FBReactModule2/FBReactModuleAPI/FBReactModuleAPI/Exported/FBReactModule.mm?lines=1488%2C1493
See `****** FBReactModule handleFatalError` in the logs P539306390, and compare with correct behavior in (A1) in the Test Plan.
https://pxl.cl/2h6h3
{F782257996}
-----
# A) Before diff, rn-tester
Open to rn-tester -> APIs -> Crash Examples -> JS Crash.
Set `RCTParseUnhandledJSErrorStackNatively` to YES.
https://www.internalfb.com/code/fbsource/[98880e52ee78be3614e5d9a2ce3292f6a7b5e413]/xplat/js/react-native-github/React/Base/RCTConstants.m?lines=73
{F783395297}
----
build_on_commit[ios_fbios-arm64-dylibs-jackalope-iphoneos-production_build]
Reviewed By: RSNara
Differential Revision: D40613108
fbshipit-source-id: f36c3b39a2167402ee3730db8b40b53a0b80aa60
|
2022-10-23 16:42:00 -07:00 |
|
|
Paige Sun
|
ff398e4e26
|
4/n Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs
Summary:
Changelog: [iOS][Changed] Display a RedBox with the JS stack (instead of native stack) when an unhandled JS exceptions occurs
-----
# A0) Bridge mode, Unhandled Exception, FBiOS
Unhandled exception goes to FBReactModule, but the JS Stack is not parsed correctly.
https://www.internalfb.com/code/fbsource/[312d5cbdd7278247a84619786b12a44c4400fcc0]/fbobjc/Apps/Wilde/FBReactModule2/FBReactModuleAPI/FBReactModuleAPI/Exported/FBReactModule.mm?lines=1488%2C1493
See `****** FBReactModule handleFatalError` in the logs P539306390, and compare with correct behavior in (A1) in the Test Plan.
https://pxl.cl/2h6h3
{F782257996}
-----
# A) Before diff, rn-tester
Open to rn-tester -> APIs -> Crash Examples -> JS Crash.
Set `RCTParseUnhandledJSErrorStackNatively` to YES.
https://www.internalfb.com/code/fbsource/[98880e52ee78be3614e5d9a2ce3292f6a7b5e413]/xplat/js/react-native-github/React/Base/RCTConstants.m?lines=73
{F783395297}
Reviewed By: sammy-SC
Differential Revision: D40387938
fbshipit-source-id: 2abea657476d3bf61ad5b1c643f129e44c6f3f35
|
2022-10-20 21:12:41 -07:00 |
|
Donald Webster