Commit Graph
3340 Commits
Author SHA1 Message Date
Tim Yung 30e2345b26 Pressability: Replace cancelable Change w/ blockNativeResponder
Summary:
{D47225928} introduced a bug affecting `TextInput` on iOS that prevented native text editing capabilities. This reverts the change to a previous incarnation of the diff where javache created a new `blockNativeResponder` option instead of piggybacking off the existing `cancelable` option.

Changelog:
[iOS][Changed] - Restored `cancelable` option in `Pressability` configuration to not block native responder, and instead introduced a new optional `blockNativeResponder` boolean option to accomplish the same thing.

Reviewed By: mdvacca

Differential Revision: D48246530

fbshipit-source-id: 8a406d462cce0e5e5a108607e1ac1d3203ea229c
2023-08-10 17:53:58 -07:00
Arushi Kesarwani 01b9b509cf ReactHostInterface & ReactHost refactoring (#38826)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38826

`ReactHostInterface` -> `ReactHost`
`ReactHost` -> `ReactHostImpl`

changelog: [internal] internal

allow-large-files

Reviewed By: cortinico

Differential Revision: D48054716

fbshipit-source-id: b926877a0119f906ff794a496df4e30351b71423
2023-08-10 17:24:46 -07:00
David Vacca 75c1422286 Allow configuration of 'allWarningsAsErrors' in gradle (#38930)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38930

As we migrate java to kotlin I noticed that we've introduced few warnings here and there.
I'm introducing a way to configure allWarningsAsErrors in gradle

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48238321

fbshipit-source-id: 745847bc6e6df94decc54afa8c9041552d91dfee
2023-08-10 16:22:40 -07:00
David Vacca 450e00e5ce Fix warning in ReactImagePropertyTest
Summary:
Fix warning in ReactImagePropertyTest

changelog: [internal] internal

Reviewed By: NickGerleman

Differential Revision: D48234859

fbshipit-source-id: 8217289ed18b07ee6977d32c7d0b68ce74c0131b
2023-08-10 16:22:40 -07:00
David Vacca 1348314b6f Fix compilation warnings in JSPointerDispatcherTest.kt (#38914)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38914

Fix compilation warnings in JSPointerDispatcherTest.kt

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48213629

fbshipit-source-id: 6b46b86d9340311f1b2d750cc11d79227cb8682f
2023-08-10 16:22:40 -07:00
David Vacca e94c7e0a44 Fix warning in SimpleViewPropertyTest (#38913)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38913

Fix few warnings in  SimpleViewPropertyTest

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48206413

fbshipit-source-id: f398e035624200cb6fc327568cf85e015ad83d76
2023-08-10 16:22:40 -07:00
David Vacca 9e51f59211 Increate androidx dependency versions to latest ones (#38904)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38904

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48201237

fbshipit-source-id: e3df2de55790ce9ea7a5d5fb2a513f09b69a166b
2023-08-10 16:22:40 -07:00
David Vacca 354bfc3587 Rename jSBundleLoader -> jsBundleLoader (#38910)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38910

Rename jSBundleLoader -> jsBundleLoader

changelog: [internal] internal

Reviewed By: christophpurrer

Differential Revision: D48051752

fbshipit-source-id: 4443e9fc1801e3a0794b9dfad677318e897d5400
2023-08-10 15:14:13 -07:00
Vincent Riemer 37fee66680 Add initial Pointer Capture API implementation (#38505)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38505

Changelog: [Internal] - Add initial Pointer Capture API implementation

This diff introduces the first baseline implementation of pointer capturing through intercepting/modifying Pointer Events in flight through the `PointerEventsProcessor` class.

Firstly: This adds and exposes the imperative methods `setPointerCapture`, `releasePointerCapture`, and `hasPointerCapture` which is added to the host `ReadOnlyElement` ref API. These methods are used to manage/query the `pendingPointerCaptureTargetOverrides_` map as [defined in the spec](https://www.w3.org/TR/pointerevents/#setting-pointer-capture).

The code is fairly self-explainatory when it comes to retargeting the events in `PointerEventsProcessor::interceptPointerEvent` but when it comes to firing the `gotPointerCapture` and `lostPointerCapture` events those are handled in `PointerEventsProcessor::processPendingPointerCapture` and is a fairly direct implementation of [the spec's pseudocode](https://www.w3.org/TR/pointerevents/#process-pending-pointer-capture).

Finally at the end of `interceptPointerEvent` I've included the basics of implicit pointer capture *release* as per [the spec](https://www.w3.org/TR/pointerevents/#implicit-release-of-pointer-capture) (note that implicit pointer capture is not yet implemented).

Reviewed By: rozele

Differential Revision: D47533366

fbshipit-source-id: 1786f9703a88201bc9c7bde61af76eb4b07a20ee
2023-08-10 14:53:31 -07:00
Ruslan Shestopalyuk 6860ffa350 Move nativePerformanceNow binding call into common core code (#38928)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38928

## Changelog:
[Internal] -

This moves the call to bind the `nativePerformanceNow` function to the common place in C++ code (`JSIExecutor::initializeRuntime`), as opposed on relying on calling it from every platform-specific implementation.

I believe the reason why it was don this way, to begin with, was historical, since we did use to have a different implementation of this function on every platform. Now we have a common one in C++, anyway, so there is no reason whatsoever to have this binding platform-specific.

Reviewed By: rubennorte

Differential Revision: D48232883

fbshipit-source-id: 164dc464ab7f89e993d83a4562906e033aabb3b7
2023-08-10 14:43:29 -07:00
Alex Hunt e1998806b7 Migrate cli-plugin-metro into repo (#38795)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38795

## Context

RFC: Decoupling Flipper from React Native core: https://github.com/react-native-community/discussions-and-proposals/pull/641

## Changes

Inits new package `react-native/community-cli-plugin`. This migrates [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) into the React Native repo, to enable faster iteration by the React Native core team. Specifically:

- This package contains several `metro` dependencies, which when removed from CLI will no longer require us to ship new CLI releases to get Metro patches and features to users.
- This package contains the `start`, `bundle`, and `ram-bundle` commands (central to the React Native development experience), for which we have incoming debugging-related changes.
- This package now **only** exports commands to be attached via a RN CLI plugin. With this move, we're aiming to **internalise** the default implementations of these dev commands within React Native — other RN CLI plugins can continue to override these, but must do so wholesale. (See also the recent fix for this: https://github.com/react-native-community/cli/pull/1999.)

In V15:
- (Microsoft feedback) Re-export  `unstable_buildBundleWithConfig`, marking as unstable. This gives us a time buffer to consider how we repackage this functionality in future.

The package source has been converted from TypeScript to Flow, with a number of new `flow-typed/` defs added to meet type coverage requirements.

## To dos

- For now, we aren't removing the existing [`react-native-community/cli-plugin-metro`](https://github.com/react-native-community/cli/tree/main/packages/cli-plugin-metro) source — until later PRs consolidate this move by changing dependencies in the `react-native` package.
- **Exported API is reduced!**: I'm working with szymonrybczak to decouple references from RN CLI packages https://github.com/react-native-community/cli/pull/2021.

Changelog: [Internal]

Reviewed By: motiz88

Differential Revision: D46801501

fbshipit-source-id: 7f6b72941a69f487fb437768cdba125a9aa3418d
2023-08-10 11:34:36 -07:00
Janic Duplessis 1a1a79871b Fix null crash when using maintainVisibleContentPosition on Android (#38891)
Summary:
`mFirstVisibleView` is a weak ref so it can also be null when dereferencing.

This was reported on the original PR here https://github.com/facebook/react-native/pull/35049#discussion_r1288195469

## Changelog:

[ANDROID] [FIXED] - Fix null crash when using maintainVisibleContentPosition on Android

Pull Request resolved: https://github.com/facebook/react-native/pull/38891

Test Plan: Not sure exactly in what cases this can happen, but the fix is trivial and makes sense.

Reviewed By: cortinico

Differential Revision: D48192154

Pulled By: rshest

fbshipit-source-id: 57a38a22a0e216a33603438355bde0013c014fbf
2023-08-10 11:23:06 -07:00
Nicola Corti 0c483d309c Introduce a build_android step (#38848)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38848

In order to parallelize the Android CI, I've moved most of the building to a `build_android` step which executes before the `build_npm_package` step.

As currently, building Hermes for Android is on the critical path, this should reduce much of the execution time on CI.

Changelog:
[Internal] [Changed] - Introduce a build_android step

Reviewed By: mdvacca

Differential Revision: D48148418

fbshipit-source-id: bfe3175fcc11d96e264eb31d8d5555bd1f83c01d
2023-08-10 05:34:13 -07:00
David Vacca e2ef6b98a0 Rename jSEngineInstance -> jsEngineInstance (#38909)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38909

Rename jSEngineInstance -> jsEngineInstance

changelog: [internal] internal

Reviewed By: christophpurrer

Differential Revision: D48051751

fbshipit-source-id: ae96270f9dfa56b39bcc42ea8ac108235695311c
2023-08-09 23:30:01 -07:00
David Vacca 2e5b122f23 Rename jSMainModulePath -> jsMainModulePath (#38908)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38908

Rename jSMainModulePath -> jsMainModulePath

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D48051753

fbshipit-source-id: af20a18ec6a01de7db6484b7a7a2e3b2b3353396
2023-08-09 23:30:01 -07:00
David Vacca fff0cd11d4 Rename BridgelessReactPackage to CoreReactPackage (#38775)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38775

Rename BridgelessReactPackage to CoreReactPackage

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48050452

fbshipit-source-id: 7ac54af0123412ed0cb9e960ccc13fd70a1a8ebc
2023-08-09 23:30:01 -07:00
David Vacca 56aceb3f27 Make BridgelessReactPackage package only (#38777)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38777

Make BridgelessReactPackage package only

changelog: [internal] internal

Reviewed By: cortinico, arushikesarwani94

Differential Revision: D48050454

fbshipit-source-id: 8f6fac8bdc57004610dec27950bbec38f12b13fe
2023-08-09 23:30:01 -07:00
David Vacca 54b368b926 Move BridgelessReactPackage from com.facebook.react to com.facebook.react.bridgeless (#38776)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38776

in this diff I'm moving BridgelessReactPackage from com.facebook.react to com.facebook.react.bridgeless.

the goal is to hide this class from the API

changelog: [internal] internal

Reviewed By: cortinico, arushikesarwani94

Differential Revision: D48050453

fbshipit-source-id: 54ac042d491a7b8fe83e543c94e0d06bd9b88cda
2023-08-09 23:30:01 -07:00
Nicola Corti 28dd1bbe0f Enable local caching for Gradle (#38882)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38882

This turns on local caching for Gradle builds.
From now on, some of the tasks of the build will be cached inside the `.gradle` folder.

This will benefit 'clean builds' and builds happening after branch/context switch.
CI will also benefit from this improvement as we're storing the cache folder on CircleCI.

After this we'll have to follow-up and enabling `Cacheable` on each of our task as
they're currently all disabled.

Changelog:
[Internal] [Changed] - Enable local caching for Gradle

Reviewed By: mdvacca

Differential Revision: D48187656

fbshipit-source-id: 25734ed692a69874721e86c50498b075af0fda19
2023-08-09 17:32:43 -07:00
Xin Chen c2c7462705 Add perf comparison example with set state in effect (#38798)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38798

Changelog:
[General][Internal] - Add example to compare perf with set state in unnecessary effect.

Reviewed By: rshest

Differential Revision: D47857125

fbshipit-source-id: f0e9f71cf2f549012394959a9087117f02e2d056
2023-08-09 14:57:55 -07:00
Nicola Corti fdab18b0a1 Fix compilation avoidance bug with buildCodegenCLI (#38903)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38903

Currently Android is not rebuilding the CLI if its content changes. This is a bug.
It's resolution is a bit more complicated as we do have various `buildCodegenCLI` tasks, also in user projects.

I've removed the tasks from the user projects, as they're practically not needed (users always consume a prebuilt codegen).

And I've also updated the setup to have only one `buildCodegenCLI` in the ReactAndroid project.
This allows us to ensure the job executes only once and has correct input/outputs.

Changelog:
[Internal] [Changed] -  Fix compilation avoidance bug with buildCodegenCLI

Reviewed By: mdvacca

Differential Revision: D48199157

fbshipit-source-id: ba3be6a0ca959ac4e1240e8feb99b8274e4e2b46
2023-08-09 14:33:00 -07:00
bufgix cb60e5c67b Convert ReactImagePropertyList to kotlin (#38845)
Summary:
Issue: https://github.com/facebook/react-native/issues/38825#issuecomment-1669205837

## Changelog:
[GENERAL] [CHANGED] - ReactImagePropertyList.java => ReactImagePropertyList.kt

Pull Request resolved: https://github.com/facebook/react-native/pull/38845

Test Plan: `./gradlew :packages:react-native:ReactAndroid:test`

Reviewed By: cortinico, NickGerleman

Differential Revision: D48171953

Pulled By: mdvacca

fbshipit-source-id: ae1fbf32f2ef6d18ebe593e31664e45ca339941c
2023-08-09 13:45:07 -07:00
David Vacca 2013c2cd67 Fix Android build warning
Summary:
Fix Android build warning reporting usage of depreacted APIs: Robolectric.setupActivity() is deprecated in Android unit test

Following Google Android recommendations: https://developer.android.com/reference/androidx/test/core/app/ActivityScenario

changelog: [internal] internal

Reviewed By: cortinico

Differential Revision: D48168983

fbshipit-source-id: ac37235715578af6e28da2e219c6a942bfafca2a
2023-08-09 11:56:44 -07:00
David Vacca da6a7a0c7c Upgrade ANDROIDX TEST VERSION to 1.4.0
Summary:
Upgrade ANDROIDX TEST VERSION to 1.4.0

This is necessary to be able to use androidx.test:core in the next diffs
changelog: [internal] internal

Reviewed By: cortinico, NickGerleman

Differential Revision: D48176680

fbshipit-source-id: 93e0ba68b2eb37ba783a9faa7d9b56425b225ae7
2023-08-09 11:56:44 -07:00
Nicola Corti b7c4736eb6 Convert flipper-integartion Gradle file to Kotlin DSL (#38884)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38884

Convert flipper-integartion Gradle file to Kotlin DSL

Changelog:
[Internal] [Changed] - Convert flipper-integartion Gradle file to Kotlin DSL

Reviewed By: luluwu2032

Differential Revision: D48187572

fbshipit-source-id: ff463f2ccf5ea3333893b3c6c691808d478a855d
2023-08-09 10:08:27 -07:00
Siddarth Kumar 5657d2d3bd (refactor): kotlinify JSPointerDispatcherTest.java (#38878)
Summary:
This PR converts the java logic inside of `JSPointerDispatcherTest.java` to Kotlin as requested in https://github.com/facebook/react-native/issues/38825
We also swap `JSPointerDispatcherTest.java` for `JSPointerDispatcherTest.kt`

## Changelog:

[Internal][Changed]: Convert JSPointerDispatcherTest to Kotlin

Pull Request resolved: https://github.com/facebook/react-native/pull/38878

Test Plan:
`./gradlew :packages:react-native:ReactAndroid:test` must pass and CI must be green

## Screenshot of Tests passing locally:

![Screenshot 2023-08-09 at 12 48 04 PM](https://github.com/facebook/react-native/assets/64726664/566fc648-adb7-4f52-87fc-67ef2f39a1a2)

Reviewed By: rshest

Differential Revision: D48189629

Pulled By: cortinico

fbshipit-source-id: 92d869f690457986413bcae33a15225aa6e006be
2023-08-09 10:05:14 -07:00
Ruslan Shestopalyuk 51faa1863f More robust handling of errors when trying to load JS bundle
Summary:
## Changelog:
[Internal] -

When trying to load JS bundle, there were conditions under which it could just silently fail, not giving much to start with when troubleshooting.

It was relying on Folly internals to handle the error, and depending on the context it could either throw an exception or just silently exit the process if exceptions are not enabled in Folly.

This diff makes this error handling more explicit, with a clear error message in the log.

Reviewed By: NickGerleman

Differential Revision: D48147690

fbshipit-source-id: 1bb08ad17a880989e829c281fe25ee0d4a385d59
2023-08-09 09:29:32 -07:00
Nicola Corti 0a84952ce5 Cleanup the commitlies code (#38889)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38889

As we don't really use the commitlies code in CircleCI, I'm cleaning up some of the code used to publish artifacts to the user.

Changelog:
[Internal] [Changed] - Cleanup the commitlies code

Reviewed By: cipolleschi

Differential Revision: D48189398

fbshipit-source-id: c4591ee290eba49224322d44a32052ff292ccbed
2023-08-09 09:23:14 -07:00
Riccardo Cipolleschi 5140d6438d Generate .xcode.env.local at pod install time (#38879)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38879

When creating a new app for iOS, you need to have Node installed properly and in the right paths in order for Xcode to pick it up.

Xcode, by default, looks into the following folders for executables:
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/appleinternal/bin:
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/local/bin:
- /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/libexec
- /Applications/Xcodefb.app/Contents/Developer/Platforms/iPhoneSimulator.platform/usr/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/usr/appleinternal/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/usr/local/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/bin
- /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/usr/local/bin
- /Applications/Xcode.app/Contents/Developer/usr/bin
- /Applications/Xcode.app/Contents/Developer/usr/local/bin
- /usr/local/bin
- /usr/bin
- /bin
- /usr/sbin
- /sbin

If `node` is not in one of them, our JS codegen scripts will fail to run. However, as soon as we run some scripts in Xcode, it is too late to properly look for node.

We already had a cocoapod step, running before the build phase, which was creating the `.xode.env` file, setting `NODE_BINARY` to `$(command -v node)`. Unfortunately, when executed by Xcode, that's too late too.

This change creates an `.xcode.env.local` file with the `$(command -v node)` command expanded, so I user can start working locally and quickly.

We had multiple reports and issues related to this configuration online. For example:
- https://www.reddit.com/r/reactnative/comments/15jpj0a/is_there_a_react_native_version_that_just_works/?utm_source=share&utm_medium=web2x&context=3

Note: we cannot automatically create simlinks to node in `/usr/local/bin` as it requires `sudo`.

## Changelog:
[Internal] - Generate `.xcode.env.local` to simplify the creation of an app.

Reviewed By: rshest

Differential Revision: D48111724

fbshipit-source-id: 49cc6375bd80458d69adbc343ead6c4408805eee
2023-08-09 08:38:22 -07:00
Lulu Wu 72b9516cea Enable partial media picking in Marketplace (#38880)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38880

Users who interact with your app on Android 14 devices can now grant partial access to their visual media library (Photos/Videos) when an app requests any visual media permissions (READ_MEDIA_IMAGES or READ_MEDIA_VIDEO) introduced in Android 13 (API level 33).

This diff allow enable the partial access via "READ_MEDIA_VISUAL_USER_SELECTED" in Marketplace photo picker

For Android 14 this diff request partial media access plus the normal access, there will be two return cases:
- READ_MEDIA_VISUAL_USER_SELECTED is granted, READ_MEDIA_IMAGES and READ_MEDIA_VIDEO will be denied automatically, there is no need to check the later ones
- READ_MEDIA_VISUAL_USER_SELECTED is denied, then check READ_MEDIA_IMAGES and READ_MEDIA_VIDEO

Changelog:
[Android][Changed] - Enable partial media picking in Marketplace

Reviewed By: NickGerleman

Differential Revision: D48171193

fbshipit-source-id: 644f6c691f9c2c25f981ba2c255044f62b97299d
2023-08-09 06:07:28 -07:00
Madhusudan Sapkota baa2714648 SimpleViewPropertyTest.java => SimpleViewPropertyTest.kt (#38856)
Summary:
This PR converts SimpleViewPropertyTest into Kotlin as requested in [https://github.com/facebook/react-native/issues/38835](https://github.com/facebook/react-native/issues/38825#issuecomment-1669634951)

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[INTERNAL] [CHANGED] - Convert to SimpleViewPropertyTest Kotlin

Pull Request resolved: https://github.com/facebook/react-native/pull/38856

Test Plan:
1. Run `./gradlew :packages:react-native:ReactAndroid:test.`
2. All tests should pass.

Reviewed By: NickGerleman

Differential Revision: D48171939

Pulled By: mdvacca

fbshipit-source-id: eaa93a696faba1793b85186e6a072a7d3f043d0c
2023-08-08 20:14:34 -07:00
Intl Scheduler 5d67460447 translation auto-update for i18n/fb4a.config.json on master
Summary:
Chronos Job Instance ID: 1125907937909496
Sandcastle Job Instance ID: 36028798033748901
allow-large-files
ignore-conflict-markers
opt-out-review

Differential Revision: D48178204

fbshipit-source-id: 057881c7aaa207066d6d21b31a24b6d97a3c24ae
2023-08-08 18:17:11 -07:00
Ellis Tsung d6ff5c6d5b Pass hitSlop prop into TextInput Pressability config (#38857)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38857

`hitSlop` must be passed into the `usePressability` hook in order for it to take effect. It's a no-op if no hit slop is present

Changelog:
    [Internal][Fixed] - Propagate hit slop prop to TextInput pressability config

Reviewed By: NickGerleman

Differential Revision: D48124538

fbshipit-source-id: a910fdcec55e67d37c84facca297428556ef777e
2023-08-08 17:30:11 -07:00
Xin Chen a8962ce970 Refactor code structure to make it easier for adding new examples (#38799)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38799

Refactor the performance comparison examples to make it easier to add new ones.

Changelog:
[General][Internal] - Code refactor

Reviewed By: rshest

Differential Revision: D47857126

fbshipit-source-id: fc8ffbcc94a23b896a53f599161f3bf6e9c2eaad
2023-08-08 15:13:28 -07:00
David Vacca fc85b60db8 Update documnetation of TurboModule.invalidate() (#38854)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38854

Update documnetation of TurboModule.invalidate()

changelog: [internal] internal

Reviewed By: rshest

Differential Revision: D48130527

fbshipit-source-id: 0ebedaad603beba646f9ad4f047492e88b5f54a0
2023-08-08 12:36:22 -07:00
Siddarth Kumar 1d8727966d add emitBuildEventSchema to parser commons (#38810)
Summary:
[Codegen 119] This PR introduces `emitBuildEventSchema` to parser commons and abstracts the logic out of typescript and parser events as requested on https://github.com/facebook/react-native/issues/34872

## Changelog:

[Internal] [Changed] - Add `emitBuildEventSchema` to parser commons and update usages.

Pull Request resolved: https://github.com/facebook/react-native/pull/38810

Test Plan:
Run `yarn jest react-native-codegen` locally and ensure CI is green

## Screenshot of test passing locally:

<img width="1047" alt="Screenshot 2023-08-07 at 8 03 49 AM" src="https://github.com/facebook/react-native/assets/64726664/ab87f004-d9f8-4b5f-800b-0e724430301f">

Reviewed By: rshest

Differential Revision: D48155051

Pulled By: cipolleschi

fbshipit-source-id: a3db3f4783d60681b366a871b1d2ee32eb864bc0
2023-08-08 11:52:26 -07:00
Nicola Corti e563f0f3fc Use version catalog to consolidate versions for JVM dependencies (#38836)
Summary:
As we had version numbers scattered all over the places, I'm consolidating them to use a version catalog: https://docs.gradle.org/current/userguide/platforms.html

## Changelog:

[INTERNAL] - Use version catalog to consolidate versions for JVM dependencies

Pull Request resolved: https://github.com/facebook/react-native/pull/38836

Test Plan: CI

Reviewed By: cipolleschi

Differential Revision: D48150285

Pulled By: cortinico

fbshipit-source-id: 83a1867aace5395d9a10fadd6c6ab11c31fa14b5
2023-08-08 11:37:43 -07:00
Burak Güner 639b4892b4 ImageResizeModeTest.java => ImageResizeModeTest.kt (#38844)
Summary:
This PR converts ImageResizeModeTest into Kotlin as requested in https://github.com/facebook/react-native/issues/38825 .

## Changelog:

[INTERNAL] [CHANGED] - Convert  to ImageResizeModeTest Kotlin

Pull Request resolved: https://github.com/facebook/react-native/pull/38844

Test Plan:
1. Run `./gradlew :packages:react-native:ReactAndroid:test`.
2. All tests should pass.

Reviewed By: rshest

Differential Revision: D48154896

Pulled By: cortinico

fbshipit-source-id: df131a4f3f9190af8d7b77e625e050f02824ad07
2023-08-08 11:33:36 -07:00
David 3660b7cf73 ☂️ BaseViewManagerTest.java => BaseViewManagerTest.kt (#38841)
Summary:
Issue: https://github.com/facebook/react-native/issues/38825#issuecomment-1669202200

## Changelog:

[GENERAL] [CHANGED] - `BaseViewManagerTest.java` => `BaseViewManagerTest.kt`

Pull Request resolved: https://github.com/facebook/react-native/pull/38841

Test Plan:
```shell
./gradlew :packages:react-native:ReactAndroid:test
```

Reviewed By: cortinico

Differential Revision: D48153909

Pulled By: rshest

fbshipit-source-id: cac20a64b72b77c23edb2e20b65717c1a425a08a
2023-08-08 11:21:19 -07:00
tarunrajput 4343144c81 Migrate CustomLineHeightSpanTest to kotlin (#38847)
Summary:
Migrate `CustomLineHeightSpanTest` to kotlin as part of ☂️ https://github.com/facebook/react-native/issues/38825

## Changelog:

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Internal] [Changed] - Migrate CustomLineHeightSpanTest to kotlin

Pull Request resolved: https://github.com/facebook/react-native/pull/38847

Test Plan:
```
./gradlew :packages:react-native:ReactAndroid:test
```

Reviewed By: rshest

Differential Revision: D48155397

Pulled By: cortinico

fbshipit-source-id: bbaa7d08a84c609bc64b48a08e1b91078ce6ef23
2023-08-08 10:49:15 -07:00
Intl Scheduler 798811cbeb translation auto-update for Apps/Wilde/scripts/intl-config.json on master
Summary:
Chronos Job Instance ID: 1125907937645695
Sandcastle Job Instance ID: 31525198404545727
allow-large-files
ignore-conflict-markers
opt-out-review

Differential Revision: D48150098

fbshipit-source-id: 57f6890962bfa7c03000eece13e9d80c775fa9d0
2023-08-08 05:31:14 -07:00
Intl Scheduler 2f886ba95c translation auto-update for i18n/barcelona.config.json on master
Summary:
Chronos Job Instance ID: 1125907937543126
Sandcastle Job Instance ID: 22517999148323898
allow-large-files
ignore-conflict-markers
opt-out-review

Differential Revision: D48146361

fbshipit-source-id: ecd68640881e032dc9bfab9d01c26a14e6be6b13
2023-08-08 01:54:23 -07:00
Nick Gerleman f965da97f3 Add experimental_layoutConformance prop (#38746)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38746

This adds a view prop which controls the layout conformance of it and its transitive children (including non-view ShadowNodes).

The implementation here is to traverse down before layout, updating any context-specific configuration.

Normally at the time of layout, unchanged child ShadowNodes are already sealed. These must be mutated already if layout results change, and we do this today via Yoga node clone callback, where Yoga clones nodes where it will do layout work (but not all of them).

We down-propagate configuration, but can terminate if we observe an already sealed node whose values match those of our current context, since any nodes under must also follow the same contexts (or any nested contexts of the sealed node).  This means that calling `layoutTree()` on a mostly clean ShadowTree will cause configuration to not traverse most nodes.

`Errata` and `PointScaleFactor` (DPI) are threaded to each Node's per-node config. The same values are retained when Yoga nodes are cloned (by cloning the ShadowNode). Since these are set before the first layout, config setting should only ever dirty layout [when layout-effecting values change](https://www.internalfb.com/code/fbsource/[1c95e981c740]/xplat/yoga/yoga/YGConfig.cpp?lines=13).

The prop is prefixed with `experimental` because we are likely to make more breaking conformance fixes in the strict mode, and I'm not sure this is the final API yet. I was previously looking at a context-like component which is more challenging to implement.

Changelog: [Internal]

bypass-github-export-checks

Reviewed By: rozele, sammy-SC

Differential Revision: D47940100

fbshipit-source-id: f72e1c73f537e0312c2bba19ae8c2e882c82aced
2023-08-07 19:37:41 -07:00
Nick Gerleman 0e69050612 Use right edge of ScrollView viewport for scrollMetrics.offset in RTL
Summary:
The offset we record should be the one closest to the reference zero-point in the coordinate space. This makes scroller offset reference match the cell reference we keep in D47978631.

Changelog:
[General][Fixed] - Use right edge of ScrollView viewport for `scrollMetrics.offset` in RTL

bypass-github-export-checks

Reviewed By: lenaic

Differential Revision: D48132236

fbshipit-source-id: 3307081e5e859f1b4afbc15a84c5be1b33915206
2023-08-07 19:36:07 -07:00
Sam Zhou c0c450793e Add missing constants to fallback implementation of ToastAndroid (#38803)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38803

The d.ts file says these constant must exist, but they only exist in the android implementation. This diff stops lying and adds some dummy constants, so that the type will match-up.

Changelog: [Internal]

Reviewed By: yungsters

Differential Revision: D48085126

fbshipit-source-id: 8d5332a71b9b3c1925abeec9e47630a07abf8b86
2023-08-07 18:50:44 -07:00
Nicola Corti 8a4452068f Do not import java Collections from Kotlin (#38822)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38822

We should not attempt to import `java.util.Collections` in a Kotlin file
as we should use the Kotlin's equivalent class instead.

Changelog:
[Internal] [Changed] - Do not import java Collections from Kotlin

Reviewed By: cipolleschi

Differential Revision: D48117940

fbshipit-source-id: f1a972f1d3867ee4dd788c3cf34c1b931a8082d8
2023-08-07 11:36:55 -07:00
Nicola Corti b7b69c589c Enable Kotlin for RN Tester (#38820)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38820

This is needed if we want to allow users to write Kotlin code inside RN Tester

Changelog:
[Internal] [Changed] - Enable Kotlin for RN Tester

Reviewed By: mdvacca, cipolleschi

Differential Revision: D48117203

fbshipit-source-id: c4a69cca95dfed936d85a45dd91f1518cfe1726f
2023-08-07 10:31:04 -07:00
Samuel Susla 00b7177729 Add more systrace data to UIManager (#38789)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38789

changelog: [internal]

Add more data to completeSurface, createNode and cloneNode.
Add systrace annotation to UIManager::updateState

Reviewed By: rshest

Differential Revision: D48066599

fbshipit-source-id: 0f13221639f9d1eef94456799e3bd1df3cb23a0e
2023-08-07 10:10:26 -07:00
Samuel Susla d1a2c346a7 Remove systrace from recursive function (#38790)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38790

changelog: [internal]

Remove systrace from recursive function. This causes visual noise in perf tooling.

Reviewed By: rshest

Differential Revision: D48066562

fbshipit-source-id: 98739477f712c428e09cd9f5c06b399830f8f533
2023-08-07 10:10:26 -07:00
Nicola Corti 2e5483e303 Add missing libreact_utils.so inside RNGP pickFirst (#38818)
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/38818

When building the template test on CircleCI, I've noticed we fire a warnign for `libreact_utils.so` as we're missing a pickFirst directive.
You can see an example of the warning here:
https://app.circleci.com/pipelines/github/facebook/react-native/28853/workflows/f1808b5e-fb40-4165-8885-694f88037f9f/jobs/904972

This fixes it by adding `libreact_utils.so` to the `pickFirst` list.

Changelog:
[Internal] [Changed] - Add missing `libreact_utils.so` inside RNGP pickFirst

Reviewed By: cipolleschi

Differential Revision: D48115852

fbshipit-source-id: 02e8b3172aea84360d06a1a12400fe7bc99859e5
2023-08-07 09:48:32 -07:00