Alexander Blom
2cc57d05a4
Support loading source maps
...
Reviewed By: davidaurelio
Differential Revision: D4121492
fbshipit-source-id: e2f9c42de3e28cd231580d8b7d3230d47e300d2e
2016-11-15 08:59:02 -08:00
Alexander Blom
f571d28e68
Allow launching inspector from dev menu
...
Reviewed By: davidaurelio
Differential Revision: D4095356
fbshipit-source-id: 46e43578cdcd663316efb82dffde27b77294c5c0
2016-11-15 08:59:02 -08:00
Alexander Blom
655fe2796a
Add packager inspector proxy
...
Summary:
Implements a multi-device proxy for the Chrome debugging protocol. Each device connects
to the proxy over a single websocket connection that is able to multiplex messages to multiple
Javascript VMs. An inspector instance running in Chrome can connect to a specific VM via this
proxy.
Reviewed By: davidaurelio
Differential Revision: D4088492
fbshipit-source-id: 3ee934e98604b5a378da732e687ca05fe3d23ce0
2016-11-15 08:59:02 -08:00
Ovidiu Viorel Iepure
24d2bbfbab
Fix lint in local-cli
...
Reviewed By: cpojer
Differential Revision: D4166993
fbshipit-source-id: 9a8249175d98b42d7557817846d8c09c9769485e
2016-11-14 11:13:42 -08:00
Ovidiu Viorel Iepure
33fb428a07
Use npm for e2e tests
...
Summary:
Force npm for e2e tests.
Bonus: tracked down and removed a non-standard `.done()` call that was breaking e2e tests.
Reviewed By: bestander
Differential Revision: D4153514
fbshipit-source-id: 079939874ea75c7ea6e3e5376d37873c95fc74c1
2016-11-09 09:31:12 -08:00
Matthew Dapena-Tretter
a643784144
Allow arguments in the editor env var
...
Reviewed By: frantic
Differential Revision: D4129207
fbshipit-source-id: a92fbbbe917db9c9afc0d970e3ac546e2a14bced
2016-11-04 12:59:17 -07:00
Tim Yung
8b653cde56
RN: Show Warning for Background Remote Debuggers
...
Summary:
Some recent change to Chrome causes the remote debugger to be throttled unexpectedly if it is in a background tab. Although this does not fix the problem, it raises the issue and suggests a workaround.
I also cleaned up some littering of the global namespace in the debugger web worker.
Reviewed By: jingc
Differential Revision: D4104515
fbshipit-source-id: 56e46c0e759bec4c42d3baedd4d2d46cdea2e4a0
2016-10-31 11:29:57 -07:00
Tim Yung
448e66b3fa
RN: Cleanup Debugger HTML
...
Summary: Minor cleanup to `debugger.html`.
Reviewed By: fkgozali
Differential Revision: D4104499
fbshipit-source-id: f484711b4a855a1fd703d3a457b96ad45e0250e2
2016-10-31 11:29:57 -07:00
Mehdi AHRAOUI
a16d72842d
debuggerWorker.js contains code incompatible with node 5
...
Summary:
Hi,
This is a small fix for issue #10564 .
Closes https://github.com/facebook/react-native/pull/10571
Differential Revision: D4086542
fbshipit-source-id: a50b4b3afdefe4abfe64869768ce51c6c628708a
2016-10-26 19:28:38 -07:00
Charles Dick
6ddf8a8795
refactor aggrow to make adding new sources of data easier
...
Reviewed By: michalgr
Differential Revision: D3961648
fbshipit-source-id: 3c77d3c1352fd89e12163eee393ffcebe09ea8e3
2016-10-25 07:13:51 -07:00
David Aurelio
d7aa297762
Break out defaults, add flow for Config
...
Summary: In order to make `Config` and defaults available to our new code, I’ve added flow types and put default values into one shared modile
Reviewed By: cpojer
Differential Revision: D4044600
fbshipit-source-id: 875ed3ade69c5b22bb3c1b177e7bad732834d476
2016-10-22 06:13:42 -07:00
Charles Dick
217a4449d4
remove dependency between aggrow and stackRegistry
...
Reviewed By: bnham
Differential Revision: D3876267
fbshipit-source-id: 2ad7e70445f3f4641cde554e94de000403368233
2016-10-06 07:58:36 -07:00
Jani Eväkallio
467b637656
Add a debugger favicon
...
Summary:
I frequently spend multiple seconds scanning my open Chrome tabs for the React Native debugger tab. It would be a lot quicker to find the correct tab if the debugger UI tab had a favicon.
This commit adds favicon (blue react logo in a white circle). It's a super minor change, but would help a lot with day-to-day DX.
I chose this icon to differentiate sufficiently from other tabs developer might have open: React docs (blue logo in black square) and React Native docs (white logo in black square). If the idea of having a favicon is agreeable but you want a different asset, I'm more than happy to change it to something else.
Original asset before base-64 encoding:

In the wild:
<img width="335" alt="screen shot 2016-10-05 at 15 40 58" src="https://cloud.githubusercontent.com/assets/1203949/19117811/43cad316-8b12-11e6-8406-4c9b74efdaf2.png ">
Closes https://github.com/facebook/react-native/pull/10252
Differential Revision: D3974983
Pulled By: hramos
fbshipit-source-id: 6b07d446dd972c4c171062134b45bc3850886349
2016-10-05 10:43:43 -07:00
Charles Dick
286b56fbd0
Add configuration tab to aggrow
...
Reviewed By: bnham
Differential Revision: D3759273
fbshipit-source-id: fd09465e19fbd1b377bf8b384f9b0b241bf43288
2016-10-04 03:29:55 -07:00
Charles Dick
0c157bea36
Move aggrow table header into its own component
...
Reviewed By: bnham
Differential Revision: D3759285
fbshipit-source-id: befee1f060992ac8049042e4389d944d13bc3ae7
2016-09-16 03:13:44 -07:00
Charles Dick
8af84c6788
logging to jsc heap capture expand contract
...
Reviewed By: bnham
Differential Revision: D3757560
fbshipit-source-id: 00046797b17c9fa9e37dab597f11d9db7f7bd08a
2016-09-16 02:43:45 -07:00
Charles Dick
d2c333acaf
name functions in JSC cpu profiles
...
Reviewed By: bestander
Differential Revision: D3835094
fbshipit-source-id: 164afb7878dde528ee2573e1d499b5e0911662ed
2016-09-15 07:13:37 -07:00
Charles Dick
e6bec9cb80
Add option to bundle server to generate full sourcemaps from babel
...
Reviewed By: bestander
Differential Revision: D3863894
fbshipit-source-id: a282758e022d403743841bc59277196e6741ed18
2016-09-15 06:58:26 -07:00
aleclarsoniv
fa6191f6ac
Support symlinks-to-symlinks
...
Summary:
In response to [this comment](https://github.com/facebook/react-native/pull/9009#issuecomment-245322397 ).
I could be wrong here, but I think Watchman can't handle symlinks, so we need to make sure symlinks-to-symlinks are handled up front.
Closes https://github.com/facebook/react-native/pull/9792
Differential Revision: D3858349
Pulled By: bestander
fbshipit-source-id: f3a34dae90ed9a7004a03158288db5e1932bfc69
2016-09-15 05:28:34 -07:00
Damien
f4e3e19f8c
Add shorcuts for windows & linux to debugger.html
...
Summary:
Very simple PR to add the shorcuts for windows/linux to the web debuger interface so it's less mac-centric.
**Test plan**: Open the debugger and see the shorcuts for windows/linux/mac
Closes https://github.com/facebook/react-native/pull/9812
Differential Revision: D3862570
fbshipit-source-id: 54605af66b674d176b3cbbb9efcfa93f84fcd552
2016-09-14 02:58:40 -07:00
Philipp von Weitershausen
111ed8d180
Allow rn-cli.config.js to specify the default transformer, again
...
Summary:
Restores feature introduced in #7961 after it's been paved partially by #7899
**Test Plan:** ran example in https://github.com/philikon/ReactNativify against a React Native with and without this patch
Closes https://github.com/facebook/react-native/pull/9799
Differential Revision: D3852601
Pulled By: mkonicek
fbshipit-source-id: fc3c80bdb254145fefa870eea1828b4ef33f9297
2016-09-12 15:14:01 -07:00
Philipp von Weitershausen
4ab455b37d
packager: dedupe symlinks if they point to already covered paths
...
Summary:
If the packager is already watching `/path/to/MyProject`, and it finds symlinks inside `/path/to/MyProject/node_modules` that point to `/path/to/MyProject/path/to/somewhere/else`, there's no need to add the latter to the project roots.
**Test Plan:** replicate an aforementioned project set-up, and verify that only `/path/to/MyProject` is a project root for the packager, while files in `/path/to/MyProject/path/to/somewhere/else` can still be imported so long as they're part of an npm-style package (e.g. `/path/to/MyProject/path/to/somewhere/else/package.json` exists).
Closes https://github.com/facebook/react-native/pull/9819
Differential Revision: D3852591
Pulled By: mkonicek
fbshipit-source-id: 558ab3f835ee3d2bf6174c31595e242992f75601
2016-09-12 15:14:01 -07:00
Charles Dick
84ce9d9aea
add module categorization to jsc heap capture visualization
...
Reviewed By: bnham
Differential Revision: D3757536
fbshipit-source-id: 87e5d605f7490b00bde741dc5dc7a68428a25b50
2016-09-12 03:13:44 -07:00
Charles Dick
73d7f36d8f
refactor how path and react tree are done in jsc heap capture
...
Reviewed By: bnham
Differential Revision: D3757510
fbshipit-source-id: dff0f85586ef910b28c3fedf06a5178a2c2b28b2
2016-09-09 09:13:37 -07:00
Alex Kotliarskyi
7398780357
Exit with error code 11 when port is taken
...
Reviewed By: javache
Differential Revision: D3831703
fbshipit-source-id: ef92cacbc9178b7b661b3a9731dffb97cfc66b7a
2016-09-08 15:58:55 -07:00
Andrew Y. Chen
bbd1e455f3
Show a redbox when scripts fail to load
...
Reviewed By: yungsters
Differential Revision: D3670186
fbshipit-source-id: 1c61b69c74a8f7cc255aa6d7afcdb117205922eb
2016-09-07 13:10:12 -07:00
Charles Dick
c06c1e1786
Add values to JSC heap capture visualizaion
...
Reviewed By: bnham
Differential Revision: D3757492
fbshipit-source-id: 2e311878ca773b7d1ec680a2dc6422633f98a3a7
2016-09-01 17:29:05 -07:00
Charles Dick
a0f55c9bca
Change how values are captured in JSC heap snapshots
...
Reviewed By: dcaspi
Differential Revision: D3757449
fbshipit-source-id: 9952f7ffb9b725ad3e0e3ca0b13b02d2d469bb95
2016-09-01 17:29:05 -07:00
Charles Dick
28768a715f
add keyboard shortcuts to aggrow
...
Differential Revision: D3724598
fbshipit-source-id: e744d710ccb49f67101abcdded17085f6e7c8b23
2016-08-17 11:28:31 -07:00
Lukas Piatkowski
3d7fe3e6d3
Mark in Sampling Profiler when the execution is outside of the VM
...
Differential Revision: D3722907
fbshipit-source-id: c988c3ea2ab33496dc1453e6e54e624d9f295173
2016-08-17 08:28:48 -07:00
Charles Dick
294c70cc63
use string values to get names for JSC heap capture react tree
...
Reviewed By: dcaspi
Differential Revision: D3723800
fbshipit-source-id: a013525f77484dfb8dc39ced81feee42bccba70d
2016-08-17 08:13:49 -07:00
Charles Dick
348a8078bc
dump string values in JSC heap capture
...
Reviewed By: dcaspi
Differential Revision: D3723764
fbshipit-source-id: 06ca770808a94bb8b567bab36c1729f1e696484e
2016-08-17 08:13:49 -07:00
Charles Dick
f2f27d6254
add marked block overhead to JSC heap capture aggrow
...
Reviewed By: bnham
Differential Revision: D3728678
fbshipit-source-id: 2c17003449dddb0ea68d3f6b097fd7704758cf5f
2016-08-17 03:43:34 -07:00
Charles Dick
d54b3b8701
Add react component names to JSC heap capture
...
Differential Revision: D3709253
fbshipit-source-id: dc158d6a096c3e91baeadbaafbf14904493392aa
2016-08-16 13:58:41 -07:00
Charles Dick
1199c5ade9
Add function name, url, line, column to heap capture
...
Reviewed By: bnham
Differential Revision: D3703012
fbshipit-source-id: 8e15deeeabe15da2a87a71c2baf0fa72d5bc6568
2016-08-16 06:59:06 -07:00
Dan Caspi
0cc3b4b079
Fixes to jscProfilerMiddleware
...
Reviewed By: bnham
Differential Revision: D3691098
fbshipit-source-id: dbadda69ff0b6a8d9d349b33c45234ff4f8c3b65
2016-08-10 06:43:51 -07:00
Charles Dick
c43c80bd7c
fix error handling in react native heap capture server middleware
...
Reviewed By: bnham
Differential Revision: D3684092
fbshipit-source-id: 1856fa4c04a173e1df49dfe17ebef09a066447e5
2016-08-09 04:28:53 -07:00
Charles Dick
54f867f0d6
Process heap capture into trace html
...
Reviewed By: bestander
Differential Revision: D3642188
fbshipit-source-id: c9a4699b2a0d60eb5961333dec45941085e19324
2016-08-08 04:28:32 -07:00
Lukas Piatkowski
4e3b484631
Put "file:line" when we can't resolve function name
...
Reviewed By: michalgr
Differential Revision: D3670558
fbshipit-source-id: 2a60babf16ac6e6be77ebb6e76f5179b024a77c6
2016-08-05 06:13:41 -07:00
Kureev Alexey
59a1311c86
Feature/watch symlinks
...
Summary:
see #9009
cc bestander
Closes https://github.com/facebook/react-native/pull/9176
Differential Revision: D3662018
Pulled By: bestander
fbshipit-source-id: a4c03e69e5215377b1edac940f0254a0fd429258
2016-08-03 03:44:57 -07:00
Konstantin Raev
ed89d5ba0d
fixed trunk: wrong way to require a module
...
Summary:
This should fix https://travis-ci.org/facebook/react-native/jobs/149264391
Closes https://github.com/facebook/react-native/pull/9169
Differential Revision: D3657544
Pulled By: javache
fbshipit-source-id: d49ed0355cc5da72d1d8f40dfa03e669f2291db1
2016-08-02 13:13:26 -07:00
Lukas Piatkowski
350b5a2c48
Use packager's source map to resolve function name and clean up dead code in SP
...
Reviewed By: bnham
Differential Revision: D3649501
fbshipit-source-id: 62e13633436c645d9b43eb75c39b4ddcf0458eb3
2016-08-02 11:14:06 -07:00
Lukas Piatkowski
066de9d820
#18 Using the bundle url resolve origin source in jsc profiler middleware
...
Reviewed By: bestander
Differential Revision: D3620292
fbshipit-source-id: e3c54fb30bc65ff1ddd650340a2905a9f0e16231
2016-08-02 11:14:06 -07:00
Lukas Piatkowski
2231b21ed0
#15.1 Extend packager server to receive signals from Sampling Profiler
...
Reviewed By: bestander
Differential Revision: D3606098
fbshipit-source-id: ec55030dd1b3a27f0595650da1ce01fe1ac9116c
2016-08-02 11:14:06 -07:00
androidtrunkagent
1ab4b2a792
Add support for passing in additional assetExts to packager
...
fbshipit-source-id: 42e508e37d960fbeb905a2ea8cb4741dba5c67fc
2016-08-02 10:27:25 -07:00
Konstantin Raev
55300382c6
disable symink finder to fix tests
...
Summary:
cc Kureev
Disabling symlink resolver temporarily because it breaks launchPackager.command.
Waiting for a PR with a fix to enable both
Closes https://github.com/facebook/react-native/pull/9166
Differential Revision: D3655846
Pulled By: matryoshcow
fbshipit-source-id: da0bfc64f5fd9d747db2b97d669fcb98250faf39
2016-08-02 09:43:33 -07:00
Charles Dick
aba87550cc
upload JSC heap capture to bundle server
...
Reviewed By: bestander
Differential Revision: D3642116
fbshipit-source-id: 9626078bb0f087f55d8270c8e0b082c74bd2df9d
2016-08-02 08:13:57 -07:00
Konstantin Raev
7cf4e3665a
Fixed typo in packager middleware
...
Summary:
**Test plan (required)**
Run packager
Closes https://github.com/facebook/react-native/pull/9135
Differential Revision: D3649113
Pulled By: kentaromiura
fbshipit-source-id: db1b1b590f2b1ff50c1e519d4dce10b7c1eec133
2016-08-01 08:13:33 -07:00
Kureev Alexey
5cf7f040a5
Symlink support for packager
...
Summary:
I saw we have quite a few user requests for symlink support...
**Test plan (required)**
1. Create a symlink in `node_modules` (for instance use `npm link`)
2. Run `npm start`
3. Profit!
**Code formatting**
Look around. Match the style of the rest of the codebase. See also the simple [style guide](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#style-guide ).
For more info, see the ["Pull Requests" section of our "Contributing" guidelines](https://github.com/facebook/react-native/blob/master/CONTRIBUTING.md#pull-requests ).
Closes https://github.com/facebook/react-native/pull/9009
Differential Revision: D3648828
Pulled By: matryoshcow
fbshipit-source-id: 99cf313bfa70324ca904fa6919ef112180974e9e
2016-08-01 04:43:36 -07:00
Mike Grabowski
e8b508144f
Merge rnpm cli into react-native
...
Summary:
This is an initial step of rewriting the CLI interface to use `rnpm` one (commander, plugins etc.).
It's scope is to move all existing commands to use rnpm CLI interface, so that we get plugins, flags and our existing ecosystem working out of the box.
<s>This is still WIP and some of the commands are left commented out.</s>
For the `config` of `rnpm` (functions get info about project and dependency), <s>I am thinking we can merge them with</s> we decided to merge it with [`default.config.js`](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e70adb69675786/local-cli/default.config.js#L33 ), so they are available on the `new Config()` [instance](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e70adb69675786/local-cli/cliEntry.js#L59 ) (which means we don't have to change anything and current plugins, like runIOS and runAndroid can just start using it [w/o depending on any extra argument](https://github.com/grabbou/react-native/blob/e57683e420210749a5a6b802b4e
Closes https://github.com/facebook/react-native/pull/7899
Differential Revision: D3613193
Pulled By: bestander
fbshipit-source-id: 09a072f3b21e5239dfcd8da88a205bd28dc5d037
2016-07-30 09:13:46 -07:00