react-native

19,687 Commits 541 Branches 635 Tags

2 Commits

Include renames

Author	SHA1	Message	Date
Janic DuplessisandFacebook Github Bot	686ab49107	Don't restore default values when components unmount (#26978 ) Summary: There are some cases where restoring default values on component unmount is not desirable. For example in react-native-screens we want to keep the native view displayed after react has unmounted them. Restoring default values causes an issue there because it will change props controlled my native animated back to their default value instead of keeping whatever value they had been animated to. Restoring default values is only needed for updates anyway, where removing a prop controlled by native animated need to be reset to its default value since react no longer tracks its value. This splits restoring default values and disconnecting from views in 2 separate native methods, this way we can restore default values only on component update and not on unmount. This takes care of being backwards compatible for JS running with the older native code. ## Changelog [General] [Fixed] - NativeAnimated - Don't restore default values when components unmount Pull Request resolved: https://github.com/facebook/react-native/pull/26978 Test Plan: - Tested in an app using react-native-screens to make sure native views that are kept after their underlying component has been unmount don't change. Also tested in RNTester animated example. - Tested that new JS works with old native code Reviewed By: mmmulani Differential Revision: D18197735 Pulled By: JoshuaGross fbshipit-source-id: 20fa0f31a3edf1bc57ccb03df9d1486aba83edc4	2019-11-04 15:40:09 -08:00
Ramanpreet NaraandFacebook Github Bot	d3ac9fa0c3	Check in OSS NativeModule specs Summary: This diff checks in the output from `fbsource//xplat/js:FBReactNativeSpec-flow-type-android-files` into `react-native-github/ReactAndroid/src/main/java/com/facebook/fbreact/specs/`. To update the codegen output, please run: ``` js1 build oss-native-modules-specs -p android ``` To use the codegen, add the following as a buck dep to your target: ``` fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/fbreact/specs:FBReactNativeSpecAndroid ``` Changelog: [Android][Added] Check in TurboModules codegen Reviewed By: fkgozali Differential Revision: D17990380 fbshipit-source-id: 94895e375311e9360c308dffadf1558a5ff04212	2019-10-18 16:24:09 -07:00

Author

SHA1

Message

Date

Janic DuplessisandFacebook Github Bot

686ab49107

Don't restore default values when components unmount (#26978 )

Summary:
There are some cases where restoring default values on component unmount is not desirable. For example in react-native-screens we want to keep the native view displayed after react has unmounted them. Restoring default values causes an issue there because it will change props controlled my native animated back to their default value instead of keeping whatever value they had been animated to.

Restoring default values is only needed for updates anyway, where removing a prop controlled by native animated need to be reset to its default value since react no longer tracks its value.

This splits restoring default values and disconnecting from views in 2 separate native methods, this way we can restore default values only on component update and not on unmount. This takes care of being backwards compatible for JS running with the older native code.

## Changelog

[General] [Fixed] - NativeAnimated - Don't restore default values when components unmount
Pull Request resolved: https://github.com/facebook/react-native/pull/26978

Test Plan:
- Tested in an app using react-native-screens to make sure native views that are kept after their underlying component has been unmount don't change. Also tested in RNTester animated example.

- Tested that new JS works with old native code

Reviewed By: mmmulani

Differential Revision: D18197735

Pulled By: JoshuaGross

fbshipit-source-id: 20fa0f31a3edf1bc57ccb03df9d1486aba83edc4

2019-11-04 15:40:09 -08:00

Ramanpreet NaraandFacebook Github Bot

d3ac9fa0c3

Check in OSS NativeModule specs

Summary:
This diff checks in the output from `fbsource//xplat/js:FBReactNativeSpec-flow-type-android-files` into `react-native-github/ReactAndroid/src/main/java/com/facebook/fbreact/specs/`.

To update the codegen output, please run:
```
js1 build oss-native-modules-specs -p android
```

To use the codegen, add the following as a buck dep to your target:
```
fbsource//xplat/js/react-native-github/ReactAndroid/src/main/java/com/facebook/fbreact/specs:FBReactNativeSpecAndroid
```

Changelog: [Android][Added] Check in TurboModules codegen

Reviewed By: fkgozali

Differential Revision: D17990380

fbshipit-source-id: 94895e375311e9360c308dffadf1558a5ff04212

2019-10-18 16:24:09 -07:00