Commit Graph

9 Commits

Author SHA1 Message Date
Nicola Corti d56bd115fa Do not attempt to comment on PRs when on forks (#36316)
Summary:
I'm gating this workflow to run only upstream as I'm receiving notifications that it fails on my fork. We don't want to run this workflow on forks at all hence we can add a `if:` there.

## Changelog

[INTERNAL] - Do not attempt to comment on PRs when on forks

Pull Request resolved: https://github.com/facebook/react-native/pull/36316

Test Plan: If Github Actions UI is green, we're good to go

Reviewed By: cipolleschi

Differential Revision: D43657315

Pulled By: cortinico

fbshipit-source-id: 8fb260d142a43375bd9a3b10eac235550a6aecb0
2023-02-28 07:36:06 -08:00
Varun Sharma 3da3d82320 ci: Add GitHub token permissions for workflows (#34122)
Summary:
This PR adds minimum token permissions for the GITHUB_TOKEN using https://github.com/step-security/secure-workflows.

GitHub recommends defining minimum GITHUB_TOKEN permissions for securing GitHub Actions workflows
- https://github.blog/changelog/2021-04-20-github-actions-control-permissions-for-github_token/
- https://docs.github.com/en/actions/security-guides/automatic-token-authentication#modifying-the-permissions-for-the-github_token
- The Open Source Security Foundation (OpenSSF) [Scorecards](https://github.com/ossf/scorecard) treats not setting token permissions as a high-risk issue

This project is part of the top 100 critical projects as per OpenSSF (https://github.com/ossf/wg-securing-critical-projects), so fixing the token permissions to improve security.

Signed-off-by: Varun Sharma <varunsh@stepsecurity.io>

## Changelog
[General] [Security] - Add GitHub token permissions for workflows
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->

Pull Request resolved: https://github.com/facebook/react-native/pull/34122

Test Plan: N/A

Reviewed By: cipolleschi

Differential Revision: D37597988

Pulled By: cortinico

fbshipit-source-id: 2f45914e2202a7b5bf7fa60b019dd12cdcf31952
2022-07-04 03:41:44 -07:00
Gabriel Donadel Dall'Agnol f7a66e6291 ci: Bump actions-apply-version-label to 0.0.3 (#32979)
Summary:
This PR  bumps the `actions-apply-version-label`  version to 0.0.3 in order to fix an issue where we were throwing an error when the identified label does not exist, instead we should just report a warning. This also updates `apply-version-label-issue.yml` to use `actions-apply-version-label` from `react-native-community` as it has been recently transferred to the community

## Changelog

[Internal] [Fixed] - Fix `actions-apply-version-label` error when version label is missing

Pull Request resolved: https://github.com/facebook/react-native/pull/32979

Test Plan:
Open an issue with a missing version label and ran the new action version

https://github.com/gabrieldonadel/actions-apply-version-label/actions/runs/1756805059

Reviewed By: ShikaSD

Differential Revision: D33819052

Pulled By: cortinico

fbshipit-source-id: 49c719e729e3085e78b1c43143c2d41a03e797e4
2022-01-28 06:10:35 -08:00
Gabriel Donadel Dall'Agnol 4f1f42b076 ci: Add github action to apply version label to pre-release issues (#32957)
Summary:
Add workflow to automatically label issues with the `Type: Upgrade Issue` label as `Version: XX` using [actions-apply-version-label](https://github.com/marketplace/actions/apply-version-label-to-issue-with-specific-label) github action.

Closes https://github.com/facebook/react-native/issues/32691

## Changelog

[Internal] [Added] - Add github action to apply version label to pre-release issues

Pull Request resolved: https://github.com/facebook/react-native/pull/32957

Test Plan:
As I don't have admin rights to this repo I merged these same changes  in my fork (https://github.com/gabrieldonadel/react-native/pull/3) and tested this action by opening [an issue](https://github.com/gabrieldonadel/react-native/issues/5) tagged as `pre-release`

https://user-images.githubusercontent.com/11707729/150696182-82381f86-78af-4ba0-a94c-e5780ee54316.mov

## Next steps

Transfer [core-workflow-apply-version-label](https://github.com/gabrieldonadel/core-workflow-apply-version-label) to [react-native-community](https://github.com/react-native-community)

Reviewed By: lunaleaps

Differential Revision: D33744979

Pulled By: cortinico

fbshipit-source-id: c917b62d3aa561d779d6e2c94a7af69cd462b60e
2022-01-25 12:23:38 -08:00
Luna Wei 63ec8efe58 Remove version Github actions for now
Summary: Changelog: [Internal] Remove this workflow for now as there are some errors and we want to revisit this action and move it under react-native-community

Reviewed By: sota000

Differential Revision: D33103444

fbshipit-source-id: c64bb79df8700af110ddbfbfa3d60ac9a849c964
2021-12-14 13:43:25 -08:00
Nicola Corti 6abf8b4f05 Do not report a CI failure if add-version-label-issue is red
Summary:
The `add-version-label-issue` CI is failing if the version label is not found.
That is happening for previous versions of RN where the Labels are missing.

Changelog:
[Internal] [Changed] - Do not report a CI failure if add-version-label-issue is red

Reviewed By: sammy-SC

Differential Revision: D32723953

fbshipit-source-id: 878d2632b3a78311a01363b8f8a9181ae543a253
2021-11-30 09:40:09 -08:00
Lucas Bento e973b3afc2 Bump core-workflow-apply-version-label version (#32565)
Summary:
Fix the issue with the label not being applied correctly to issues.

## Changelog

N/A

Pull Request resolved: https://github.com/facebook/react-native/pull/32565

Reviewed By: cortinico

Differential Revision: D32283554

Pulled By: lunaleaps

fbshipit-source-id: 77de56ef3a3dd9b87d1addc3d6d5deb08817d2d0
2021-11-09 09:30:35 -08:00
Lucas Bento aa515450fe Fix issues with -rc version not being labeled properly (#32522)
Summary:
This PR bumps https://github.com/lucasbento/core-workflow-apply-version-label which fixes the issue with versions having `-rc` not working.

## Changelog

N/A.

Pull Request resolved: https://github.com/facebook/react-native/pull/32522

Reviewed By: yungsters

Differential Revision: D32115258

Pulled By: lunaleaps

fbshipit-source-id: ece8400f223640f8b75141f0e3286888a72c996b
2021-11-03 12:01:42 -07:00
Lucas Bento 60352a9549 Add workflow to create version labels on new releases (#32508)
Summary:
This PR adds the following GitHub actions:

- https://github.com/lucasbento/core-workflow-create-version-label - Create version labels (such as `Version: 0.65.1`) whenever there's a new release;
- https://github.com/lucasbento/core-workflow-apply-version-label - Apply a version label to opened/edited issues based on the version mentioned on the issue body.

## Changelog

N/A.

## Few things to keep in mind

- A label named "Version: unspecified" must be created;
- The GitHub action to create labels will only run when there's a new release or if one is edited, it will then create all the other labels bases on the previous releases until it encounters one that already exists.

 ---

Example of issue with version label: https://github.com/lucasbento/test-issue-forms/issues/4

Pull Request resolved: https://github.com/facebook/react-native/pull/32508

Reviewed By: cortinico

Differential Revision: D32055682

Pulled By: lunaleaps

fbshipit-source-id: 04d3e942eb1f71b3bc1d5a643b0156c35ef5f00b
2021-11-01 11:41:19 -07:00