react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Logan Daniels	91f139b941	xplat/js/react-native-github Reviewed By: panagosg7 Differential Revision: D16657770 fbshipit-source-id: 4e260842c838a35317515044c54ccf55a083da33	2019-08-09 10:11:15 -07:00
Rubén Norte	f9ecce7440	Create RootTagContext and provide it in AppContainer Summary: We should remove all usages of React's legacy context API because it'll be removed from React at some point, it prevents some performance optimizations in updates and can cause conflicts between different context providers (like mixins). This creates a new Context for `rootTag` (this granularity is intentional) so users that are consuming it via the legacy context API can start migrating away from it. I didn't create a more generic context (like ReactRootContext, ReactApplicationContext) because having a more granular context makes it easier to track and remove it if we want to, and prevents re-rendering when users only care about certain values. Reviewed By: rickhanlonii, cpojer Differential Revision: D14941918 fbshipit-source-id: 7ceea62727d10a591367b7ed7c447309b286758d	2019-06-26 10:05:31 -07:00

Author

SHA1

Message

Date

Logan Daniels

91f139b941

xplat/js/react-native-github

Reviewed By: panagosg7

Differential Revision: D16657770

fbshipit-source-id: 4e260842c838a35317515044c54ccf55a083da33

2019-08-09 10:11:15 -07:00

Rubén Norte

f9ecce7440

Create RootTagContext and provide it in AppContainer

Summary:
We should remove all usages of React's legacy context API because it'll be removed from React at some point, it prevents some performance optimizations in updates and can cause conflicts between different context providers (like mixins).

This creates a new Context for `rootTag` (this granularity is intentional) so users that are consuming it via the legacy context API can start migrating away from it.

I didn't create a more generic context (like ReactRootContext, ReactApplicationContext) because having a more granular context makes it easier to track and remove it if we want to, and prevents re-rendering when users only care about certain values.

Reviewed By: rickhanlonii, cpojer

Differential Revision: D14941918

fbshipit-source-id: 7ceea62727d10a591367b7ed7c447309b286758d

2019-06-26 10:05:31 -07:00

2 Commits