Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
17,943 Commits 541 Branches 635 Tags
16eccf304e607684a7bc9be77ac9e59f6894dea8
Commit Graph

2 Commits

Author SHA1 Message Date
Logan Daniels b6333f79e1 Final fixes and seal xplat/js/react-native-github 
Reviewed By: panagosg7

Differential Revision: D16946423

fbshipit-source-id: 89ca82c955e99a23a14984d51f3c97346c363afd
 2019-08-23 08:45:11 -07:00
Peter Argany 30c1196d7d Convert RCTImageLoader to TurboModules [4/N] 
Summary:
This diff adds a JS spec for RCTImageLoader, and conforms to it in ObjC++. Since RCTImageLoader isn't called from JS, the js spec is empty. Since `/CoreModules/` is the only dir in OSS which supports TM, move the ObjC++ impl there.

The change in `NativeExceptionsManager.js` fixes a weird bug I was hitting in codegen, where the codegen cpp file wouldn't compile due to unused variable.

Reviewed By: JoshuaGross

Differential Revision: D16495674

fbshipit-source-id: 191897b87730a6b0b96022eedc6412551fae04a6
 2019-08-15 11:33:37 -07:00