Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39823
In this diff I'm refactoring BaseJavaModule and ReactContextBaseJavaModule to simplify class hierarchy.
ReactContextBaseJavaModule will be deprecated in the new architecture
bypass-github-export-checks
Reviewed By: cortinico
Differential Revision: D49930340
fbshipit-source-id: 602b5f3d2d926956c52b96b28815dae687fdad87
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/40739
Adding support for grouped accessibility focus on switch. This is when the switch itself shouldn't be directly focusable. Instead, the parent element should be focusable, including announcing the switch role and state changes, e.g. "on" and "off".
Fix this issue in a couple ways:
1. Make sure to set the proper role for switch in FbReactSwitchCompat.java.
2. Set the state description in SwitchCompat.java so that uses the correct announcement of "off" and "on" instead of "checked" and "unchecked".
Reviewed By: blavalla
Differential Revision: D50068169
fbshipit-source-id: 0c4133377f7a29da9cadb730399bdbedd58c26ae
Summary:
The current comments explaining the various StyleSheet methods and are misleading, often referencing the removed `StyleSheetRegistry` and old behavior related to it.
## Changelog:
Per https://github.com/facebook/react-native-website/pull/3872/files, updates comments to reflect the fact that the `StyleSheetRegistry` has been removed.
[INTERNAL] [REMOVED] - Removed comment references to `StyleSheetRegistry` and style sheet `ID`s
Pull Request resolved: https://github.com/facebook/react-native/pull/39990
Test Plan: `console.log(StyleSheet.create({ testClass: { color: "red" } }))` outputs `{ testClass: { color: "red" } }`
Reviewed By: NickGerleman
Differential Revision: D50076737
Pulled By: javache
fbshipit-source-id: edc3c9f63f9963c17b1a2c1a898badf1b87183e4
Summary:
When upgrading ESLint to latest, the RN plugin fails to run because of a deprecated API:
```
Error: Parsing error: DeprecationError: 'originalKeywordKind' has been deprecated since v5.0.0 and can no longer be used. Use 'identifierToKeywordKind(identifier)' instead.
```
## Changelog:
- [GENERAL] [FIXED] Updated ESLint version to fix `originalKeywordKind` deprecation error
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
Pull Request resolved: https://github.com/facebook/react-native/pull/39654
Test Plan: Run CI and Lint
Reviewed By: NickGerleman
Differential Revision: D49634978
Pulled By: robhogan
fbshipit-source-id: f65f0d56053acf1c877fe0f368a7f4e13c8c57d1
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/40233
changelog: [internal]
This is a reland of D49355595 and D49358327.
the problem was using two different hashing functions in place where they must be the same.
Reviewed By: javache
Differential Revision: D50020135
fbshipit-source-id: 1cec6bc385077d371b024a0fb5d9c64ba1f6269c
Summary:
It seems this method is not referenced by anything anymore. I think https://github.com/facebook/react-native/pull/35017 made it redundant. Let's remove it?
I can also do the whole "Deprecate for one version, remove in the next" since this was publicly exported.
## Changelog:
[iOS] [REMOVED] - Remove RCTGetMultiplierForContentSizeCategory
Pull Request resolved: https://github.com/facebook/react-native/pull/39617
Test Plan: CI should pass
Reviewed By: dmytrorykun
Differential Revision: D49618166
Pulled By: cipolleschi
fbshipit-source-id: fb72e961d2a1eb9977944fea3ee4deeab46b946b
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39955
Align `RCTRequired` to the rest of the targets in `react-native-github/packages/react-native/Libraries`.
Changelog: [Internal]
Reviewed By: cipolleschi
Differential Revision: D50009827
fbshipit-source-id: c2ec9eb9e5fb081a2e2e8f53d33bc21dcf95b279
Summary:
X-link: https://github.com/facebook/yoga/pull/1411
Pull Request resolved: https://github.com/facebook/react-native/pull/39796
X-link: https://github.com/facebook/yoga/pull/1414
GCC flags that `isUndefined()` is not declared `constexpr` but that `unwrapOrDefault()` is. `std::isnan` is not constexpr until C++ 23 (because we cannot have nice things), so I made `yoga::isUndefined()` constexpr, using the same code `std::isnan()` boils down to. I then made `FloatOptional` depend on `Comparison.h` (instead of the other way around), so we can use it.
Note that the use of the `std::floating_point` concept here requires the libc++ bump in the previous diff in the stack.
Reviewed By: yungsters
Differential Revision: D49896837
fbshipit-source-id: 61e2bbbfedecffd007a12d42d998e43d3cf5119c
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39959
We're still accessing project.buildDir which will be removed in Gradle 9.0
I'm cleaning it up here.
Changelog:
[Internal] [Changed] - Fix compilation warnings introduced by Gradle 8.4
Reviewed By: yungsters
Differential Revision: D50016573
fbshipit-source-id: de7a725f61b503f08991ebf85b9a002cefab221a
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39960
This is our usual round of bumps just after the branch cut.
Changelog:
[Android] [Changed] - Bump Gradle to 8.4
Reviewed By: yungsters
Differential Revision: D50016574
fbshipit-source-id: 781eb906f6b12f76f673e38bdcf099c9b7cefade
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39958
I'm reverting the change of AGP from 8.2 beta to 8.1 as we don't need 8.2
Using 8.2 beta forces us to use Android Studio beta, which is actually not necessary.
Changelog:
[Android] [Changed] - Bump AGP to 8.1.2
Reviewed By: yungsters
Differential Revision: D50016572
fbshipit-source-id: 6c36df0568a1f867dac3c335abbaabb990e55491
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39953
This was added to support Fabric codegen, but is no longer referenced.
Changelog: [Internal]
Reviewed By: rubennorte
Differential Revision: D50011688
fbshipit-source-id: 30867f719dbcbc447e10226787ce7407503a1c7d
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39951
## Changelog:
[Internal] -
This makes PerformanceObserver API more robust in regards of telling which exactly types of the performance entries are supported.
At this point, we either tell that we support mark/measure/event ones on the New Architecture, or none otherwise. The source of truth of this information should be on the native side.
Reviewed By: rubennorte
Differential Revision: D50010982
fbshipit-source-id: ad7bce279a58eac232b7c26f8d8c2bd1cde51e3c
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39833
Reland of D49642047 which got reverted because of a CI infra error.
---
It's currently possible for RN to crash the dev server by sending down an exceptionally large CDP response/event. Instead of making assumptions on the protocol spoken over the proxy, let's assume clients on either side of the proxy can be trusted to be well behaved (and to degrade gracefully when a large message is encountered).
Changelog: [General][Fixed] JS debugging: prevent dev server crash when a large CDP payload is returned from the device
Reviewed By: huntie
Differential Revision: D49955025
fbshipit-source-id: aa5b8b55c885e26dd5b8170660603173cfe54de0
Summary:
On Android 13 Devices, we are seeing `NullPointerException`, which should be handled with this
## Changelog:
[ANDROID] [FIXED] - Handle Crash for onRequestPermissionsResult
Pull Request resolved: https://github.com/facebook/react-native/pull/39715
Reviewed By: NickGerleman
Differential Revision: D49965583
Pulled By: javache
fbshipit-source-id: 8a39049675510f9cca8141c893d93fdb04ba0e25
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39613
In this diff I'm removing TurboModuleManager from ReactHostDelegate. The goal is to stop exposing TurboModuleManager and TurboModuleRegistry
Developers should use ReactContext.getNativeModule to retrieve native modules instead of TurboModuleManager or TurboModuleRegistry
bypass-github-export-checks
changelog: [internal] internal
Reviewed By: cortinico
Differential Revision: D49483636
fbshipit-source-id: 6c2e29d83700bebf05475875edad6d5c0877d9df
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of UnobservedTaskException
Reviewed By: cortinico
Differential Revision: D49803272
fbshipit-source-id: cbd9bd285ba4c2ce5b3e77885da37f125517fac9
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
bypass-github-export-checks
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of ExecutorException
Reviewed By: cortinico
Differential Revision: D49803280
fbshipit-source-id: 140b5bcd41b1a16ed84196021305a4d27f8cc24a
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of Capture
Reviewed By: cortinico
Differential Revision: D49803273
fbshipit-source-id: 5c57f7865b4d2b58b3a8ffcde8c424c0a65ee7d2
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of CancellationTokenRegistration
Reviewed By: arushikesarwani94
Differential Revision: D49803300
fbshipit-source-id: c7992bdaa0994c1035894a15af1e9d0bf7ebd204
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of AggregateException
Reviewed By: arushikesarwani94
Differential Revision: D49803279
fbshipit-source-id: f3b6488789485ed87fd724f950eb0c2e34c38cc6
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of ProgressiveStringDecoder
Reviewed By: arushikesarwani94
Differential Revision: D49803293
fbshipit-source-id: 93d28f579d51e220c46e74d264f84c5dce743e72
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of ProgressRequestBody
Reviewed By: arushikesarwani94
Differential Revision: D49803278
fbshipit-source-id: d049b97dbb0124274830a14d18c30d0574f04532
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of HeaderUtil
Reviewed By: arushikesarwani94
Differential Revision: D49803294
fbshipit-source-id: 01ec431cf2addc8c0df0d729f5cc15c0334b4762
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of CountingOutputStream
Reviewed By: arushikesarwani94
Differential Revision: D49803284
fbshipit-source-id: fb411c6f6335c0bf4b42f8b87c4cdb3e01fc6e7c
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
bypass-github-export-checks
changelog: [Android][Changed] Reducing visibility of DidJSUpdateUiDuringFrameDetector
Reviewed By: arushikesarwani94
Differential Revision: D49803285
fbshipit-source-id: e9312a7fbf86ae75bdc4b50922676ab8d1140be7
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of AnimationsDebugModule
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803302
fbshipit-source-id: 4c5f51d44c0d21e024d1a411fa425302372456eb
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of NoRetryPolicy
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803301
fbshipit-source-id: 47d350663470e7d6d27f5bfcf9c5576f9ad41987
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of SendAccessibilityEvent
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803277
fbshipit-source-id: 24a55ae7f7ca1218aad2db95fee87d316f0d073f
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of ViewHierarchyUtil
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803291
fbshipit-source-id: 929608f71ce3c5af842616add21ac9077239e109
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of RedBoxDialogSurfaceDelegate
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803299
fbshipit-source-id: d3d5a6a61c4541503552c27bf940531c2e27f5ce
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of MultipartStreamReader
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803274
fbshipit-source-id: 7bcbf032b9ce59cd624e782ee81f69dad747bf8e
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of LogBoxDialogSurfaceDelegate
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803282
fbshipit-source-id: 51594dc7d2eda47f4673874cf83d77a1a6d8007b
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of LogBoxDialog
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803290
fbshipit-source-id: 17a301fd758bf3fcfb880b2647a7fd53bf7781a7
Summary:
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of FpsView
bypass-github-export-checks
Reviewed By: arushikesarwani94
Differential Revision: D49803286
fbshipit-source-id: 2c4b7349de755d02a29cfdb97820b7af07709528
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39762
In an attempt to reduce footprint of React Native Android public APIs we are reducing visibility of classes and interfaces that are not meant to be used publicly OR are public but have no usages.
As part of our analysis, which involved looking for usages inside the Meta codebase and code search in OSS, we've detected that this class/interface is public but it's not used from other packages.
If you are using this class or interface please comment in this PR and we will restate the public access.
changelog: [Android][Changed] Reducing visibility of UIManagerProvider
bypass-github-export-checks
Reviewed By: cortinico
Differential Revision: D49803268
fbshipit-source-id: 8bc261115beae8fe0666ed95b65b01c1772a5d15
David Vacca
Carmen Krol
Arushi Kesarwani
Alec Marcus
Chiara Mooney
zhongwuzw
Marc Rousavy
Samuel Susla
Saad Najmi
Dmitry Rykun
Fabrizio Cucci
Nick Gerleman
Nicola Corti
Luna Wei
Pieter De Baets
Ruslan Shestopalyuk
Moti Zilberman
Subramanya Chakravarthy
Pieter Vanderwerff
Nishan