6b354155ed
Replace $FlowFixMe(Props|State|Empty) with just $FlowFixMe ( #53002 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/53002
Changelog: [Internal]
Reviewed By: marcoww6
Differential Revision: D79524515
fbshipit-source-id: 18b96538a62c7ae5912b1e89d2b50c1420c7eaf5
2025-08-04 11:43:00 -07:00
23c8787fe2
Add annotations to fix future errors after fix for unsound array types ( #52691 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/52691
Unannotated array literals are unsound in Flow right now. This diff adds in annotations and makes a few things readonly, to reduce future errors.
Changelog: [Internal]
Reviewed By: marcoww6
Differential Revision: D78519638
fbshipit-source-id: d98a7668ecf97bcc87dcb3fad25ade736d885d9a
2025-07-17 17:30:43 -07:00
1977dd6596
RN: Sort Pragmas in Headers ( #51554 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51554
Sorts pragma directives file headers in React Native.
Changelog:
[Internal]
Reviewed By: SamChou19815
Differential Revision: D75264593
fbshipit-source-id: 9e4b253dd0fc94dc2fc469d7114b93a8aae305f4
2025-05-22 21:18:53 -07:00
6d5dde6393
pre-suppress errors for natural_inference.local_primitive_literals=partial in fbsource ( #50380 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/50380
Pre-suppresses errors in xplat/js and arvr/js for phase 1 of Natural Inference for Primitive Literals
See https://fb.workplace.com/groups/floweng/permalink/28092444257044156/
Reviewed By: gkz
Differential Revision: D72088386
fbshipit-source-id: 0827822199cb31a80afbca2a16f74aea4b6c4957
2025-03-28 20:35:51 -07:00
f36bfe5dfa
Remove redundant {||} syntax ( #48686 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/48686
Changelog:
[Internal] - Removed redundant `{||}` syntax
Reviewed By: javache
Differential Revision: D68205038
fbshipit-source-id: f7d3271142b6443a5859c3b668b7aebd3ce3ef3f
2025-01-15 07:07:01 -08:00
09682b5109
Fix dark mode text ( #46898 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/46898
Replaces *many* `Text` component usages with `RNTesterText`: a thin wrapper around `Text` that applies color based on the color scheme chosen by the user. It makes text legible for dark mode across 41 different example files. This changes intentionally do not touch a few larger component sites that expand beyond RNTester, like `Animated` and `NewAppScreen`
Changelog: [Internal]
Reviewed By: rshest
Differential Revision: D64053464
fbshipit-source-id: 9516fef2afe1b364eb38e85e3a2dbb5c434e44db
2024-10-10 11:02:18 -07:00
5b96e90f77
Replace React.Element<any> and unnecessarily specific React.Element with React.MixedElement ( #45923 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/45923
Changelog: [Internal]
Reviewed By: gkz
Differential Revision: D60872182
fbshipit-source-id: b81fb43968c52cbfdb4a9fa57f1175aabc2a3939
2024-08-06 21:33:08 -07:00
d6e0bc714a
Enable lint/sort-imports everywhere ( #41334 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41334
TSIA.
Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D51025812
fbshipit-source-id: e10d437be775a6b80946483aa96460f34927f870
2023-11-06 12:59:38 -08:00
ee3d3c248d
Add missing class annotations xplat/js
...
Reviewed By: SamChou19815
Differential Revision: D38373443
fbshipit-source-id: 1222c4845ebd6b72bd6f54af1a27cf8542dd883a
2022-08-03 12:43:58 -07:00
8bd3edec88
Update copyright headers from Facebook to Meta
...
Reviewed By: aaronabramov
Differential Revision: D33367752
fbshipit-source-id: 4ce94d184485e5ee0a62cf67ad2d3ba16e285c8f
2021-12-30 15:11:21 -08:00
148c98ec80
RN: Resolve Outstanding ESLint Warnings
...
Summary:
Resolves outstanding ESLint warnings in React Native.
Changelog:
[Internal]
Reviewed By: lunaleaps
Differential Revision: D32291912
fbshipit-source-id: 61337d5a5a0e6ed55f732675e029f4b76d850af9
2021-11-09 21:46:21 -08:00
456cf3db14
Fix ReactSwitch for non RippleDrawable backgrounds ( #32468 )
...
Summary:
ReactSwitch component is crashing on Android when it is initialised with both a backgroundColor and thumbColor, `style={{ backgroundColor: "anyColor" }} thumbColor="anyColor"`, due to IllegalCastException.
When setting a background color, BaseViewManagerDelegate is calling `setBackgroundColor` which replaces the background drawable with a ColorDrawale, hence [this line](https://github.com/facebook/react-native/blob/72ea0e111fccd99456abf3f974439432145585e3/ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitch.java#L68 ) fails.
Instead, given the ripple effect needs to be preserved, one should initialise a RippleDrawable using the current background drawable and set it as the background of the switch.
Given the RippleDrawable should be preserved, overriding the `setBackgroundColor` seemed the sensible thing to do.
## Changelog
[Android] [Fixed] - Fix crash when a Switch is initialised with both backgroundColor and thumbColor.
Pull Request resolved: https://github.com/facebook/react-native/pull/32468
Test Plan:
### Setup:
Initialise an empty React Native project. Add a switch component:
`<Switch
style={{backgroundColor: 'red'}}
thumbColor={'https://github.com/facebook/react-native/issues/356 '}
/>`
Run the project `yarn android`
### Current state (RN 65+):
Red screen will show highlighting an IllegalCastException.
<img src="https://user-images.githubusercontent.com/4354327/138616661-3ba1370c-6a2b-48c2-ba70-b99415a4256f.png " width="200"/>
### With fix:
- The component is expected to have a red background.
- When pressed a ripple effect shows inside the backgrounds bounding box.
- Business as usual otherwise.
`backgroundColor` with `thumbColor`:
Just `thumbColor`:
Reviewed By: ShikaSD
Differential Revision: D31895690
Pulled By: cortinico
fbshipit-source-id: 60af16de7db61440ccfbf11d67a3d945dd90b562
2021-10-26 11:21:05 -07:00
c9c14ef687
Add switch example ( #30611 )
...
Summary:
Add examples for Switch component in RN Tester app for:
- ios_backgroundColor
- onChange
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[General] [Added] - Added examples to Switch component
Pull Request resolved: https://github.com/facebook/react-native/pull/30611
Test Plan: 
Reviewed By: lunaleaps
Differential Revision: D25680480
Pulled By: sota000
fbshipit-source-id: 91202a0d8699554b0535f1a91875fd9fc664d54d
2021-09-29 14:50:14 -07:00
cb028ee69c
Add e2e tests for RNTester examples and relevant testIDs
...
Summary:
Changelog:
[Internal] - Add testIDs to RNTester examples
Reviewed By: nadiia
Differential Revision: D27374322
fbshipit-source-id: 62a63f6f454c21bf98b328275d35776d677a9962
2021-04-02 16:57:10 -07:00
d1f09f7390
Add Switch Test Component and more testIDs
...
Summary:
Changelog:
[Internal] - Add more testIDs to SwitchExample
Reviewed By: kacieb
Differential Revision: D27371058
fbshipit-source-id: d2d90923c2c07cd86fd9aa965339dadf43f8fb5f
2021-03-29 18:34:30 -07:00
1270873ed6
RNTester UI Redesign ( #29685 )
...
Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.
This list is not exhaustive.
- The initial App screen is redesigned.
- A bottom Navbar has been added.
- Filter pills are added.
- The list card UI is updated.
- The example page UI is updated.
- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.
- Bookmarking functionality is added.
- The documentation URL is added to the example page.
- RNTester doesn't lose its state on a hard refresh (even on iOS).
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png " />
Pull Request resolved: https://github.com/facebook/react-native/pull/29685
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
{F302717939}
Note: this failed **before** this diff too:
{F302745716}
Reviewed By: mdvacca, cpojer
Differential Revision: D23240434
fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
Co-authored-by: agarwalmanya <manya18ag@gmail.com >
Co-authored-by: chirag-singhal <csinghal208@gmail.com >
Co-authored-by: Ansh Godha <ag759@cornell.edu >
Co-authored-by: Yash Kumar Verma <yk.verma2000@gmail.com >
Co-authored-by: Sanskar Jethi <sansyrox@gmail.com >
Co-authored-by: Aniketh Saha <anik220798@gmail.com >
Co-authored-by: Xtremilicious <nilarjundas@outlook.com >
Co-authored-by: Jani Evakallio <jani.evakallio@gmail.com >
2020-08-26 08:45:57 -07:00
63992c0b96
Migrating RNTester to Packages Directory ( #29567 )
...
Summary:
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
This PR aims to migrate the RNTester App to `packages` directory. But is currently, open to inspect the CI issues and resolve the merge conflicts.
Currently done
- Working on iOS
- Working on Android
- Detox Tests working on iOS
Need to work on
- Errors generated by the CI builds
[General] [Changed] - Migrated the RNTester App to the packages directory.
Pull Request resolved: https://github.com/facebook/react-native/pull/29567
Test Plan: It runs on both ios and android for now and the detox iOS builds are working.
Reviewed By: cpojer
Differential Revision: D23034761
Pulled By: rickhanlonii
fbshipit-source-id: e04bb06e1c7ef15d340206090d1575a871b9e6f5
2020-08-19 17:57:08 -07:00
Sam Zhou
Tim Yung
Panos Vekris
Dawid Małecki
Peter Abbondanzo
Moti Zilberman
Pieter Vanderwerff
Andres Suarez
Tim Yung
Stefanos Markidis
Su Min Kim
Luna Wei
Ankit Tiwari
stealthanthrax
