Sam Zhou
23c8787fe2
Add annotations to fix future errors after fix for unsound array types ( #52691 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/52691
Unannotated array literals are unsound in Flow right now. This diff adds in annotations and makes a few things readonly, to reduce future errors.
Changelog: [Internal]
Reviewed By: marcoww6
Differential Revision: D78519638
fbshipit-source-id: d98a7668ecf97bcc87dcb3fad25ade736d885d9a
2025-07-17 17:30:43 -07:00
Tim Yung
00108a1ac3
RN: Prefer Destructured Import for useState ( #51403 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/51403
Prefers using this as a destructured import instead of as a member expression of `React`.
Changelog:
[Internal]
Reviewed By: SamChou19815
Differential Revision: D74891875
fbshipit-source-id: 981e85b5da84950c9e66e8d6b6496019e536711d
2025-05-16 16:33:18 -07:00
Mateo Guzmán
e39776b1b8
Fix Alert and SafeAreaView examples in dark mode ( #48752 )
...
Summary:
Fix Alert and SafeAreaView examples in dark mode. Converting also SafeAreaView examples into functional components
## Changelog:
[INTERNAL] - Fix Alert and SafeAreaView examples in dark mode
Pull Request resolved: https://github.com/facebook/react-native/pull/48752
Test Plan:
<details>
<summary>Screenshots</summary>
| After | Before |
|--------|-------|
|  |  |
|  |  |
</details>
Reviewed By: cortinico
Differential Revision: D68322518
Pulled By: rshest
fbshipit-source-id: 9f153862efff7ef1e834bac9843f4042dbefbd1b
2025-01-17 06:20:53 -08:00
Dawid Małecki
f36bfe5dfa
Remove redundant {||} syntax ( #48686 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/48686
Changelog:
[Internal] - Removed redundant `{||}` syntax
Reviewed By: javache
Differential Revision: D68205038
fbshipit-source-id: f7d3271142b6443a5859c3b668b7aebd3ce3ef3f
2025-01-15 07:07:01 -08:00
Moti Zilberman
d6e0bc714a
Enable lint/sort-imports everywhere ( #41334 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41334
TSIA.
Changelog: [Internal]
Reviewed By: robhogan
Differential Revision: D51025812
fbshipit-source-id: e10d437be775a6b80946483aa96460f34927f870
2023-11-06 12:59:38 -08:00
Pieter Vanderwerff
ee3d3c248d
Add missing class annotations xplat/js
...
Reviewed By: SamChou19815
Differential Revision: D38373443
fbshipit-source-id: 1222c4845ebd6b72bd6f54af1a27cf8542dd883a
2022-08-03 12:43:58 -07:00
Pieter Vanderwerff
e7a4dbcefc
Add LTI annotations to function params in xplat/js [1/2]
...
Summary: Add annotations to function parameters required for Flow's Local Type Inference project. This codemod prepares the codebase to match Flow's new typechecking algorithm. The new algorithm will make Flow more reliable and predicatable.
Reviewed By: evanyeung
Differential Revision: D37353648
fbshipit-source-id: e5a0c685ced85a8ff353d578b373f836b376bb28
2022-06-22 21:36:52 -07:00
Ken Tominaga
c73e021a4b
Remove iOS 11 deprecation warnings around SafeArea ( #32851 )
...
Summary:
We don't have to check or emulate the safe area for iOS 11 above. I deleted the unnecessary check for the safe area.
This is a continuation pull request of these iOS 11 availability check.
* [Remove iOS 11 version check by ken0nek · Pull Request https://github.com/facebook/react-native/issues/32151 · facebook/react-native](https://github.com/facebook/react-native/pull/32151 )
* [Remove iOS 11 availability check by ken0nek · Pull Request https://github.com/facebook/react-native/issues/32488 · facebook/react-native](https://github.com/facebook/react-native/pull/32488 )
-----
- Stop using layout guide (`topLayoutGuide`, `bottomLayoutGuide`)
- Refactor `RCTSafeAreaView`
- Delete `emulateUnlessSupported` property
Docs PR: https://github.com/facebook/react-native-website/pull/2919
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
[iOS] [Removed] - Remove `emulateUnlessSupported`
Pull Request resolved: https://github.com/facebook/react-native/pull/32851
Reviewed By: philIip, sammy-SC
Differential Revision: D33586023
Pulled By: cortinico
fbshipit-source-id: 75fc1037141f71d9340c7b875a6bf86f9cfd6a02
2022-05-16 09:27:43 -07:00
Pieter Vanderwerff
83ab3615c5
Land suppressions ahead of 0.174.1 release [v2]
...
Summary: Changelog: [Internal]
Reviewed By: mroch
Differential Revision: D35035872
fbshipit-source-id: 74daf0685e976459119061a3fca467277f0dc4ac
2022-03-22 11:42:16 -07:00
Abishek Sethuraman
ecc63daf4b
Revert D35016384: Land suppressions ahead of 0.174.1 release
...
Differential Revision:
D35016384 (https://github.com/facebook/react-native/commit/2fab97fde50624b22142e5b3aed9c9da18474aba )
Original commit changeset: 78ab1b4822c0
Original Phabricator Diff: D35016384 (https://github.com/facebook/react-native/commit/2fab97fde50624b22142e5b3aed9c9da18474aba )
fbshipit-source-id: 82d9672798fdb77313a35be40d0c0aebb0cace64
2022-03-21 15:24:39 -07:00
Pieter Vanderwerff
2fab97fde5
Land suppressions ahead of 0.174.1 release
...
Summary: Changelog: [Internal]
Reviewed By: samwgoldman
Differential Revision: D35016384
fbshipit-source-id: 78ab1b4822c0a3aeab63d615b81b6063a883fe54
2022-03-21 14:24:38 -07:00
Andres Suarez
8bd3edec88
Update copyright headers from Facebook to Meta
...
Reviewed By: aaronabramov
Differential Revision: D33367752
fbshipit-source-id: 4ce94d184485e5ee0a62cf67ad2d3ba16e285c8f
2021-12-30 15:11:21 -08:00
Tim Yung
77ecc7ede1
JS: Format with Prettier v2.4.1 [3/n]
...
Summary:
Changelog:
[General][Internal]
Reviewed By: zertosh
Differential Revision: D31883447
fbshipit-source-id: cbbf85e4bf935096d242336f41bf0cc5d6f92359
2021-11-02 22:14:16 -07:00
Ankit Tiwari
1270873ed6
RNTester UI Redesign ( #29685 )
...
Summary:
This Pull request adds the UI changes to the RNTester app as discussed in the MLH Fellowship.
This list is not exhaustive.
- The initial App screen is redesigned.
- A bottom Navbar has been added.
- Filter pills are added.
- The list card UI is updated.
- The example page UI is updated.
- Recently Viewed Sections are added. It shows the last 5 recently viewed components/APIs.
- Bookmarking functionality is added.
- The documentation URL is added to the example page.
- RNTester doesn't lose its state on a hard refresh (even on iOS).
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530113-20346180-e192-11ea-8ef6-789fa25b402b.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530112-20346180-e192-11ea-9539-706b540fcc5f.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530100-1d397100-e192-11ea-8836-b88070643233.png " />
<img width="373" src="https://user-images.githubusercontent.com/22813027/90530110-1f9bcb00-e192-11ea-936b-64ee75fa4289.png " />
Pull Request resolved: https://github.com/facebook/react-native/pull/29685
Test Plan:
Imported from GitHub, without a `Test Plan:` line.
{F302717939}
Note: this failed **before** this diff too:
{F302745716}
Reviewed By: mdvacca, cpojer
Differential Revision: D23240434
fbshipit-source-id: 65e2766a6a097eca0e0d0fda8dadf6871e9276c2
Co-authored-by: agarwalmanya <manya18ag@gmail.com >
Co-authored-by: chirag-singhal <csinghal208@gmail.com >
Co-authored-by: Ansh Godha <ag759@cornell.edu >
Co-authored-by: Yash Kumar Verma <yk.verma2000@gmail.com >
Co-authored-by: Sanskar Jethi <sansyrox@gmail.com >
Co-authored-by: Aniketh Saha <anik220798@gmail.com >
Co-authored-by: Xtremilicious <nilarjundas@outlook.com >
Co-authored-by: Jani Evakallio <jani.evakallio@gmail.com >
2020-08-26 08:45:57 -07:00
stealthanthrax
63992c0b96
Migrating RNTester to Packages Directory ( #29567 )
...
Summary:
## Changelog
<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://github.com/facebook/react-native/wiki/Changelog
-->
This PR aims to migrate the RNTester App to `packages` directory. But is currently, open to inspect the CI issues and resolve the merge conflicts.
Currently done
- Working on iOS
- Working on Android
- Detox Tests working on iOS
Need to work on
- Errors generated by the CI builds
[General] [Changed] - Migrated the RNTester App to the packages directory.
Pull Request resolved: https://github.com/facebook/react-native/pull/29567
Test Plan: It runs on both ios and android for now and the detox iOS builds are working.
Reviewed By: cpojer
Differential Revision: D23034761
Pulled By: rickhanlonii
fbshipit-source-id: e04bb06e1c7ef15d340206090d1575a871b9e6f5
2020-08-19 17:57:08 -07:00