Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,772 Commits 541 Branches 635 Tags
0.54-stable
Commit Graph
11 Commits
Author SHA1 Message Date
Mike Grabowski 56a2d6d720 [0.54.4] Bump version numbers 2018-03-28 19:09:37 +02:00
Mike Grabowski 69c277051e [0.54.3] Bump version numbers 2018-03-23 10:27:08 +01:00
Mike Grabowski 9a3cad4d89 [0.54.2] Bump version numbers 2018-03-12 22:17:00 +01:00
Mike Grabowski 2d57335fa7 [0.54.1] Bump version numbers 2018-03-09 18:20:10 +01:00
Mike Grabowski 815a07c77b [0.54.0] Bump version numbers 2018-03-01 18:01:19 +01:00
Mike Grabowski 67e67ec83c [0.54.0-rc.4] Bump version numbers 2018-02-27 09:58:06 +01:00
Mike Grabowski 21dd3dd296 [0.54.0-rc.3] Bump version numbers 2018-02-13 18:11:48 +01:00
Hector Ramos 49e35bd939 [0.54.0-rc.0] Bump version numbers 2018-02-12 12:19:05 -08:00
Mike Grabowski 829f675b8b [0.54.0-rc.2] Bump version numbers 2018-02-12 17:38:28 +01:00
Mike Grabowski 294d95a236 [0.54.0-rc.0] Bump version numbers 2018-02-12 13:10:05 +01:00
Janic DuplessisandFacebook Github Bot 1af645b2fd Validate that JS and Native code versions match for RN releases 
Summary:
Basic implementation of the proposal in #15271

Note that this should not affect facebook internally since they are not using OSS releases.

Points to consider:
- How strict should the version match be, right now I just match exact versions.
- Wasn't able to use haste for ReactNativeVersion because I was getting duplicate module provider caused by the template file in scripts/versiontemplates. I tried adding the scripts folder to modulePathIgnorePatterns in package.json but that didn't help.
- Redscreen vs. warning, I think warning is useless because if the app crashes you won't have time to see the warning.
- Should the check and native modules be __DEV__ only?

**Test plan**
Tested that it works when version match and that it redscreens when versions don't before getting other errors on Android and iOS.
Closes https://github.com/facebook/react-native/pull/15518

Differential Revision: D5813551

Pulled By: hramos

fbshipit-source-id: 901757e25724b0f22bf39de172b56309d0dd5a95
 2017-09-27 18:31:15 -07:00