Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
12,400 Commits 541 Branches 635 Tags
0.52-stable
Commit Graph
6 Commits
Author SHA1 Message Date
Mike Grabowski 8a5b6a5a09 [0.52.3] Bump version numbers 2018-02-14 15:47:48 +01:00
Mike Grabowski 94c5a3412f [0.52.2] Bump version numbers 2018-01-26 11:16:42 +01:00
James IdeandMike Grabowski 9a8784c241 [0.52.1] Bump version numbers 2018-01-18 12:13:18 -08:00
Mike Grabowski f465017fe8 [0.52.0] Bump version numbers 2018-01-08 13:45:14 +01:00
Mike Grabowski 02a61a8d8e [0.52.0-rc.0] Bump version numbers 2017-12-18 18:27:04 +01:00
Janic DuplessisandFacebook Github Bot 1af645b2fd Validate that JS and Native code versions match for RN releases 
Summary:
Basic implementation of the proposal in #15271

Note that this should not affect facebook internally since they are not using OSS releases.

Points to consider:
- How strict should the version match be, right now I just match exact versions.
- Wasn't able to use haste for ReactNativeVersion because I was getting duplicate module provider caused by the template file in scripts/versiontemplates. I tried adding the scripts folder to modulePathIgnorePatterns in package.json but that didn't help.
- Redscreen vs. warning, I think warning is useless because if the app crashes you won't have time to see the warning.
- Should the check and native modules be __DEV__ only?

**Test plan**
Tested that it works when version match and that it redscreens when versions don't before getting other errors on Android and iOS.
Closes https://github.com/facebook/react-native/pull/15518

Differential Revision: D5813551

Pulled By: hramos

fbshipit-source-id: 901757e25724b0f22bf39de172b56309d0dd5a95
 2017-09-27 18:31:15 -07:00