From fff3ad13360de686ab3ca863aafd866888eb716f Mon Sep 17 00:00:00 2001 From: Emil Sjolander Date: Mon, 29 May 2017 07:50:46 -0700 Subject: [PATCH] Fix confusing variable name Reviewed By: gkassabli Differential Revision: D5144146 fbshipit-source-id: a5d711f8ad7049b0d96ee0f0f3eef1165ab3b4e8 --- ReactCommon/yoga/yoga/Yoga.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/ReactCommon/yoga/yoga/Yoga.c b/ReactCommon/yoga/yoga/Yoga.c index db0e727ac7c..eb2e2137a74 100644 --- a/ReactCommon/yoga/yoga/Yoga.c +++ b/ReactCommon/yoga/yoga/Yoga.c @@ -2237,9 +2237,7 @@ static void YGNodelayoutImpl(const YGNodeRef node, const float childMarginMainAxis = YGNodeMarginForAxis(child, mainAxis, availableInnerWidth); const float flexBasisWithMaxConstraints = fminf(YGResolveValue(&child->style.maxDimensions[dim[mainAxis]], mainAxisParentSize), - fmaxf(YGResolveValue(&child->style.minDimensions[dim[mainAxis]], - mainAxisParentSize), - child->layout.computedFlexBasis)); + child->layout.computedFlexBasis); const float flexBasisWithMinAndMaxConstraints = fmaxf(YGResolveValue(&child->style.minDimensions[dim[mainAxis]], mainAxisParentSize), flexBasisWithMaxConstraints); @@ -2257,15 +2255,13 @@ static void YGNodelayoutImpl(const YGNodeRef node, sizeConsumedOnCurrentLineIncludingMinConstraint += flexBasisWithMinAndMaxConstraints + childMarginMainAxis; - sizeConsumedOnCurrentLine += flexBasisWithMaxConstraints + childMarginMainAxis; + sizeConsumedOnCurrentLine += flexBasisWithMinAndMaxConstraints + childMarginMainAxis; itemsOnLine++; if (YGNodeIsFlex(child)) { totalFlexGrowFactors += YGResolveFlexGrow(child); - // Unlike the grow factor, the shrink factor is scaled relative to the - // child - // dimension. + // Unlike the grow factor, the shrink factor is scaled relative to the child dimension. totalFlexShrinkScaledFactors += -YGNodeResolveFlexShrink(child) * child->layout.computedFlexBasis; }