From ff980050c94b5bb550b40837a84bc0e7f69c2e27 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Sat, 12 Dec 2020 18:58:58 -0800 Subject: [PATCH] Manual: Migrate from bridge.accessibilityManager to RCTModuleRegistry Summary: Ran `xbgs .accibilityManager`, and found all the NativeModules that used the bridge to access AccessibilityManager. Then, I migrated them to use RCTModuleRegistry. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D25504726 fbshipit-source-id: fcfb1fffbeedc136ee160d043949d9859300b1e3 --- React/CoreModules/RCTDeviceInfo.mm | 35 +++++++++++++----------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/React/CoreModules/RCTDeviceInfo.mm b/React/CoreModules/RCTDeviceInfo.mm index 9d722f0ea83..6084c9ffeaf 100644 --- a/React/CoreModules/RCTDeviceInfo.mm +++ b/React/CoreModules/RCTDeviceInfo.mm @@ -43,14 +43,13 @@ RCT_EXPORT_MODULE() return dispatch_get_main_queue(); } -- (void)setBridge:(RCTBridge *)bridge +- (void)setModuleRegistry:(RCTModuleRegistry *)moduleRegistry { - _bridge = bridge; - + _moduleRegistry = moduleRegistry; [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(didReceiveNewContentSizeMultiplier) name:RCTAccessibilityManagerDidUpdateMultiplierNotification - object:_bridge.accessibilityManager]; + object:[moduleRegistry moduleForName:"AccessibilityManager"]]; _currentInterfaceOrientation = [RCTSharedApplication() statusBarOrientation]; @@ -59,7 +58,7 @@ RCT_EXPORT_MODULE() name:UIApplicationDidChangeStatusBarOrientationNotification object:nil]; - _currentInterfaceDimensions = RCTExportedDimensions(_bridge, _turboModuleRegistry); + _currentInterfaceDimensions = RCTExportedDimensions(_moduleRegistry); [[NSNotificationCenter defaultCenter] addObserver:self selector:@selector(interfaceFrameDidChange) @@ -98,17 +97,15 @@ static BOOL RCTIsIPhoneX() return isIPhoneX; } -static NSDictionary *RCTExportedDimensions(RCTBridge *bridge, id turboModuleRegistry) +static NSDictionary *RCTExportedDimensions(RCTModuleRegistry *moduleRegistry) { RCTAssertMainQueue(); RCTDimensions dimensions; - if (bridge) { - dimensions = RCTGetDimensions(bridge.accessibilityManager.multiplier ?: 1.0); - } else if (turboModuleRegistry) { + if (moduleRegistry) { dimensions = RCTGetDimensions( - ((RCTAccessibilityManager *)[turboModuleRegistry moduleForName:"RCTAccessibilityManager"]).multiplier ?: 1.0); + ((RCTAccessibilityManager *)[moduleRegistry moduleForName:"AccessibilityManager"]).multiplier ?: 1.0); } else { - RCTAssert(false, @"Bridge or TurboModuleRegistry must be set to properly init dimensions."); + RCTAssert(false, @"ModuleRegistry must be set to properly init dimensions."); } __typeof(dimensions.window) window = dimensions.window; NSDictionary *dimsWindow = @{ @@ -135,9 +132,10 @@ static NSDictionary *RCTExportedDimensions(RCTBridge *bridge, id *)getConstants { __block NSDictionary *constants; + RCTModuleRegistry *moduleRegistry = _moduleRegistry; RCTUnsafeExecuteOnMainQueueSync(^{ constants = @{ - @"Dimensions" : RCTExportedDimensions(self->_bridge, self->_turboModuleRegistry), + @"Dimensions" : RCTExportedDimensions(moduleRegistry), // Note: // This prop is deprecated and will be removed in a future release. // Please use this only for a quick and temporary solution. @@ -151,15 +149,13 @@ static NSDictionary *RCTExportedDimensions(RCTBridge *bridge, id_turboModuleRegistry)]; + [[moduleRegistry moduleForName:"EventDispatcher"] sendDeviceEventWithName:@"didUpdateDimensions" + body:RCTExportedDimensions(moduleRegistry)]; #pragma clang diagnostic pop }); } @@ -183,9 +179,8 @@ static NSDictionary *RCTExportedDimensions(RCTBridge *bridge, id