From ff38f47b60dfc6caa03f2a8024c8b7d10e04a9d8 Mon Sep 17 00:00:00 2001 From: Joshua Gross Date: Mon, 6 Apr 2020 15:48:13 -0700 Subject: [PATCH] Add debug logs to track down T62192299 exception source Summary: Add debug logs to track down T62192299 exception source Changelog: [Internal] Reviewed By: RSNara Differential Revision: D20878063 fbshipit-source-id: 94acd56c45d4b529a695d1b4d2bfd10d8f725e63 --- .../main/java/com/facebook/react/ReactInstanceManager.java | 6 ++++++ .../com/facebook/react/bridge/CatalystInstanceImpl.java | 3 +++ .../react/devsupport/DisabledDevSupportManager.java | 4 ++++ 3 files changed, 13 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java index 1e111d3e78a..17eae9a9505 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactInstanceManager.java @@ -1036,6 +1036,12 @@ public class ReactInstanceManager { try { setupReactContext(reactApplicationContext); } catch (Exception e) { + // TODO T62192299: remove this after investigation + FLog.e( + ReactConstants.TAG, + "ReactInstanceManager caught exception in setupReactContext", + e); + mDevSupportManager.handleException(e); } } diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java index 44d3cb2b723..a6ac1405b05 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/CatalystInstanceImpl.java @@ -715,6 +715,9 @@ public class CatalystInstanceImpl implements CatalystInstance { } private void onNativeException(Exception e) { + // TODO T62192299: remove this after investigation + FLog.e(ReactConstants.TAG, "CatalystInstanceImpl caught native exception", e); + mNativeModuleCallExceptionHandler.handleException(e); mReactQueueConfiguration .getUIQueueThread() diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java index df0ca843ba2..5c6331c99b7 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/DisabledDevSupportManager.java @@ -9,6 +9,7 @@ package com.facebook.react.devsupport; import android.view.View; import androidx.annotation.Nullable; +import com.facebook.common.logging.FLog; import com.facebook.react.bridge.DefaultNativeModuleCallExceptionHandler; import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReadableArray; @@ -157,6 +158,9 @@ public class DisabledDevSupportManager implements DevSupportManager { @Override public void handleException(Exception e) { + // TODO T62192299: remove this after investigation + FLog.e("DisabledDevSupportManager", "Caught exception", e); + mDefaultNativeModuleCallExceptionHandler.handleException(e); } }