From fe2c8fc057db2ba6a2c8c9667b9738df5bee190c Mon Sep 17 00:00:00 2001 From: Gijs Weterings Date: Wed, 9 Apr 2025 09:07:30 -0700 Subject: [PATCH] Apply nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D72384073 fbshipit-source-id: fb9cc4d6da6ee78785e70c8b298434f61c60c1dd --- .../main/java/com/facebook/react/bridge/DynamicFromMap.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.java index 0a183f38af0..9013581e444 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromMap.java @@ -28,6 +28,7 @@ class DynamicFromMap implements Dynamic { private DynamicFromMap() {} public static DynamicFromMap create(ReadableMap map, String name) { + // NULLSAFE_FIXME[Nullable Dereference] DynamicFromMap dynamic = sPool.get().acquire(); if (dynamic == null) { dynamic = new DynamicFromMap(); @@ -41,6 +42,7 @@ class DynamicFromMap implements Dynamic { public void recycle() { mMap = null; mName = null; + // NULLSAFE_FIXME[Nullable Dereference] sPool.get().release(this); } @@ -81,6 +83,7 @@ class DynamicFromMap implements Dynamic { if (mMap == null || mName == null) { throw new IllegalStateException("This dynamic value has been recycled"); } + // NULLSAFE_FIXME[Return Not Nullable] return mMap.getString(mName); } @@ -89,6 +92,7 @@ class DynamicFromMap implements Dynamic { if (mMap == null || mName == null) { throw new IllegalStateException("This dynamic value has been recycled"); } + // NULLSAFE_FIXME[Return Not Nullable] return mMap.getArray(mName); }