From fde90a8020f4e37d729741fb203e98e357691c12 Mon Sep 17 00:00:00 2001 From: pera Date: Wed, 18 Aug 2021 20:45:54 -0700 Subject: [PATCH] fix: Resolve NODE_BINARY *after* finding the path to node (#32029) Summary: We want to resolve `NODE_BINARY` **after** `find-node.sh` runs and sets up any node version manager that we need to setup, otherwise `NODE_BINARY` is always undefined. ## Changelog [Internal] [Fixed] - Resolve NODE_BINARY after finding the right path to node Pull Request resolved: https://github.com/facebook/react-native/pull/32029 Reviewed By: TheSavior Differential Revision: D30401213 Pulled By: yungsters fbshipit-source-id: 386ffeff15b5f371a452488ed078d3adebe0f211 --- scripts/generate-specs.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/generate-specs.sh b/scripts/generate-specs.sh index ddac05baa1a..b66f4c9b933 100755 --- a/scripts/generate-specs.sh +++ b/scripts/generate-specs.sh @@ -27,13 +27,14 @@ set -e THIS_DIR=$(cd -P "$(dirname "$(readlink "${BASH_SOURCE[0]}" || echo "${BASH_SOURCE[0]}")")" && pwd) TEMP_DIR=$(mktemp -d /tmp/react-native-codegen-XXXXXXXX) RN_DIR=$(cd "$THIS_DIR/.." && pwd) -NODE_BINARY="${NODE_BINARY:-$(command -v node || true)}" USE_FABRIC="${USE_FABRIC:-0}" # Find path to Node # shellcheck source=/dev/null source "$RN_DIR/scripts/find-node.sh" +NODE_BINARY="${NODE_BINARY:-$(command -v node || true)}" + cleanup () { set +e rm -rf "$TEMP_DIR"