Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Create MC to gate execution of JS Responder in Fabric Android

Browse Source 
Summary:
Create MC to gate execution of JS Responder in Fabric Android

MC.react_fabric.enable_js_responder_fabric_android is enabled by default in the server

changelog: [internal] internal

Reviewed By: JoshuaGross

Differential Revision: D26905296

fbshipit-source-id: 82504174394d1e10fd017435cccd38952404fda0
This commit is contained in:
David Vacca
2021-03-08 21:55:50 -08:00
committed by Facebook GitHub Bot
parent 1163599989
commit fddac5908c
2 changed files with 36 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
+3
View File
@@ -62,4 +62,7 @@ public class ReactFeatureFlags {
/** Enables setting layout params to empty to fix a crash */
public static boolean enableSettingEmptyLayoutParams = false;
/** Enables JS Responder in Fabric */
public static boolean enableJSResponder = false;
}
ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java
+33 -29
View File
@@ -1108,26 +1108,28 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
final int reactTag,
final int initialReactTag,
final boolean blockNativeResponder) {
addMountItem(
new MountItem() {
@Override
public void execute(MountingManager mountingManager) {
SurfaceMountingManager surfaceMountingManager =
mountingManager.getSurfaceManager(surfaceId);
if (surfaceMountingManager != null) {
surfaceMountingManager.setJSResponder(
reactTag, initialReactTag, blockNativeResponder);
} else {
FLog.e(
TAG, "setJSResponder skipped, surface no longer available [" + surfaceId + "]");
if (ReactFeatureFlags.enableJSResponder) {
addMountItem(
new MountItem() {
@Override
public void execute(MountingManager mountingManager) {
SurfaceMountingManager surfaceMountingManager =
mountingManager.getSurfaceManager(surfaceId);
if (surfaceMountingManager != null) {
surfaceMountingManager.setJSResponder(
reactTag, initialReactTag, blockNativeResponder);
} else {
FLog.e(
TAG, "setJSResponder skipped, surface no longer available [" + surfaceId + "]");
}
}
}
@Override
public int getSurfaceId() {
return surfaceId;
}
});
@Override
public int getSurfaceId() {
return surfaceId;
}
});
}
}
/**
@@ -1136,18 +1138,20 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
*/
@DoNotStrip
public void clearJSResponder() {
addMountItem(
new MountItem() {
@Override
public void execute(MountingManager mountingManager) {
mountingManager.clearJSResponder();
}
if (ReactFeatureFlags.enableJSResponder) {
addMountItem(
new MountItem() {
@Override
public void execute(MountingManager mountingManager) {
mountingManager.clearJSResponder();
}
@Override
public int getSurfaceId() {
return View.NO_ID;
}
});
@Override
public int getSurfaceId() {
return View.NO_ID;
}
});
}
}
@Override