diff --git a/.github/workflows/publish-release.yml b/.github/workflows/publish-release.yml index a4dfa14ef53..38267c39004 100644 --- a/.github/workflows/publish-release.yml +++ b/.github/workflows/publish-release.yml @@ -199,7 +199,7 @@ jobs: - name: Restore Cached Artifacts uses: actions/cache/restore@v4.0.0 with: - key: v3-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }} + key: v3-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}-${{ hashFiles('./packages/react-native/sdks/hermes/utils/build-apple-frameworks.sh') }} path: | /tmp/hermes/osx-bin/${{ matrix.flavor }} /tmp/hermes/dSYM/${{ matrix.flavor }} @@ -370,7 +370,7 @@ jobs: uses: actions/cache/save@v4.0.0 if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, '-stable') }} # To avoid that the cache explode. with: - key: v3-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }} + key: v3-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}-${{ hashFiles('./packages/react-native/sdks/hermes/utils/build-apple-frameworks.sh') }} path: | /tmp/hermes/osx-bin/${{ matrix.flavor }} /tmp/hermes/dSYM/${{ matrix.flavor }} diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index 24720665aad..c21da9de7a2 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -210,7 +210,7 @@ jobs: - name: Restore Cached Artifacts uses: actions/cache/restore@v4.0.0 with: - key: v4-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }} + key: v4-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}-${{ hashFiles('./packages/react-native/sdks/hermes/utils/build-apple-frameworks.sh') }} path: | /tmp/hermes/osx-bin/${{ matrix.flavor }} /tmp/hermes/dSYM/${{ matrix.flavor }} @@ -382,7 +382,7 @@ jobs: uses: actions/cache/save@v4.0.0 if: ${{ github.ref == 'refs/heads/main' || contains(github.ref, '-stable') }} # To avoid that the cache explode. with: - key: v4-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }} + key: v4-hermes-artifacts-${{ matrix.flavor }}-${{ needs.prepare_hermes_workspace.outputs.hermes-version }}-${{ needs.prepare_hermes_workspace.outputs.react-native-version }}-${{ hashFiles('./packages/react-native/sdks/hermes/utils/build-apple-frameworks.sh') }} path: | /tmp/hermes/osx-bin/${{ matrix.flavor }} /tmp/hermes/dSYM/${{ matrix.flavor }} diff --git a/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh b/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh index e8cbb496453..5ff30800a38 100755 --- a/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh +++ b/packages/react-native/sdks/hermes-engine/utils/build-apple-framework.sh @@ -198,19 +198,7 @@ function create_universal_framework { for i in "${!platforms[@]}"; do local platform="${platforms[$i]}" local hermes_framework_path="${platform}/hermes.framework" - local dSYM_path="$hermes_framework_path" - local dSYM_base_path="$HERMES_PATH/destroot/Library/Frameworks" - - # If the dSYM rename has failed, the dSYM are generated as 0.dSYM - # (Apple default name) rather then hermes.framework.dSYM. - if [[ -e "$dSYM_base_path/${platform}/0.dSYM" ]]; then - dSYM_path="${platform}/0" - fi - args+="-framework $hermes_framework_path " - - # Path to dSYM must be absolute - args+="-debug-symbols $dSYM_base_path/$dSYM_path.dSYM " done mkdir -p universal