From fd36a514561f3136bf1dd9d4aa9c5ecfae811067 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Mon, 10 Feb 2025 02:32:12 -0800 Subject: [PATCH] Remove unnecessary RobolectricTestRunner usage (#49290) Summary: Was going through some tests and I notice several files that use `RobolectricTestRunner` unnecessarily. This PR cleans that up. ## Changelog: [INTERNAL] - Remove unnecessary RobolectricTestRunner usage Pull Request resolved: https://github.com/facebook/react-native/pull/49290 Test Plan: ``` yarn test-android ``` Reviewed By: cipolleschi Differential Revision: D69383948 Pulled By: cortinico fbshipit-source-id: 6102319115240267ba83a086d03a850d1b7cdae5 --- .../com/facebook/react/devsupport/MultipartStreamReaderTest.kt | 3 --- .../java/com/facebook/react/devsupport/StackTraceHelperTest.kt | 3 --- .../react/modules/network/ProgressiveStringDecoderTest.kt | 3 --- .../react/modules/network/ReactCookieJarContainerTest.kt | 3 --- .../java/com/facebook/react/uimanager/MatrixMathHelperTest.kt | 3 --- .../react/uimanager/ReactPropAnnotationSetterSpecTest.kt | 3 --- .../react/uimanager/layoutanimation/InterpolatorTypeTest.kt | 3 --- .../java/com/facebook/react/views/image/ImageResizeModeTest.kt | 3 --- .../java/com/facebook/react/views/text/TextTransformTest.kt | 3 --- .../test/java/com/facebook/react/views/view/ColorUtilTest.kt | 3 --- 10 files changed, 30 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt index 5c65d981a75..b6e56307d31 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/MultipartStreamReaderTest.kt @@ -11,10 +11,7 @@ import okio.Buffer import okio.ByteString import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner -@RunWith(RobolectricTestRunner::class) class MultipartStreamReaderTest { @Test diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/StackTraceHelperTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/StackTraceHelperTest.kt index c3ab6a2ea8f..9476927d3eb 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/StackTraceHelperTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/devsupport/StackTraceHelperTest.kt @@ -13,11 +13,8 @@ import com.facebook.react.common.annotations.UnstableReactNativeAPI import com.facebook.react.interfaces.exceptionmanager.ReactJsExceptionHandler.* import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner @OptIn(UnstableReactNativeAPI::class) -@RunWith(RobolectricTestRunner::class) class StackTraceHelperTest { @Test fun testParseAlternateFormatStackFrameWithMethod() { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressiveStringDecoderTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressiveStringDecoderTest.kt index 4e74f9582c8..b8319d49c97 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressiveStringDecoderTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ProgressiveStringDecoderTest.kt @@ -12,10 +12,7 @@ import java.nio.charset.StandardCharsets import kotlin.math.min import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner -@RunWith(RobolectricTestRunner::class) class ProgressiveStringDecoderTest { private val TEST_DATA_1_BYTE = diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ReactCookieJarContainerTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ReactCookieJarContainerTest.kt index e9dac8494e8..e4006635968 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ReactCookieJarContainerTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/network/ReactCookieJarContainerTest.kt @@ -12,14 +12,11 @@ import okhttp3.CookieJar import okhttp3.HttpUrl import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith import org.mockito.kotlin.any import org.mockito.kotlin.mock import org.mockito.kotlin.whenever -import org.robolectric.RobolectricTestRunner /** Tests for {@link NetworkingModule}. */ -@RunWith(RobolectricTestRunner::class) class ReactCookieJarContainerTest { private val httpUrl: HttpUrl = HttpUrl.Builder().host("example.com").scheme("http").build() diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/MatrixMathHelperTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/MatrixMathHelperTest.kt index d60978bea2d..b6a9e6d04ee 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/MatrixMathHelperTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/MatrixMathHelperTest.kt @@ -12,11 +12,8 @@ import kotlin.math.cos import kotlin.math.sin import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner /** Test for [MatrixMathHelper] */ -@RunWith(RobolectricTestRunner::class) class MatrixMathHelperTest { @Test diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterSpecTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterSpecTest.kt index 130531a81ef..df3d23918a8 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterSpecTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterSpecTest.kt @@ -12,11 +12,8 @@ import com.facebook.react.uimanager.annotations.ReactProp import com.facebook.react.uimanager.annotations.ReactPropGroup import java.util.Date import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner /** Test that verifies that spec of methods annotated with @ReactProp is correct */ -@RunWith(RobolectricTestRunner::class) @Suppress("UNUSED_PARAMETER") class ReactPropAnnotationSetterSpecTest { private abstract inner class BaseViewManager : ViewManager>() { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/layoutanimation/InterpolatorTypeTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/layoutanimation/InterpolatorTypeTest.kt index 37bcf0edc25..58690e01e0a 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/layoutanimation/InterpolatorTypeTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/uimanager/layoutanimation/InterpolatorTypeTest.kt @@ -10,10 +10,7 @@ package com.facebook.react.uimanager.layoutanimation import java.util.Locale import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner -@RunWith(RobolectricTestRunner::class) class InterpolatorTypeTest { @Test fun testCamelCase() { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ImageResizeModeTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ImageResizeModeTest.kt index a00ea2e5a69..2e02fe36700 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ImageResizeModeTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ImageResizeModeTest.kt @@ -11,10 +11,7 @@ import android.graphics.Shader.TileMode import com.facebook.drawee.drawable.ScalingUtils import org.assertj.core.api.Assertions import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner -@RunWith(RobolectricTestRunner::class) class ImageResizeModeTest { @Test diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/TextTransformTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/TextTransformTest.kt index 6bd1c2dbe09..3e6919151ee 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/TextTransformTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/text/TextTransformTest.kt @@ -9,10 +9,7 @@ package com.facebook.react.views.text import org.assertj.core.api.Assertions.assertThat import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner -@RunWith(RobolectricTestRunner::class) class TextTransformTest { @Test fun textTransformCapitalize() { diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/view/ColorUtilTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/view/ColorUtilTest.kt index cee90dce009..581066060ed 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/view/ColorUtilTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/view/ColorUtilTest.kt @@ -9,11 +9,8 @@ package com.facebook.react.views.view import junit.framework.TestCase.assertEquals import org.junit.Test -import org.junit.runner.RunWith -import org.robolectric.RobolectricTestRunner /** Based on Fresco's DrawableUtilsTest (https://github.com/facebook/fresco). */ -@RunWith(RobolectricTestRunner::class) class ColorUtilTest { @Test fun testNormalize() {