Add RedBoxSurfaceDelegate to DevSupportManagerBase to abstract surface logic to show RedBox

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Summary:
This diff adds `RedBoxSurfaceDelegate` to replace existing logic in `DevSupportManagerBase` to abstract how we show/hide the RedBox surface. The delegate will wrap a RedBoxDialog instance, which is used to show/hide the dialog for default behavior (when there is no surface delegate for redbox got provided).

I also updated the interface for delegate to accomodate new use cases:
- Add `isShowing` for the `SurfaceDelegate`
- Add a list of getters for `DevSupportManager` for data access in the delegate
- (Update 2/7) Separate Dialog from `RedBoxDialog`, and re-named it to `RedBoxContentView`. This is to make it clear that the delegate is responsible to provide actual surface implementation (Dialog). The content view is meant to be shared.

Changelog:
[Android][Internal]

Reviewed By: javache

Differential Revision: D33987835

fbshipit-source-id: 57c20648e7f2ec8238963feca27ccd5518e7931d

This commit is contained in:

Xin Chen

2022-02-09 15:16:22 -08:00

committed by

Facebook GitHub Bot

parent 5341ad8962

commit fc7eb91f56

8 changed files with 232 additions and 114 deletions

									
										ReactAndroid/src/main/java/com/facebook/react/common/SurfaceDelegate.java
									
		+3
		
												View File
												
				@@ -37,4 +37,7 @@ public interface SurfaceDelegate {

				  /** Hide the surface containing the React content view */

				  void hide();

				  /** Check if the surface is currently showing */

				  boolean isShowing();

				}