Use native_module_spec_name to name codegen targets

Summary:
## Description
Suppose this was the codegen declaration before:

```
rn_library(
  name = "FooModule",
  native_module_spec_name = "FBReactNativeSpec",
  codegen_modules = True,
  # ...
)
```

Previously, this would generate the following BUCK targets:
- generated_objcpp_modules-FooModuleApple
- generated_java_modules-FooModuleAndroid
- generated_java_modules-FooModule-jniAndroid

## Changes
We will now generate:
- FBReactNativeSpecApple
- FBReactNativeSpecAndroid
- FBReactNativeSpec-jniAndroid

This matches the naming scheme of the old codegen.

Changelog: [Internal]

Reviewed By: fkgozali

Differential Revision: D25680224

fbshipit-source-id: 617ac18fd915f3277f6bd98072d147f20fb193e5
This commit is contained in:
Ramanpreet Nara
2020-12-24 00:47:38 -08:00
committed by Facebook GitHub Bot
parent a68415270c
commit fb34fba01c
28 changed files with 32 additions and 32 deletions
@@ -29,5 +29,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/uimanager:uimanager"),
react_native_target("java/com/facebook/react/uimanager/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -40,7 +40,7 @@ rn_android_library(
react_native_target("res:devsupport"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -19,5 +19,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/core:core"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -17,5 +17,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/core:core"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -17,5 +17,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/core:core"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -32,6 +32,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/modules/websocket:websocket"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -18,5 +18,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/devsupport:interfaces"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -19,6 +19,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -22,6 +22,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/util:util"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -23,5 +23,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/common:common"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -24,7 +24,7 @@ rn_android_library(
react_native_target("java/com/facebook/react/uimanager:uimanager"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -20,6 +20,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/uimanager:uimanager"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -24,5 +24,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/common:common"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -25,6 +25,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/views/image:image"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)
@@ -17,5 +17,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/common:common"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -29,5 +29,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/core:core"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -16,5 +16,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/core:core"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -16,5 +16,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/common:common"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -20,5 +20,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/uimanager:uimanager"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -25,5 +25,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/uimanager:uimanager"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -19,5 +19,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/common:common"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -22,7 +22,7 @@ rn_android_library(
react_native_target("java/com/facebook/react/turbomodule/core/interfaces:interfaces"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
":systeminfo-moduleless",
],
)
@@ -45,5 +45,5 @@ rn_android_library(
react_native_dep("third-party/java/jsr-305:jsr-305"),
react_native_target("res:systeminfo"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -15,5 +15,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/common:common"),
react_native_target("java/com/facebook/react/module/annotations:annotations"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -17,5 +17,5 @@ rn_android_library(
react_native_target("java/com/facebook/react/module/annotations:annotations"),
react_native_target("java/com/facebook/react/modules/core:core"),
],
exported_deps = [react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec")],
exported_deps = [react_native_root_target("Libraries:FBReactNativeSpec")],
)
@@ -23,6 +23,6 @@ rn_android_library(
react_native_target("java/com/facebook/react/modules/network:network"),
],
exported_deps = [
react_native_root_target("Libraries:generated_java_modules-FBReactNativeSpec"),
react_native_root_target("Libraries:FBReactNativeSpec"),
],
)