From faae720e4108a04ebeaae58e3d95944630828d00 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Sat, 29 Jul 2023 11:20:24 -0700 Subject: [PATCH] Fix lint warns (#38596) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/38596 Fix lint warns changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D47445900 fbshipit-source-id: af1d30e3889050c15d015cd6f1c35c73210167d9 --- .../main/java/com/facebook/react/CoreModulesPackage.java | 7 +------ .../com/facebook/react/module/model/ReactModuleInfo.java | 2 +- .../facebook/react/modules/appstate/AppStateModule.java | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java index 2c2fc48831c..5883ee1b17e 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/CoreModulesPackage.java @@ -119,12 +119,7 @@ public class CoreModulesPackage extends TurboReactPackage implements ReactPackag TurboModule.class.isAssignableFrom(moduleClass))); } - return new ReactModuleInfoProvider() { - @Override - public Map getReactModuleInfos() { - return reactModuleInfoMap; - } - }; + return () -> reactModuleInfoMap; } catch (InstantiationException e) { throw new RuntimeException( "No ReactModuleInfoProvider for CoreModulesPackage$$ReactModuleInfoProvider", e); diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/model/ReactModuleInfo.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/model/ReactModuleInfo.java index a44d43281e6..f0560439468 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/model/ReactModuleInfo.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/model/ReactModuleInfo.java @@ -18,7 +18,7 @@ public class ReactModuleInfo { private final boolean mNeedsEagerInit; private final boolean mHasConstants; private final boolean mIsCxxModule; - private String mClassName; + private final String mClassName; private final boolean mIsTurboModule; public ReactModuleInfo( diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/AppStateModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/AppStateModule.java index e62bb0790e6..393a21890ea 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/AppStateModule.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/appstate/AppStateModule.java @@ -23,7 +23,6 @@ import javax.annotation.Nullable; @ReactModule(name = NativeAppStateSpec.NAME) public class AppStateModule extends NativeAppStateSpec implements LifecycleEventListener, WindowFocusChangeListener { - public static final String TAG = AppStateModule.class.getSimpleName(); public static final String APP_STATE_ACTIVE = "active"; public static final String APP_STATE_BACKGROUND = "background";