From faabeadebfd6df2beca97cf6a86bb1bcf1bfada9 Mon Sep 17 00:00:00 2001 From: Fadil Sutomo Date: Wed, 20 Jul 2016 20:01:33 -0700 Subject: [PATCH] Fix JSX string props quote convention Summary: Not sure if I misunderstand the previous JSX convention. But I found that in JSX string props, double-quote is preferred instead. https://github.com/facebook/react-native/blob/master/.eslintrc#L182 ![screen shot 2016-07-21 at 5 32 04 am](https://cloud.githubusercontent.com/assets/6204776/17006166/137db7ae-4f09-11e6-871b-2cf99960e3a1.png) Closes https://github.com/facebook/react-native/pull/8933 Differential Revision: D3597084 fbshipit-source-id: 606a2123f1a1ff1fe2234b636b68b3273ebf6ebb --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 21fcf86c3b9..3c08db03db7 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -101,7 +101,7 @@ Facebook has a [bounty program](https://www.facebook.com/whitehat/) for the safe #### JSX -* Prefer `'` over `"` for string literal props +* Prefer `"` over `'` for string literal props * When wrapping opening tags over multiple lines, place one prop per line * `{}` of props should hug their values (no spaces) * Place the closing `>` of opening tags on the same line as the last prop