From fa66e314b22183e1682a6ba2598e76c462937c75 Mon Sep 17 00:00:00 2001 From: Alex Hunt Date: Mon, 4 Aug 2025 10:04:02 -0700 Subject: [PATCH] Implement Network.loadingFailed (#53023) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53023 Changelog: [Internal] Reviewed By: hoxyq Differential Revision: D79555222 fbshipit-source-id: bfbe36edc867b1fc7a44d8e998489ef1d8896331 --- .../react/modules/network/InspectorNetworkReporter.kt | 7 +++++++ .../facebook/react/modules/network/NetworkEventUtil.kt | 3 +++ .../main/jni/react/jni/InspectorNetworkReporter.cpp | 10 ++++++++++ .../src/main/jni/react/jni/InspectorNetworkReporter.h | 5 +++++ 4 files changed, 25 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/InspectorNetworkReporter.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/InspectorNetworkReporter.kt index fc5d7fe3ca6..efd57abdc2e 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/InspectorNetworkReporter.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/InspectorNetworkReporter.kt @@ -82,6 +82,13 @@ internal object InspectorNetworkReporter { */ @JvmStatic external fun reportResponseEnd(requestId: Int, encodedDataLength: Long) + /** + * Report when a network request has failed. + * + * Corresponds to `Network.loadingFailed` in CDP. + */ + @JvmStatic external fun reportRequestFailed(requestId: Int, cancelled: Boolean) + /** * Store response body preview. This is an optional reporting method, and is a no-op if CDP * debugging is disabled. diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt index 2ce0e96037c..4516b16c535 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkEventUtil.kt @@ -141,6 +141,9 @@ internal object NetworkEventUtil { error: String?, e: Throwable? ) { + if (ReactNativeFeatureFlags.enableNetworkEventReporting()) { + InspectorNetworkReporter.reportRequestFailed(requestId, false) + } reactContext?.emitDeviceEvent( "didCompleteNetworkResponse", buildReadableArray { diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.cpp index 93de856d765..f5c8f935eaa 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.cpp @@ -134,6 +134,14 @@ static std::unordered_map responseBuffers; #endif } +/* static */ void InspectorNetworkReporter::reportRequestFailed( + jni::alias_ref /*unused*/, + jint requestId, + jboolean cancelled) { + NetworkReporter::getInstance().reportRequestFailed( + std::to_string(requestId), cancelled); +} + /* static */ void InspectorNetworkReporter::maybeStoreResponseBodyImpl( jni::alias_ref /*unused*/, jint requestId, @@ -184,6 +192,8 @@ InspectorNetworkReporter::maybeStoreResponseBodyIncrementalImpl( InspectorNetworkReporter::reportDataReceivedImpl), makeNativeMethod( "reportResponseEnd", InspectorNetworkReporter::reportResponseEnd), + makeNativeMethod( + "reportRequestFailed", InspectorNetworkReporter::reportRequestFailed), makeNativeMethod( "maybeStoreResponseBodyImpl", InspectorNetworkReporter::maybeStoreResponseBodyImpl), diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.h b/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.h index 4b1e2e94d19..ccb45c149d4 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/jni/InspectorNetworkReporter.h @@ -51,6 +51,11 @@ class InspectorNetworkReporter jint requestId, jlong encodedDataLength); + static void reportRequestFailed( + jni::alias_ref /*unused*/, + jint requestId, + jboolean cancelled); + static void maybeStoreResponseBodyImpl( jni::alias_ref /*unused*/, jint requestId,