From f9c86f05e969b86011c13ae839182acdcf7b0b46 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 15 Aug 2018 17:49:49 -0700 Subject: [PATCH] Implement remove root view operations Summary: This diff implements the removal of react root view inside fabric cxx implementation Reviewed By: shergin Differential Revision: D8939942 fbshipit-source-id: 69835b55c80e2970d65220d947489bc1af4b125d --- .../src/main/java/com/facebook/react/bridge/UIManager.java | 5 +++++ .../main/java/com/facebook/react/fabric/FabricUIManager.java | 1 + 2 files changed, 6 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/UIManager.java b/ReactAndroid/src/main/java/com/facebook/react/bridge/UIManager.java index e08133ded25..29a5a93148b 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/bridge/UIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/bridge/UIManager.java @@ -12,6 +12,11 @@ public interface UIManager extends JSIModule, PerformanceCounter { */ int addRootView(final T rootView); + /** + * Unregisters a new root view. + */ + void removeRootView(int reactRootTag); + /** * Updates the layout specs of the RootShadowNode based on the Measure specs received by * parameters. diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java index 345e214c091..76c2ea8aa7c 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java @@ -547,6 +547,7 @@ public class FabricUIManager implements UIManager, JSHandler, FabricBinder { } public void removeRootView(int rootTag) { + mUIViewOperationQueue.enqueueRemoveRootView(rootTag); mRootShadowNodeRegistry.removeNode(rootTag); }