From f9c2aaf3e754209054e3395366992dc3361bea36 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Thu, 14 Aug 2025 04:41:13 -0700 Subject: [PATCH] Rename setUpDefaultReactNativeEnvironment to scope it better (#53267) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/53267 Changelog: [internal] Test files that verify the behavior of the global setup can only have a single test, as we can't really reset it across tests. Because of that, I'm renaming the current one to make the behavior under test more explicit. Reviewed By: rshest Differential Revision: D80177333 fbshipit-source-id: df9eeba15906bc6071940824dad9e576a267f499 --- ...DefaultReactNativeEnvironment-ComponentSideEffects-itest.js} | 2 +- .../setUpDefaultReactNativeEnvironment-FeatureFlags-itest.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) rename packages/react-native/src/private/setup/__tests__/{setUpDefaultReactNativeEnvironment-itest.js => setUpDefaultReactNativeEnvironment-ComponentSideEffects-itest.js} (95%) diff --git a/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-itest.js b/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-ComponentSideEffects-itest.js similarity index 95% rename from packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-itest.js rename to packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-ComponentSideEffects-itest.js index 297be14e172..8847da378d4 100644 --- a/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-itest.js +++ b/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-ComponentSideEffects-itest.js @@ -10,7 +10,7 @@ import setUpDefaultReactNativeEnvironment from 'react-native/src/private/setup/setUpDefaultReactNativeEnvironment'; -describe('setUpReactNativeEnvironment', () => { +describe('setUpReactNativeEnvironment (components side-effects)', () => { it('should not load components as a side effect', () => { // We set up has not been done yet. expect(globalThis.self).toBeUndefined(); diff --git a/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-FeatureFlags-itest.js b/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-FeatureFlags-itest.js index b6f7acd4be4..8084e4ce5b2 100644 --- a/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-FeatureFlags-itest.js +++ b/packages/react-native/src/private/setup/__tests__/setUpDefaultReactNativeEnvironment-FeatureFlags-itest.js @@ -12,7 +12,7 @@ import * as ReactNativeFeatureFlags from '../../featureflags/ReactNativeFeatureF import * as ReactNativeFeatureFlagsBase from '../../featureflags/ReactNativeFeatureFlagsBase'; import setUpDefaultReactNativeEnvironment from 'react-native/src/private/setup/setUpDefaultReactNativeEnvironment'; -describe('setUpReactNativeEnvironment', () => { +describe('setUpReactNativeEnvironment (feature flags side-effects)', () => { it('should not read any feature flags', () => { ReactNativeFeatureFlagsBase.dangerouslyResetForTesting();