From f8dff0bcb3147b7a1aa8ac7159952d848e198e29 Mon Sep 17 00:00:00 2001
From: Anda Bereczky <andab@fb.com>
Date: Fri, 23 Aug 2019 15:18:53 -0700
Subject: [PATCH] Default accessibility hint is read for buttons

Summary: [Android] [Fixed] - Make sure the default accessibility hint is read for buttons on Android.

Reviewed By: PeteTheHeat

Differential Revision: D16974987

fbshipit-source-id: e7b932041f82d41271d9393e651967789c05f38a
---
 .../facebook/react/uimanager/ReactAccessibilityDelegate.java  | 3 +++
 .../main/res/views/uimanager/values/strings_unlocalized.xml   | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
index 640d6d0859f..405506c2e29 100644
--- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
+++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/ReactAccessibilityDelegate.java
@@ -290,6 +290,9 @@ public class ReactAccessibilityDelegate extends AccessibilityDelegateCompat {
     } else if (role.equals(AccessibilityRole.IMAGEBUTTON)) {
       nodeInfo.setRoleDescription(context.getString(R.string.imagebutton_description));
       nodeInfo.setClickable(true);
+    } else if (role.equals(AccessibilityRole.BUTTON)) {
+      nodeInfo.setRoleDescription(context.getString(R.string.button_description));
+      nodeInfo.setClickable(true);
     } else if (role.equals(AccessibilityRole.SUMMARY)) {
       nodeInfo.setRoleDescription(context.getString(R.string.summary_description));
     } else if (role.equals(AccessibilityRole.HEADER)) {
diff --git a/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml b/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
index cd3cc03e0d6..4c18708bf3e 100644
--- a/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
+++ b/ReactAndroid/src/main/res/views/uimanager/values/strings_unlocalized.xml
@@ -12,6 +12,10 @@
     name="image_description"
     translatable="false"
     >Image</string>
+  <string
+    name="button_description"
+    translatable="false"
+    >Button</string>
   <string
     name="imagebutton_description"
     translatable="false"