From f7b9aafd10a2f76c9bbdfdd1d925b4edf7a9dac3 Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Wed, 17 Apr 2024 09:53:35 -0700 Subject: [PATCH] Remove getRuntimeExecutor() from ReactContext (#44102) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44102 Remove `getRuntimeExecutor()` from ReactContext since now it can be accessed through BridgelessCatalystInstance.getRuntimeExecutor() directly Changelog: [Android][Removed] - Remove getRuntimeExecutor() from ReactContext since now it can be accessed through BridgelessCatalystInstance in Bridgeless mode Reviewed By: RSNara Differential Revision: D56151365 fbshipit-source-id: 42bb6a6a3d729339cfb83ffdd3f7cbec314b687a --- .../com/facebook/react/bridge/ReactContext.java | 16 ---------------- .../react/runtime/BridgelessReactContext.java | 12 ------------ 2 files changed, 28 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java index dd19a1ff3b0..54dccae42e2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java @@ -27,8 +27,6 @@ import com.facebook.react.bridge.queue.ReactQueueConfiguration; import com.facebook.react.common.LifecycleState; import com.facebook.react.common.ReactConstants; import com.facebook.react.common.annotations.DeprecatedInNewArchitecture; -import com.facebook.react.common.annotations.FrameworkAPI; -import com.facebook.react.common.annotations.UnstableReactNativeAPI; import java.lang.ref.WeakReference; import java.util.Collection; import java.util.concurrent.CopyOnWriteArraySet; @@ -212,20 +210,6 @@ public abstract class ReactContext extends ContextWrapper { return mCatalystInstance.getNativeModule(nativeModuleInterface); } - /** - * @return the RuntimeExecutor, a thread-safe handler for accessing the runtime. - * @experimental - */ - @Nullable - @FrameworkAPI - @UnstableReactNativeAPI - public RuntimeExecutor getRuntimeExecutor() { - if (mCatalystInstance == null) { - raiseCatalystInstanceMissingException(); - } - return mCatalystInstance.getRuntimeExecutor(); - } - /** * Calls RCTDeviceEventEmitter.emit to JavaScript, with given event name and an optional list of * arguments. diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.java index 4a179e38917..7af5a365c07 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/BridgelessReactContext.java @@ -19,7 +19,6 @@ import com.facebook.react.bridge.JavaScriptModuleRegistry; import com.facebook.react.bridge.NativeArray; import com.facebook.react.bridge.NativeModule; import com.facebook.react.bridge.ReactApplicationContext; -import com.facebook.react.bridge.RuntimeExecutor; import com.facebook.react.bridge.UIManager; import com.facebook.react.bridge.WritableNativeArray; import com.facebook.react.common.annotations.FrameworkAPI; @@ -158,17 +157,6 @@ class BridgelessReactContext extends ReactApplicationContext implements EventDis return mReactHost.getNativeModule(nativeModuleInterface); } - /** - * @return the RuntimeExecutor, a thread-safe handler for accessing the runtime. If the runtime is - * not initialized yet, it will return null. - */ - @Override - @FrameworkAPI - @UnstableReactNativeAPI - public @Nullable RuntimeExecutor getRuntimeExecutor() { - return mReactHost.getRuntimeExecutor(); - } - @Override @FrameworkAPI @UnstableReactNativeAPI