Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use Arguments.createArray instead of WritableNativeArray

Browse Source 
Summary:
Using `WriteableNativeArray` directly in common code is breaking unit tests on CircleCI.

Changelog:
[Android][Internal] - Use mock of native array for sending touches

Reviewed By: mdvacca

Differential Revision: D31665842

fbshipit-source-id: 886418ff6a3f07046e8e17d4743060d80c26b288
This commit is contained in:
Andrei Shikov
2021-10-14 16:17:08 -07:00
committed by Facebook GitHub Bot
parent b60e229d7f
commit f7a33e3501
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchesHelper.java
+1 -2
View File
@@ -12,7 +12,6 @@ import com.facebook.react.bridge.Arguments;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
import com.facebook.react.bridge.WritableArray;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.bridge.WritableNativeArray;
import com.facebook.react.uimanager.PixelUtil;
/** Class responsible for generating catalyst touch events based on android {@link MotionEvent}. */
@@ -187,7 +186,7 @@ public class TouchesHelper {
}
private static WritableArray getWritableArray(boolean copyObjects, WritableMap... objects) {
WritableArray result = new WritableNativeArray();
WritableArray result = Arguments.createArray();
for (WritableMap object : objects) {
if (object != null) {
result.pushMap(copyObjects ? object.copy() : object);