From f743bed657591b078300a6519e3d68db542fd757 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Wed, 2 Mar 2022 02:55:55 -0800 Subject: [PATCH] Enable paintFilterBitmap when rendering images with rounded corners Summary: Per Android docs (https://developer.android.com/reference/android/graphics/Paint#FILTER_BITMAP_FLAG): > This should generally be on when drawing bitmaps, unless performance-bound (rendering to software canvas) or preferring pixelation artifacts to blurriness when scaling significantly. Changelog: [Android][Fixed] - Improve rendering of images when resampled and corner radius applied Reviewed By: genkikondo Differential Revision: D34551184 fbshipit-source-id: 649da53af816be829e5b7f8e2a100f07a8b412b7 --- .../java/com/facebook/react/views/image/ReactImageView.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java index b5781263df5..a118b9b607a 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java @@ -138,8 +138,10 @@ public class ReactImageView extends GenericDraweeView { // We can't specify rounding in XML, so have to do so here private static GenericDraweeHierarchy buildHierarchy(Context context) { + RoundingParams roundingParams = RoundingParams.fromCornersRadius(0); + roundingParams.setPaintFilterBitmap(true); return new GenericDraweeHierarchyBuilder(context.getResources()) - .setRoundingParams(RoundingParams.fromCornersRadius(0)) + .setRoundingParams(roundingParams) .build(); }