diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/image/ImageResizeMode.java b/ReactAndroid/src/main/java/com/facebook/react/views/image/ImageResizeMode.java index 958a10fe77f..c847b28c138 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/image/ImageResizeMode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/image/ImageResizeMode.java @@ -15,23 +15,29 @@ import com.facebook.react.bridge.JSApplicationIllegalArgumentException; /** Converts JS resize modes into Android-specific scale type. */ public class ImageResizeMode { + private static final String RESIZE_MODE_CONTAIN = "contain"; + private static final String RESIZE_MODE_COVER = "cover"; + private static final String RESIZE_MODE_STRETCH = "stretch"; + private static final String RESIZE_MODE_CENTER = "center"; + private static final String RESIZE_MODE_REPEAT = "repeat"; + /** * Converts JS resize modes into {@code ScalingUtils.ScaleType}. See {@code ImageResizeMode.js}. */ public static ScalingUtils.ScaleType toScaleType(@Nullable String resizeModeValue) { - if ("contain".equals(resizeModeValue)) { + if (RESIZE_MODE_CONTAIN.equals(resizeModeValue)) { return ScalingUtils.ScaleType.FIT_CENTER; } - if ("cover".equals(resizeModeValue)) { + if (RESIZE_MODE_COVER.equals(resizeModeValue)) { return ScalingUtils.ScaleType.CENTER_CROP; } - if ("stretch".equals(resizeModeValue)) { + if (RESIZE_MODE_STRETCH.equals(resizeModeValue)) { return ScalingUtils.ScaleType.FIT_XY; } - if ("center".equals(resizeModeValue)) { + if (RESIZE_MODE_CENTER.equals(resizeModeValue)) { return ScalingUtils.ScaleType.CENTER_INSIDE; } - if ("repeat".equals(resizeModeValue)) { + if (RESIZE_MODE_REPEAT.equals(resizeModeValue)) { // Handled via a combination of ScaleType and TileMode return ScaleTypeStartInside.INSTANCE; } @@ -45,13 +51,13 @@ public class ImageResizeMode { /** Converts JS resize modes into {@code Shader.TileMode}. See {@code ImageResizeMode.js}. */ public static Shader.TileMode toTileMode(@Nullable String resizeModeValue) { - if ("contain".equals(resizeModeValue) - || "cover".equals(resizeModeValue) - || "stretch".equals(resizeModeValue) - || "center".equals(resizeModeValue)) { + if (RESIZE_MODE_CONTAIN.equals(resizeModeValue) + || RESIZE_MODE_COVER.equals(resizeModeValue) + || RESIZE_MODE_STRETCH.equals(resizeModeValue) + || RESIZE_MODE_CENTER.equals(resizeModeValue)) { return Shader.TileMode.CLAMP; } - if ("repeat".equals(resizeModeValue)) { + if (RESIZE_MODE_REPEAT.equals(resizeModeValue)) { // Handled via a combination of ScaleType and TileMode return Shader.TileMode.REPEAT; }