Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Back out "Send UNIX timestamp along with JS touch events, instead of systemUptime"

Browse Source 
Summary:
Original commit changeset: 0f2db726048f

This original change was made in D26705430 (https://github.com/facebook/react-native/commit/b08362ade5d68af4b6c66d5cf0dab5f42a2ec894) and D26705429 (https://github.com/facebook/react-native/commit/69feed518d01a7d91f0c71509429c4388912131c). The intention was to change the timestamp definition to make touch telemetry easier, but this is (1) unnecessary and (2) causes other issues.

Changelog: [internal]

Reviewed By: mdvacca

Differential Revision: D31183732

fbshipit-source-id: ddc6aafe95dd45fe847524eb65b8a00852381f6d
This commit is contained in:
Joshua Gross
2021-09-24 18:11:33 -07:00
committed by Facebook GitHub Bot
parent 10fe09c456
commit f58a3b9ef4
2 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/uimanager/events/Event.java
-16
View File
@@ -40,15 +40,6 @@ public abstract class Event<T extends Event> {
private long mTimestampMs;
private int mUniqueID = sUniqueID++;
// Android native Event times use 'uptimeMillis', and historically we've used `uptimeMillis`
// throughout this Event class as the coalescing key for events, and for other purposes.
// To get an accurate(ish) absolute UNIX time for the event, we store the initial clock time here.
// uptimeMillis can then be added to this to get an accurate UNIX time.
// However, we still default to uptimeMillis: you must explicitly request UNIX time if you want
// that; see `getUnixTimestampMs`.
public static final long sInitialClockTimeUnixOffset =
SystemClock.currentTimeMillis() - SystemClock.uptimeMillis();
protected Event() {}
@Deprecated
@@ -82,9 +73,7 @@ public abstract class Event<T extends Event> {
// At some point it would be great to pass the SurfaceContext here instead.
mUIManagerType = (surfaceId == -1 ? UIManagerType.DEFAULT : UIManagerType.FABRIC);
// This is a *relative* time. See `getUnixTimestampMs`.
mTimestampMs = SystemClock.uptimeMillis();
mInitialized = true;
}
@@ -106,11 +95,6 @@ public abstract class Event<T extends Event> {
return mTimestampMs;
}
/** @return the time at which the event happened as a UNIX timestamp, in milliseconds. */
public final long getUnixTimestampMs() {
return sInitialClockTimeUnixOffset + mTimestampMs;
}
/** @return false if this Event can *never* be coalesced */
public boolean canCoalesce() {
return true;
ReactAndroid/src/main/java/com/facebook/react/uimanager/events/TouchesHelper.java
+1 -1
View File
@@ -64,7 +64,7 @@ public class TouchesHelper {
touch.putDouble(LOCATION_Y_KEY, PixelUtil.toDIPFromPixel(locationY));
touch.putInt(TARGET_SURFACE_KEY, surfaceId);
touch.putInt(TARGET_KEY, reactTarget);
touch.putDouble(TIMESTAMP_KEY, event.getUnixTimestampMs());
touch.putDouble(TIMESTAMP_KEY, event.getTimestampMs());
touch.putDouble(POINTER_IDENTIFIER_KEY, motionEvent.getPointerId(index));
touches.pushMap(touch);
}