Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

OSS: upgrade Folly 2016.09.26 => 2016.10.31

Browse Source 
Summary:
There was a fix around folly::dynamic constructor that will be needed for Fabric work. This was done in https://github.com/facebook/folly/commit/94e964976c1b65e79b0f7bdd960cfec260399a52#diff-7d1cb97d222ba0c863ea8a8e43b2ee2b and luckily the release 1 month after the Folly version we used in RN already had the fix, so that we don't need to upgrade to the latest folly yet (minimizing breakages).

Tested by:
* running RNTester xcode project (ios)
* running RNTesterPods workspace via cocoapods
* building android via gradle

Reviewed By: shergin

Differential Revision: D7626037

fbshipit-source-id: cb36ba5b91ba131d4e450300bd620db657cfa1e8
This commit is contained in:
Kevin Gozali
2018-04-13 17:33:23 -07:00
committed by Facebook Github Bot
parent cc57b7b1d3
commit f569b45f4c
7 changed files with 37 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/build.gradle
+4 -4
View File
@@ -70,17 +70,17 @@ task prepareDoubleConversion(dependsOn: dependenciesPath ? [] : [downloadDoubleC
}
task downloadFolly(dependsOn: createNativeDepsDirectories, type: Download) {
src 'https://github.com/facebook/folly/archive/v2016.09.26.00.tar.gz'
src 'https://github.com/facebook/folly/archive/v2016.10.31.00.tar.gz'
onlyIfNewer true
overwrite false
dest new File(downloadsDir, 'folly-2016.09.26.00.tar.gz');
dest new File(downloadsDir, 'folly-2016.10.31.00.tar.gz');
}
task prepareFolly(dependsOn: dependenciesPath ? [] : [downloadFolly], type: Copy) {
from dependenciesPath ?: tarTree(downloadFolly.dest)
from 'src/main/jni/third-party/folly/Android.mk'
include 'folly-2016.09.26.00/folly/**/*', 'Android.mk'
eachFile {fname -> fname.path = (fname.path - "folly-2016.09.26.00/")}
include 'folly-2016.10.31.00/folly/**/*', 'Android.mk'
eachFile {fname -> fname.path = (fname.path - "folly-2016.10.31.00/")}
includeEmptyDirs = false
into "$thirdPartyNdkDir/folly"
}