From f48babaa5e9b60fc13ff7ad404434656c3eec7f6 Mon Sep 17 00:00:00 2001 From: Valentino Espinoza Date: Tue, 5 Jul 2016 05:51:05 -0700 Subject: [PATCH] Update Android Performance for opening trace.html Summary: Right now systrace generates an html file that is using the Object.observe function which is now deprecated in most up to date browsers. Since we don't want to depend on the systrace being up to date, we should advise opening the trace through the Tracing tool, since that is the only way to get it working until systrace removes its dependency on Object.observe. Closes https://github.com/facebook/react-native/pull/7880 Differential Revision: D3516305 Pulled By: astreet fbshipit-source-id: ab9ae46ba74b7a34b6cfb8c37ca1ec2e6b41e353 --- docs/AndroidUIPerformance.md | 10 ++++++++++ .../src/react-native/img/ObjectObserveError.png | Bin 0 -> 7539 bytes 2 files changed, 10 insertions(+) create mode 100644 website/src/react-native/img/ObjectObserveError.png diff --git a/docs/AndroidUIPerformance.md b/docs/AndroidUIPerformance.md index 3dc51532dc3..7c6f9ec699d 100644 --- a/docs/AndroidUIPerformance.md +++ b/docs/AndroidUIPerformance.md @@ -45,6 +45,16 @@ After opening the trace in your browser (preferably Chrome), you should see some ![Example](img/SystraceExample.png) +If your trace .html file isn't opening correctly, check your browser console for the following: + +![ObjectObserveError](img/ObjectObserveError.png) + +Since Object.observe was deprecated in recent browsers, you may have to open the file from the Google Chrome Tracing tool. You can do so by: + +- Opening tab in chrome chrome://tracing +- Selecting load +- Selecting the html file generated from the previous command. + **HINT**: Use the WASD keys to strafe and zoom ### Enable VSync highlighting diff --git a/website/src/react-native/img/ObjectObserveError.png b/website/src/react-native/img/ObjectObserveError.png new file mode 100644 index 0000000000000000000000000000000000000000..3634969fdfcf24bbe3a5ba3b32593852118c6e17 GIT binary patch literal 7539 zcmZWtWl&s8(?)^^4-kBDXK{CT2n3g)OK@4(1;S#%0|^@3Aq0m2!QEYhYj9oM<;%VI zwW{wtRi}Eo`{|zUKQq%2S{jPjm}Hm;2ng89N^;r=2#CRdD)a~lm_>H7 zvRcZrvH&f27m%H!4FZBvMB-Ppw>pMoeee%^(Zo_xD!b}FSb&yL+LlNarGQ`pD?oU7 zWd9m^6bcc3Wx&fIW+7rJ1^g;=3oWg7329VB8%lO_X&dUw;Ed(!CfhdfaZ}rM3;b~v z>f%0ji!60)d3MWE`3j+^*+aTAiH(DYH8qqF5j`6bKN-Q8ku4fd@Ol?5#vu8bOy^OF zpWr$gRQvRJ>yK>*@g>7TV8&Y)f{?Kht%IvS_K@Tw2mA(jk6i9O7;?%O=mqeFpG+8P zr0;;MDFnv^ckE?8F5~%OB4iF*V-g?&qG`R2P}%S&Xg2T#wyGM$g7?rxe+a1wbf%yK zRn<*Jhkl_S^gPCE{C>x`(VeOW%1z#x=> zHFe{|=pK^?JrSnq4^?4GZjy&yP+Yf662|hK!lp?6Tb962kA+?l=XRttzoApHl57b zuOovjbL7I&FmfE_X&$0hElSXX`}6{~f|?3sWc`Pp3-B|G;G z1~Z~PZ!v;yP_Ybuw$Yo6@Au63_7s<-(egSId^PwBR7cS`ven}U<7pG}yF4BojTkU& z7`1qKrj&o57T4fw*(l1;z=&>o%NeUPZiZyCVees2HEPgn-jE*4t*S-?@=`$o%(UR; zaE?x@P65lsD)Bj*LwcMroo>?K6t0LujGUB7Uqr)2BbuTPdaySn)|I{Zn}t^hsiSw+ z!KVy2gf{}dK))A~>M^wM2@lZ`UkF$rTae_Wj;qwGzGhS-EQn~7L$hS&j;K#GP;ms9 zF-b7AGQ}#9(Hm>yMW_zaB*tmPJIA3aXASUJBmW>54rQl@(^E6m#Z$+w>M*~ejO1lV zjnkM{F3K}05G(YJ%T{@<%0)j%U`#*AkV@~vu%bjjU&~-hudfPH{;HIj*vux(DIYT# z>mF~Z;`Eg@sS&^r;Ac@!6o|)((MaTslc0gA`n*MD%A?z$>H0blFU$zm1%*fE+G{U= zXWtjF=f4#3G$3XxVH=83kK;%XXISJArD3A8Wg+2AV$tV>Dr?YxiJOhJ?Jw+y$4Szy z0-tRn1__cFPE{f7b_SD8n|YnuD7GP9AxI$#Arc|LNIrSo9_t?Q$dSmggmD#A6={`& zL>x9#eX@6~P1AlX4t5=rysFe}U4y8D9fRbFUs#|ln#JFXy^2nBaf(fJN%a%;J@wSJ zmkSrZiF{Mg1;5=WKGJC_y^3U11m_fttJuxHC)^+0U)h(rRJnA%w8J)y=886nR*1Gu zl~Zp71#L@=;EZ5!@N@W=IhOg9^)0+`Y7|hs4}cV2DN>qdpl2M3jELklVm7{9W?%MM zF7$aN&eY=Rqw9lvQFZ6>X#FUAcm2{FnGN}~bVG-!?A-W5jDuHyr7bBa<%nnHN3jjE zf;AmU-pf3nJZUR$E6EL$4bX-lqY>i-;|Dbn_0}|_lyAv;X%gJ=+~?dw{0{sdY@N+V zd4Pic=F(LsHFK5|mZvk5<2);8m0PlG#ffddASE~@E;9l%NC&6~+~gc-25FdSh>h&x zF=ldYcAu&|YnLrQOk7oG)S5OflQu~nMIXi=Y0iD&oHeCtYxcQ~`51~kl`|>5sRWMl z6x(NZ*M?e(=nA*E&Uk=CXNA7h?>5mlq4x)$HyR2U$A*Hm!CP|S}#->uYc=58F%8n#uhuunP8Ve7VQ zOeYSPVUMtf>pMx)oR*-vTw#P4Tu4`_Vp!AICL}iwcmm8^-^F%qDh*vBuD0m>*6RHc zF-2Ol)h*}>(q2hbdhv&v5c{4v~W2VdAB^HT(^n!3I2(AHgUb< zcfu4_MDf&9Z7NXR?PBASM7_e&)*1zOZ1BjuftsV-VZ>a;Fan4O%<~yvA78M;-HOt@ z1teO1UDfxS^7p3=MFI+fNJ0fdN`h;~&u-~L4C!v=Xbno`V|LOtQf*|nbZrdw>7)++ zNcx#{i!^H{tU@x4C1YUdaKXINqAxU-eXKM~Fjw%00K~e))@6ihY4b;sJ8zA!Gq{g< zgu~l76x{4?Uq?{K=<>)h%U36K-Ssovsmzi6&OF|S~AZJ_5ef}uD%v~aXwG`Rx50uHoVoMVZb+9;hF{bQpQgB+8pyx$u% zS2-(PqhaKqzf-V?ooz8+?{=wF41QzHD2}t5vm)&?(+kswKB+x7lq(c{tK436TXB2i zeT(S`DeIaL!SS~y0jTlu{EEYo;mXv^!Ssi%*84|t+}F6r7iGH#d$efku4lJz_opxVf;1zu>?Nlpp?(oJJUlH=Y{w3Jf{!j`tFSi74CRcJ zbzYQVVYUDn)btpH_NEO4tz3lc71@WN?q*;n*87#AG5i}%F?hxf(kc0`QH0=HrrW(W@GwwU6R~n};WOpOrZ6dk+s+5g-r>g>pi9IbGasf!xBv!ayz_ zAP*169}f<&x3hF#QsAS`%5dLW#?t%Xdq|jWaA9}lS6`6NJ#8&|Nm$C zZ^r*&8vd8b!}Y(!|1tcFCHbY23JUQZp_l~CGVRW zr2&Gkn+b8uj>2qVG6T6?67bcn<7=3oU*XPaekuIYM|^b()_6Py%Q!xGYRM#c$8LHT z(({TA?{A!xDQ0(*7}xdUtQ!MSxe>UL{sM@>3eWPzzaa&HpjT0JqyGbXyl_excJzN7 zxsfnlScc(Y$wW#01Ej!G9E*b>;VVd?gQML!7NNh``H`{WyWJ(&1Z}lxQ>&-W^8(Yu zgd)hej@a62kD!{v7}HM`mN)v-spwtX3UoV&f<_aKwanmYr0cSz+x-`7bpv>$-k&nK zl-+ykuzKujXqS|-b6*Len0tOpot@5cF}1%Vq}L8~ zzVpF!MN_iJ@qBy9=~@x{)or9e3X#PKSv49J*Zsr!(vt5@&b-~_u!fj3yp8L5sby0i z*`o1wJ7{BC^fc|GL%HEg*mP;@=I``73EYGrVb7`bm4rBJ+WjSuy!muXbTbHCps6Hl z{^}@2Vd(jO5IQVkl9rXexq9$af>CZ-4x}>qGZPDeB5OZ=~jNC&Ug^R)|x2NMNFZ`LlBj>dDvB}8C``?HZm z4C90&X2}*1C&g;wvWHtkjHRN&Z!;^`*JT9xAQFbYWTE*|l|&f)y5txU#e2=Hdctbt zTbuRO7|94Drr>Uj?C_w2IM1610+3a23cq7=k;2pJn>jbDNMLaV^U6A0ivEV`(d%^0 zX!;iTVbSsQckWM4lO|6GQ^lQO!KPO5`U3H{D+7zWj+qONn9HKL$70>7B$D&l8XSvr ztFAKNy&o91uDdak1}Q$51pZ=7=|O|v<8fi--@UilD&|a)(HM`LNg|&ffz_&<0{1=Y zRC_-ijJZN8wLY`REfr4l-_K&|uOK4F#k!SbrG{i+Ze>`9cM(Uux7tLvjc}q7CCa^~ zHhn+y_|>{4E~psl0<=o6TRn3-u3s+I#j3_7k~X`bldrb5x!z{}b#0$Q39FfZv&vn< zzA+3ggQu-~EtuIbHn-+i@r1V>Ib3BuC!0cwUR;pvuky}LRQ zC{+zF?f7}>ty~IA7@kGJ3LdC3GA`?jRkY`r-uWIoDjR|cg54)qEe7uFO~pU9U#CcN z-KV(9K#(lvsC~I2Ce{?=VnuAMtS?ds{f9{%+cSmZSew;EG=AP5A;3n^JcACpF1+dCWbZI!Rm z8NS^VQBiE6dyIo2i}qp!vkN-xd&yl2$K!yy_%Bj6IN6dy1(e>)XAOlP*PnBij6Xy5 zPLEd^GH<_Ti+esWTqjZ@iK0MWs($4dS_Vu@k?J=)%@|<{YxYvFk#L+%);ico0h3~s zCRPntxx$!G@&kjRpQ8pRw~WTYBR)&pr~&dO7e>3Ly&pc!4q+R<$A4bru&zyM)3=$N>g5(`t6`?y*>#r)WMMS zT%B0bjKTNS@iO7C*`;Stq%oWF_38Ik&-{H}_EtH0X(PS5n)IR)i$5qj7N^1UMLHkq zo7qxfkfzcttL_zq8m?u1RytqdESM&)83ar(^7l0ELyfvyv6(T0=idNsOdlG(#H79T zNk=Y~ZP)5R(%J?1A9mgI7TMxvz3NNeX zPPOZ9Q zlL~6ETjG+Y=gMGU3!Ru9_`z3$)&a&>^Rd?EH|Oz@fNZDEq8eq9 zXgJXo#Dl>vlpt3_?l|%3Z5cc>`B98YDZK-`V&d~|7gR8_>y;hj$wnR-etRzrBrhA$ z>hn=B+U)mO@+a(r;I3aET=8)6LM8A%S6MMt%i?;rcA$w=eSYQe4KDJadUYTmj5ouF z_mD70S8gmY)W5QSZa%_hUy5f<;Su9+`yho5XD3xW+4sq#P|`ojo_?0>!L{+fFUj>J zwX;U+0uL~(pus51Yvlz>D7GEQw^%NyTPjTHS{dln(|jUNQ7@a`TkuduvOk}MNod?V zSkGl%c#4!3Q_R1rzK35oR1)Jou0MqK)6~W~Mv>7pOs9sLDmHp{0#@DAqDo#eo`29j zSTO<9YV|X+Nm$;o!DtuP@E9QC!$tbQ=)49BvymuD6Hb{d5fA3?n#17jmned5S5^Dd zx_~JuR1<~QwCV=(ViX>gl3kjdK}p?)QoI)K)w7>PYCMio*sK_Or+oL28~Wu#YIUMM zjv(mFpqj3W<87ecVy(Ki&wFrDmN!7&uemKpx*P~@it!bA=AgS zR$DC^YQoOe(m%odMI z#LeO*^V*t=pZuQir(L=*1je;KY9zE+9$I_$mox@8Hh4NL6E4;;uCIrUNCn2mgYTiq zu2^CrcPYoezMP%0}{ zf*w;`l)c+&F8H0+sPVcqJ$(X1ynUk3D(enfdCi@u!@NUP`L@S#cI9wZ&7>-78aL zpLwDQ@TO?Z5I+)_fj7W{@>U;r!N??Cf=g|dWDZ29ZPf&2aCkMN5%TpUMPx_o>v5(k z8nQ%D{kH?QE#rZN>u!f%2j#VhHiqVw%O>s{zDApPv1`;XSHAhV??gQ(_1wZCQoqY|53D6$ zFGgtIiwZ+%8F0eCh>to(rc+HIOCllAz0?J4M@rKdZvusqv@+q8QLJ{&17luTGZB<( zBk=9xz-rVZeloI z{1yEaag=nKfJD37p(p4KMe95czB?63a8(h*oLv{0b)w9v{k`V{tjUJOBNu zylz7Hl)@v?cE0$1psj#zW7>RK3-?^S$0BT?`Of1Joyq1 zl(lx$yN;9riSW(+tTGN5;TM87W7Wapr(I|_bM;peHW&Z4x(zK}LV4&5{(^qT0if9G z{iZ&*pSjLr^ZbWTK)8TR$ThZDTt6rF=)A4cd`YFuBy**k`XxkS)Iiac; zJwb-9Igh-N1krk|_CVl-v9Y5x?47Dgn&3Jt7C3Z($+eU6JJC7E$CTsa!K##mq`O6) zwtb!-aF61?K>8?Xcc<@);Cq!$%e`aa3fRyl8A|k9&e9AS(E6#!0P%q;-rTLik$pE? z(+nf_V;}2D7GZ$98Rg2ZMs2PNhrN z4%-u+_$7GQmM7|C`L4TGKsn>Xvm zuS#0G1bgke-xuI$oK6@VDqueZU{Ot3bVE`lUBgF9>Tgk)yk5+D%n|Q+^&=moalTU{ z?Pbl^?5vm5CE?>Hzo~rr_VMHwJO?`#Qaoj@-+s($YS>}s-d2Tk=qNmdu0U54WV`uA zSl%1mNqZ{}(i83NHiTIpM0w7EBh%U*T05t2S)N{-KdAiX9(#@mQl4`7_RS5mv-ez= ztX`PbD+%0Pfd_)E9K;3U8C^2_s!TK%na9(oj7bCebLf?JLV@Y<3BIyza8SB;BaV#i zhkf&BcTe-EP{dyR7-Dmh4xqde@b3{o3<*+|Yv^7}stYn)++(q%5x?S1w~7^nVCSV>bW* literal 0 HcmV?d00001