From f44ff97c474d72808fb644048d39cc2cef5440bc Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Tue, 14 Jan 2025 08:11:25 -0800 Subject: [PATCH] Properly test JSC for template_app e2e tests (#48656) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48656 While working on 0.78, I realize we were not testing the template app with JSC. This change should fix this. ## Changelog: [Internal] - Disable Hermes for the JSC E2E tests with Maestro Reviewed By: cortinico, fabriziocucci Differential Revision: D68147849 fbshipit-source-id: 4fbe005b5d04d6163a37041d1bd57fd48a9dfda8 --- .github/workflows/test-all.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index fe6de2c89c6..cbe2a66e6ed 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -369,6 +369,11 @@ jobs: sed -i 's/newArchEnabled=true/newArchEnabled=false/' android/gradle.properties fi + if [[ ${{matrix.jsengine}} == "JSC" ]]; then + echo "Using JSC instead of Hermes" + sed -i 's/hermesEnabled=true/hermesEnabled=false/' android/gradle.properties + fi + # Build cd android CAPITALIZED_FLAVOR=$(echo "${{ matrix.flavor }}" | awk '{print toupper(substr($0, 1, 1)) substr($0, 2)}')