Fixing robolectric tests by not skipping androidx instrumentation

Summary:
androidx files were not being instrumented properly which meant we would have exceptions thrown by powermock

Robolectric Instrumentation config was changed by hand, the remainder is a codemod using abgs + xargs + sed

Differential Revision: D14323745

fbshipit-source-id: 56aa97dad5d7197f4eb0ba1fdd80b1583bcad6ac

ReactAndroid/src/test/java/com/facebook/react/CompositeReactPackageTest.java

@@ -34,7 +34,7 @@ import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.when;
 
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class CompositeReactPackageTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/RootViewTest.java

@@ -52,7 +52,7 @@ import static org.mockito.Mockito.when;
 
 @PrepareForTest({Arguments.class, SystemClock.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class RootViewTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/animated/NativeAnimatedNodeTraversalTest.java

@@ -50,7 +50,7 @@ import static org.mockito.Mockito.verifyNoMoreInteractions;
  */
 @PrepareForTest({Arguments.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class NativeAnimatedNodeTraversalTest {
 
   private static long FRAME_LEN_NANOS = 1000000000L / 60L;

ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.java

@@ -27,7 +27,7 @@ import com.facebook.soloader.SoLoader;
  * Tests for {@link BaseJavaModule} and {@link JavaModuleWrapper}
  */
 @PrepareForTest({ReadableNativeArray.class, SoLoader.class})
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 @RunWith(RobolectricTestRunner.class)
 public class BaseJavaModuleTest {
 

ReactAndroid/src/test/java/com/facebook/react/devsupport/JSDebuggerWebSocketClientTest.java

@@ -26,7 +26,7 @@ import static org.mockito.Mockito.*;
 
 @PrepareForTest({ JSDebuggerWebSocketClient.class })
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class JSDebuggerWebSocketClientTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/modules/blob/BlobModuleTest.java

@@ -41,7 +41,7 @@ import static org.junit.Assert.assertNull;
 
 @PrepareForTest({Arguments.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 @Config(manifest = Config.NONE)
 public class BlobModuleTest {
 

ReactAndroid/src/test/java/com/facebook/react/modules/camera/ImageStoreManagerTest.java

@@ -26,7 +26,7 @@ import static org.junit.Assert.assertFalse;
 import static org.mockito.Mockito.mock;
 
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ImageStoreManagerTest {
 
   @Test

ReactAndroid/src/test/java/com/facebook/react/modules/clipboard/ClipboardModuleTest.java

@@ -27,7 +27,7 @@ import static org.junit.Assert.assertFalse;
 
 @SuppressLint({"ClipboardManager", "DeprecatedClass"})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ClipboardModuleTest {
 
   private static final String TEST_CONTENT = "test";

ReactAndroid/src/test/java/com/facebook/react/modules/dialog/DialogModuleTest.java

@@ -29,7 +29,7 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class DialogModuleTest {
 
   private ActivityController<Activity> mActivityController;

ReactAndroid/src/test/java/com/facebook/react/modules/network/NetworkingModuleTest.java

@@ -67,7 +67,7 @@ import static org.mockito.Mockito.when;
     OkHttpClient.Builder.class,
     OkHttpCallUtil.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class NetworkingModuleTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/modules/network/ReactCookieJarContainerTest.java

@@ -33,7 +33,7 @@ import static org.mockito.Mockito.when;
   ReactCookieJarContainer.class
 })
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 
 public class ReactCookieJarContainerTest {
 

ReactAndroid/src/test/java/com/facebook/react/modules/share/ShareModuleTest.java

@@ -41,7 +41,7 @@ import static org.junit.Assert.assertNotNull;
 
 @PrepareForTest({Arguments.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ShareModuleTest {
 
   private Activity mActivity;

ReactAndroid/src/test/java/com/facebook/react/modules/storage/AsyncStorageModuleTest.java

@@ -55,7 +55,7 @@ import static org.fest.assertions.api.Assertions.assertThat;
  * Tests for {@link AsyncStorageModule}.
  */
 @PrepareForTest({Arguments.class})
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*", "org.json.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*", "org.json.*"})
 @RunWith(RobolectricTestRunner.class)
 public class AsyncStorageModuleTest {
 

ReactAndroid/src/test/java/com/facebook/react/modules/timing/TimingModuleTest.java

@@ -38,7 +38,7 @@ import static org.mockito.Mockito.*;
 // DISABLED, BROKEN https://circleci.com/gh/facebook/react-native/12068
 // t=13905097
 @PrepareForTest({Arguments.class, SystemClock.class, ReactChoreographer.class})
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 @RunWith(RobolectricTestRunner.class)
 public class TimingModuleTest {
 

ReactAndroid/src/test/java/com/facebook/react/uimanager/LayoutPropertyApplicatorTest.java

@@ -42,7 +42,7 @@ import static org.powermock.api.mockito.PowerMockito.mockStatic;
 
 @PrepareForTest({PixelUtil.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class LayoutPropertyApplicatorTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterSpecTest.java

@@ -25,7 +25,7 @@ import org.robolectric.RobolectricTestRunner;
  * Test that verifies that spec of methods annotated with @ReactProp is correct
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactPropAnnotationSetterSpecTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropAnnotationSetterTest.java

@@ -36,7 +36,7 @@ import static org.mockito.Mockito.verifyNoMoreInteractions;
  * annotations.
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactPropAnnotationSetterTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropConstantsTest.java

@@ -32,7 +32,7 @@ import org.robolectric.RuntimeEnvironment;
  * Verifies that prop constants are generated properly based on {@code ReactProp} annotation.
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactPropConstantsTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropForShadowNodeSetterTest.java

@@ -32,7 +32,7 @@ import org.robolectric.RobolectricTestRunner;
  * of properties to be updated.
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactPropForShadowNodeSetterTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/ReactPropForShadowNodeSpecTest.java

@@ -23,7 +23,7 @@ import org.robolectric.RobolectricTestRunner;
  * correct
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactPropForShadowNodeSpecTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/SimpleViewPropertyTest.java

@@ -35,7 +35,7 @@ import static org.fest.assertions.api.Assertions.offset;
  * Verify {@link View} view property being applied properly by {@link SimpleViewManager}
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class SimpleViewPropertyTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleConstantsTest.java

@@ -27,7 +27,7 @@ import org.robolectric.RobolectricTestRunner;
 import org.robolectric.RuntimeEnvironment;
 
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class UIManagerModuleConstantsTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/uimanager/UIManagerModuleTest.java

@@ -58,7 +58,7 @@ import org.robolectric.RuntimeEnvironment;
  */
 @PrepareForTest({Arguments.class, ReactChoreographer.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class UIManagerModuleTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/image/ImageResizeModeTest.java

@@ -20,7 +20,7 @@ import org.robolectric.RuntimeEnvironment;
 import static org.fest.assertions.api.Assertions.assertThat;
 
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ImageResizeModeTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.java

@@ -42,7 +42,7 @@ import static org.junit.Assert.assertNull;
  * by {@link ReactImageManager}.
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactImagePropertyTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/slider/ReactSliderPropertyTest.java

@@ -29,7 +29,7 @@ import static org.fest.assertions.api.Assertions.assertThat;
  * Verify {@link SeekBar} view property being applied properly by {@link ReactSliderManager}
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactSliderPropertyTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/text/CustomLineHeightSpanTest.java

@@ -16,7 +16,7 @@ import org.powermock.core.classloader.annotations.PowerMockIgnore;
 import org.robolectric.RobolectricTestRunner;
 
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class CustomLineHeightSpanTest {
 
   @Test

ReactAndroid/src/test/java/com/facebook/react/views/text/ReactTextTest.java

@@ -57,7 +57,7 @@ import org.robolectric.RuntimeEnvironment;
  */
 @PrepareForTest({Arguments.class, ReactChoreographer.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactTextTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/textinput/ReactTextInputPropertyTest.java

@@ -44,7 +44,7 @@ import static org.fest.assertions.api.Assertions.assertThat;
  * Verify {@link EditText} view property being applied properly by {@link ReactTextInputManager}
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ReactTextInputPropertyTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/textinput/TextInputTest.java

@@ -45,7 +45,7 @@ import org.robolectric.RuntimeEnvironment;
  */
 @PrepareForTest({Arguments.class, ReactChoreographer.class})
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class TextInputTest {
 
   @Rule

ReactAndroid/src/test/java/com/facebook/react/views/view/ColorUtilTest.java

@@ -22,7 +22,7 @@ import static org.junit.Assert.*;
  * Based on Fresco's DrawableUtilsTest (https://github.com/facebook/fresco).
  */
 @RunWith(RobolectricTestRunner.class)
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "android.*"})
+@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
 public class ColorUtilTest {
 
   @Rule